Seungha Yang
fec686145e
codecs: h264decoder: Fix MMCO type 1 for interlaced stream
...
If field_pic_flag of current picture is equal to zero,
both field of reference field pair should be marked as
"unused for reference"
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1810 >
2020-11-16 14:25:36 +00:00
Seungha Yang
b83d452cc2
codecs: h264decoder: Fix MMCO type 3 for interlaced stream
...
Depending on short-ref picture corresponding to picNumX value,
there's a condition that only one field should be updated to
be non-reference picture.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1810 >
2020-11-16 14:25:36 +00:00
Seungha Yang
caa5eb65d1
codecs: h264decoder: Split frame picture into field pictures if needed
...
In case of interlaced stream, frame pictures need to be splitted
into field for reference marking process.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1810 >
2020-11-16 14:25:36 +00:00
Seungha Yang
7b42b1f9fb
codecs: h264decoder: Add util macro for frame/field picture identification
...
Add a macro to check whether given GstH264Picture is for frame or field
decoding.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1810 >
2020-11-16 14:25:36 +00:00
Seungha Yang
a516c79ac9
d3d11window: Prefer full color range for display target colorspace
...
We don't need to preserve input color range for transformed target
color space. Also some GPUs doesn't seem to be happy with 16-235
color range for RGB color space.
Also, since our default display target color space is
DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709, choosing full color range
would make more sense.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1814 >
2020-11-16 20:48:35 +09:00
Jan Schmidt
92472ef088
wpe: Don't crash when running on X11.
...
Don't assume the available EGL display is a wayland display -
instead, check the the GStreamer GL context is EGL, and then
use gst_gl_display_egl_from_gl_display to create a
GstGLDisplayEGL from that, which also adds refcounting
around the underlying EGLDisplay.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1385
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1752 >
2020-11-15 15:27:08 +00:00
Víctor Manuel Jáquez Leal
c118ae11ab
va: allocator: dmabuf: log unknown surface format
...
It is possible that surface format is not assigned, keeping its default
GStreamer value: unknown, but gst_video_format_to_string() doesn't print
unknown format, so this patch does it manually.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1811 >
2020-11-15 09:52:51 +01:00
Víctor Manuel Jáquez Leal
a1e8cb76e7
va: allocator: dmabuf: destroy VASurface if no pooled buffer
...
When gst_va_dmabuf_allocator_setup_buffer_full() receives info (not NULL) it is
supposed that this buffer is not part of the allocator pool, so it has to be
de-allocated as soon it is freed.
This patch sets the destroy notify of the assigned GstVaBufferSurface if info is
not NULL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1811 >
2020-11-15 09:52:01 +01:00
Seungha Yang
9011a58491
vah264dec: Allow missing reference picture
...
baseclass might provide reference picture list with null picture.
Ensure picture before filling picture information.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1809 >
2020-11-14 16:17:18 +00:00
Seungha Yang
f9af93d841
codecs: h264decoder: Don't give up to decode due to missing reference picture
...
Missing reference picture is very common thing for broken/malformed stream.
Decoder should be able to keep decoding if it's not a very critical error.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1809 >
2020-11-14 16:17:18 +00:00
Edward Hervey
50e230a270
mpegtsdemux: Fix off by one error
...
Turns out timestamps of zero are valid :) Fixes issues with streams where the
PTS/DTS would be equal to the first PCR.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1807 >
2020-11-13 17:50:03 +01:00
Seungha Yang
f9a0efe3ed
d3d11h264dec: Add support for interlaced stream
...
Add support for interlaced stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:43 +00:00
Seungha Yang
0b9f975b36
codecs: h264decoder: Add support for interlaced stream
...
Initial support for interlaced stream. Subclass should implement
new_field_picture() vfunc. Otherwise, baseclass will assume that
subclass doesn't support interlaced stream.
Restrictions:
* Reference picture modification process for interlaced stream
is not implemented yet
* PAFF (Picture Adaptive Frame Field) is not properly implemented.
* Field display ordering (e.g., top-field-first) decision should
be enhanced via picture timing SEI parsing
* Gap in field picture should be handled
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:43 +00:00
Seungha Yang
52a8864076
codecs: h264decoder: Rename DPB methods
...
Clarify wheter it's for picture(field) or frame in order to
support interlaced stream, because DPB size is frame unit, not picture
in case of interlaced stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:42 +00:00
Seungha Yang
9bd6b5f0b4
codecs: h264decoder: Remove interlaced stream related constraints
...
... and add new_field_picture() vfunc so that ensure interlaced
decoding support by subclass.
The method will be used later with interlaced stream support.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:42 +00:00
Seungha Yang
5585314b56
codecs: h264decoder: Move to inline GstH264DecoderClass documentation
...
Don't duplicate documentation for class vfunc. Hotdoc doesn't seem
to be happy with duplicated documentation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:42 +00:00
Seungha Yang
7a53d7a4aa
codecs: h264decoder: Store reference picture type using enum value
...
Managing reference picture type by using two variables
(ref and long_term) seems to be redundant and that can be
represented by using a single enum value.
This is to sync this implementation with gstreamer-vaapi so that
make comparison between this and gstreamer-vaapi easier and also
in order to minimize the change required for subclass to be able
to support interlaced.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:42 +00:00
Seungha Yang
157210eb19
codecs: h264decoder: Minor documentation fix
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1534 >
2020-11-13 15:25:42 +00:00
Seungha Yang
227456d240
codecs: h264decoder: Remove DPB size related spammy debug message
...
It's not informative at all if SPS wasn't updated. Also we are printing
DPB size related debug message in another place already.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1806 >
2020-11-13 14:50:09 +00:00
Mathieu Duponchelle
c969239c7c
h264parse: try harder to update timecode
...
NumClockTS is the maximum number of timecodes the pic_timing SEI
can carry, but it is perfectly OK for it to carry fewer, and have
one of the clock_timestamp_flags set to 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1804 >
2020-11-13 13:09:01 +00:00
Mathieu Duponchelle
e93558efac
h264parse: fix installing of update-timecode property
...
Simply fixes a typo that did not have any adverse effect,
and avoid hardcoding initializer
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1805 >
2020-11-12 21:34:18 +00:00
Seungha Yang
6a6f8c967c
codecs: h264decoder: Don't fill gap picture if it's not allowed
...
We should fill gap picture only if sps->gaps_in_frame_num_value_allowed_flag
is set.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1801 >
2020-11-12 14:38:56 +00:00
Aaron Boxer
330b2c6b7c
openjpegenc: store stripe offset when encoding image
...
The decoder can simply read this offset after decoding
to know where to blit the stripe to the full frame
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1800 >
2020-11-12 13:53:47 +00:00
Aaron Boxer
af87da86e2
openjpegenc: take subsampling into account when calculating stripe height
...
We calculate minimum of (stripe height * sub sampling) across all components
to ensure that all component dimensions are consistent with sub-sampling.
The last stripe for each component is simply the remaining height.
limit wavelet resolutions for "thin" stripes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1800 >
2020-11-12 13:53:47 +00:00
Stéphane Cerveau
4f6b609558
openjpegenc: fix memory leak from mstream
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1800 >
2020-11-12 13:53:47 +00:00
Aaron Boxer
7463e1090c
openjpegenc: fail negotation in handle_frame if alignment mismatch
...
If encoder is in stripe mode, then downstream must also support stripe
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1800 >
2020-11-12 13:53:47 +00:00
Seungha Yang
977c3276d4
nvcodec: Fix various typo
...
Not sure where the DECOCER came from
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1803 >
2020-11-12 13:10:13 +00:00
Víctor Manuel Jáquez Leal
5876f232ee
va: comments to explain code
...
There are a couple part where code seems, at least to me, a bit oscure or
confusing. So let's better add an explanation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1802 >
2020-11-12 13:33:26 +01:00
Edward Hervey
7b2368b6df
adaptivedemux: Don't calculate bitrate for header/index fragments
...
They are generally substantially smaller than regular fragments, and therefore
we end up pushing totally wrong bitrates downstream.
Fixes erratic buffering issues with DASH introduced by
66f5e87435
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1021 >
2020-11-11 20:18:11 +00:00
Edward Hervey
dd425fe0fd
adaptivedemux: Store QoS values on the element
...
Storing it per-stream requires taking the manifest lock which can apparenly be
hold for aeons. And since the QoS event comes from the video rendering thread
we *really* do not want to do that.
Storing it as-is in the element is fine, the important part is knowing the
earliest time downstream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1021 >
2020-11-11 20:18:11 +00:00
Edward Hervey
e700a21993
adaptivedemux: Don't calculate bitrate for header/index fragments
...
They are generally substantially smaller than regular fragments, and therefore
we end up pushing totally wrong bitrates downstream.
Fixes erratic buffering issues with DASH introduced by
66f5e87435
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1786 >
2020-11-11 19:46:16 +00:00
Edward Hervey
a4b20ed276
hlsdemux: Don't double-free variant streams on errors
...
If an error happened switching to a new variant, we switch back to the previous
one ... except it will be unreffed when settin git.
In order to avoid such issues, keep a reference to the old variant until we're
sure we don't need it anymore
Fixes cases of double-free on variants and its contents
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1799 >
2020-11-11 19:19:28 +00:00
He Junyan
04472c5adb
codecs: vp8decoder: Fix two typo of struct name.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1797 >
2020-11-11 18:52:37 +00:00
Sanchayan Maity
406cd3bdef
gsta2dpsink: Fix GstPad leak
...
The sinkpad returned by a call to gst_element_get_static_pad needs to be
unrefed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1621 >
2020-11-11 22:19:33 +05:30
Arun Raghavan
8aa6db2c8d
bluez: a2dpsink: Add support for LDAC to a2dpsink
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1621 >
2020-11-11 22:19:33 +05:30
Arun Raghavan
ef3085c743
bluez: avdtpsink: Add support for LDAC to avdtpsink
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1621 >
2020-11-11 22:19:33 +05:30
Sanchayan Maity
a576814553
ext: Add LDAC encoder
...
LDAC is an audio coding technology developed by Sony that enables the
transmission of High-Resolution (Hi-Res) audio contents over Bluetooth.
Currently Adaptive Bit Rate (ABR) as supported by libldac encoder is not
implemented.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1621 >
2020-11-11 22:16:43 +05:30
Seungha Yang
7cec64499d
mpegdemux: Set duration on seeking query if possible
...
Set duration on seeking query in the same way as duration query handler.
Otherwise application might get confused as if the duration is unknown.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1791 >
2020-11-11 14:10:27 +00:00
Raul Tambre
6d300ce785
webrtc: Update libnice version requirement to 0.1.17
...
Since !1366 nice_agent_get_sockets() is used, which requires 0.1.17.
Update the version requirement accordingly.
Fixes #1459 .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1792 >
2020-11-11 13:41:59 +02:00
Edward Hervey
1246b448ee
hlsdemux: Re-use streams if possible
...
When switching variants, try to re-use existing streams/pads instead of creating
new ones. When dealing with urisourcebin and decodebin3 this is not only the
expected way but also avoids a lot of buffering/hang issues.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1757 >
2020-11-11 04:06:05 +00:00
Edward Hervey
f1fdbfc5bd
m3u8: Make a debug function usable elsewhere
...
The rest of the code might want to use this
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1757 >
2020-11-11 04:06:05 +00:00
Thibault Saunier
3a554f6d62
qroverlay: Generate documentation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
e7ec9986ca
qroverlay: Add a qroverlay element that allows overlaying any data
...
This moves `gstqroverlay.c` to `gstdebugqroverlay.c` and implements
a simple `gstqroverlay` element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
7d9f125ab1
qroverlay: Rename qroverlay to debugqroverlay
...
The element is specially focus on debugging purposes and not a generique QR overlay
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
964c8aa5e0
qroverlay: Factor out qroverlay logic to a base class
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
4afa2d2c3d
qroverlay: Factor out qroverlay logic to a base class
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
e6881aefa9
qroverlay: Make subclassable
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
c307f1418d
qroverlay: Port to VideoFilter
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
4a259e8f28
qroverlay: Make default pizel-size 3
...
Otherwise zbar isn't able to read the produced qrcodes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00
Thibault Saunier
dc88d3ece9
qroverlay: Cleanup the way we build the json using json-glib
...
And reindent the .h file removing tabs
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1730 >
2020-11-11 00:18:32 +00:00