mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 03:35:21 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: comments to explain code

Browse source 
There are a couple part where code seems, at least to me, a bit oscure or
confusing. So let's better add an explanation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1802>
This commit is contained in:
Víctor Manuel Jáquez Leal 2020-11-12 13:33:26 +01:00
parent 7b2368b6df
commit 5876f232ee
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/va/gstvabasedec.c
View file

@ -334,6 +334,8 @@ gst_va_base_dec_decide_allocation (GstVideoDecoder * decoder, GstQuery * query)
gst_object_unref (allocator);
gst_object_unref (pool);
/* There's no need to chain decoder's method since all what is
* needed is done. */
return TRUE;
wrong_caps:

9
sys/va/gstvapool.c
View file

@ -145,7 +145,14 @@ gst_va_pool_set_config (GstBufferPool * pool, GstStructure * config)
vpool->caps_info = caps_info;
vpool->alloc_info = alloc_info;
/* May adjust the stride alignment based on the real HW alignment */
/* May adjust the stride alignment based on the real HW alignment:
*
* Counts the number of consecutive bits from lower significant
* bit. This number is then converted to the notion of alignment in
* GStreamer and passed as as constraint in GstVideoAlignment. The
* side effect is that the updated GstVideoInfo is now guarantied to
* endup with the same stride (ndufresne).
*/
if (vpool->need_alignment) {
for (i = 0; i < GST_VIDEO_INFO_N_PLANES (&alloc_info); i++) {
gint nth_bit;