mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 08:42:32 +00:00
Code Issues 1 Projects Releases Wiki Activity

gsta2dpsink: Fix GstPad leak

Browse source 
The sinkpad returned by a call to gst_element_get_static_pad needs to be
unrefed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1621>
This commit is contained in:
Sanchayan Maity 2020-10-27 19:53:44 +05:30
parent 8aa6db2c8d
commit 406cd3bdef
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/bluez/gsta2dpsink.c
View file

@ -96,6 +96,7 @@ gst_a2dp_sink_init_element (GstA2dpSink * self, const gchar * elementname,
GST_ERROR_OBJECT (self, "Failed to set target for ghost pad");
goto remove_element_and_fail;
}
gst_object_unref (sinkpad);
if (!gst_element_sync_state_with_parent (element)) {
GST_DEBUG_OBJECT (self, "%s failed to go to playing", elementname);
@ -105,6 +106,7 @@ gst_a2dp_sink_init_element (GstA2dpSink * self, const gchar * elementname,
return element;
remove_element_and_fail:
gst_object_unref (sinkpad);
gst_element_set_state (element, GST_STATE_NULL);
gst_bin_remove (GST_BIN (self), element);
return NULL;