Mark Felder
ece063586b
Limit backup jobs to 5 minutes
2024-07-23 10:30:57 -04:00
Mark Felder
8f285a787f
Refactor backups to be fully controlled by Oban
2024-07-23 10:30:40 -04:00
Mark Felder
2ee8f4f062
Fix dialyzer error
...
lib/pleroma/application.ex:1:pattern_match The pattern can never match the type true.
2024-07-23 10:25:39 -04:00
Mark Felder
12f498bc0d
Fix order of args for show_reblogs/2
2024-07-22 19:19:21 -04:00
Mark Felder
3f4f567c9c
Fix order of args for hide_reblogs/2
2024-07-22 19:16:00 -04:00
Mark Felder
adb93f7e5d
Fix order of args for unfollow/2
2024-07-22 19:11:22 -04:00
Mark Felder
f79a16c062
Fix order of args for follow/2
2024-07-22 19:07:55 -04:00
Mark Felder
082319ff48
Fix order of args for unblock/2
2024-07-22 18:44:32 -04:00
Mark Felder
cbc5e48417
Fix order of args for block/2
2024-07-22 18:41:50 -04:00
Mark Felder
1cccc0fc21
Fix order of args for vote/3
2024-07-22 18:38:02 -04:00
Mark Felder
8127e0d8cc
Fix order of args for thread_muted?/2
2024-07-22 18:25:37 -04:00
Mark Felder
4601473aaf
Fix order of args for add_mute/2
2024-07-22 18:25:37 -04:00
Mark Felder
d27ad36ce4
Fix order of args for remove_mute/2
2024-07-22 18:25:37 -04:00
Mark Felder
f602813d31
Fix order of args for update/2
2024-07-22 18:25:37 -04:00
Mark Felder
7e37882cf7
Fix order of args for favorite/2
2024-07-22 18:25:37 -04:00
Mark Felder
b1d3348331
Annotate public functions with typespecs and mark some functions as private
2024-07-22 18:25:33 -04:00
Mark Felder
3a79f060bb
Add missing type
2024-07-22 15:32:20 -04:00
feld
f77911f05b
Merge branch 'oban/more-improvements' into 'develop'
...
Oban: more improvements
See merge request pleroma/pleroma!4187
2024-07-22 17:45:44 +00:00
Mark Felder
f9647a86ed
Fix the ObjectValidator error matching
2024-07-21 00:03:51 -04:00
Mark Felder
fb654acfad
Fix OpenGraph and Twitter metadata providers when parsing objects with no content or summary fields.
2024-07-20 23:48:54 -04:00
Mark Felder
fdeb8616e8
Increase timeout for background, remote fetcher, and user refresh jobs
2024-07-20 22:16:33 -04:00
Mark Felder
d62a9afed3
Improved detecting unrecoverable errors for incoming federation jobs
2024-07-20 21:53:03 -04:00
Mark Felder
b8503f1ad4
PollWorker jobs will not retry if the activity no longer exists.
2024-07-20 21:24:13 -04:00
Mark Felder
e509519db4
Publisher jobs will not retry if the error received is a 400
2024-07-20 21:21:21 -04:00
feld
e4a6973e0b
Merge branch 'transmogrifier/handle-non-validate-delete-errors' into 'develop'
...
Transmogrifier: handle non-validate errors on incoming Delete activities
See merge request pleroma/pleroma!4185
2024-07-21 00:47:10 +00:00
Mark Felder
d44765bc13
Support cancelling jobs when Unreacting
2024-07-20 15:14:46 -04:00
Mark Felder
304b7f5093
Support cancelling jobs when Unrepeating
2024-07-20 15:06:19 -04:00
Mark Felder
86ae00f9da
Support cancelling jobs when Unfavoriting
2024-07-20 14:54:31 -04:00
Mark Felder
62280a3b9f
Cancel queued (undelivered) publishing jobs for an activity when deleting that activity.
2024-07-20 14:54:04 -04:00
Mark Felder
d3c2180181
Formatting
2024-07-18 12:12:34 -04:00
Mint
1f3ac66844
Transmogrifier: handle non-validate errors on incoming Delete activities
...
This should fix WithClauseError resulting in Oban jobs for processing
incoming deletes being retried without getting cancelled when those
deletes are MRF rejected.
2024-07-18 18:04:32 +03:00
feld
c45ee5fc82
Merge branch 'oban/fetcher-rejected' into 'develop'
...
Dialyzer fix for RemoteFetcherWorker
See merge request pleroma/pleroma!4183
2024-07-17 18:03:48 +00:00
Mark Felder
c05cbaa937
Dialyzer fix for RemoteFetcherWorker
2024-07-17 13:42:13 -04:00
Mark Felder
f753bd3380
Explicitly handle the GET and HEAD errors
2024-07-17 13:12:51 -04:00
Mark Felder
1e0d5934d5
Fix return for cancelling job
2024-07-17 12:51:38 -04:00
Mark Felder
d124d8645e
Rework some Rich Media functionality for better error handling
...
Oban should not retry jobs that are likely to fail again
2024-07-17 12:40:07 -04:00
Mark Felder
4cbb59c8f6
Add Oban Live Dashboard
2024-07-17 09:32:29 -04:00
Mark Felder
c9203f125c
Added a Mix task "pleroma.config fix_mrf_policies" which will remove erroneous MRF policies from ConfigDB
2024-07-15 15:21:16 -04:00
Mark Felder
30defb1674
Create a DeleteWorker and change user and instance deletion jobs to use it
...
These deletion tasks are slow, but the other background jobs are not. This
will allow us to have a lower timeout on the normal background jobs.
2024-07-15 11:58:07 -04:00
Mark Felder
2f14990c5c
Change PurgeExpiredActivity to use the background queue
2024-07-15 11:45:13 -04:00
Mark Felder
2e2caad28d
Fix Oban jobs exiting with :error instead of :cancel
2024-07-15 11:45:12 -04:00
Mark Felder
1e8d1904e6
Define missing Oban timeouts
2024-07-15 10:27:37 -04:00
Mark Felder
f52b229baa
Oban: change :discard return values to :cancel
...
:discard will be removed in Oban 3.0. It was only meant for internal use.
2024-07-12 11:40:59 -04:00
feld
3754713599
Merge branch 'oban/fetcher-discard-rejected' into 'develop'
...
Discard Remote Fetcher jobs which errored due to an MRF rejection
See merge request pleroma/pleroma!4174
2024-07-12 14:56:55 +00:00
Mark Felder
b051e68bb0
Discard Remote Fetcher jobs which errored due to an MRF rejection
2024-07-12 10:15:02 -04:00
Taylan Kammer
03c3c58d74
LDAP Authenticator: Improve error reporting.
2024-07-10 09:22:58 +02:00
Mark Felder
272aae157e
Refactor maybe_handle_group_posts/1
2024-07-06 17:02:33 -04:00
Mark Felder
3127c5f0af
Fix automatic LDAP account registration on OTP 24.3+
2024-07-01 15:58:15 -04:00
Mark Felder
9402789437
Dialyzer: fix typespec
2024-07-01 11:47:27 -04:00
Mark Felder
b283b686c4
Dialyzer: Function application with args (_ :: map()) will not succeed.
2024-07-01 11:45:27 -04:00
Mark Felder
7955cd90e6
Dialyzer: The guard clause can never succeed.
2024-07-01 11:45:27 -04:00
Mark Felder
fd62969dc4
Dialyzer: pattern can never match the type
2024-07-01 11:45:25 -04:00
Mark Felder
a008005bdd
Dialyzer: fix typespec
2024-07-01 11:38:40 -04:00
Mark Felder
69482004fc
Dialyzer: pattern can never match the type because it is covered by previous clauses.
2024-07-01 11:38:40 -04:00
Mark Felder
fb52099a13
Elixir 1.17 single quote charlist warning
2024-07-01 11:38:40 -04:00
Mark Felder
6e1aa8aeeb
Elixir 1.17 undefined module warning
...
Fixes module name being not fully qualified
warning: AdminAPI.FallbackController.call/2 is undefined (module AdminAPI.FallbackController is not available or is yet to be defined)
│
5 │ defmodule Pleroma.Web.AdminAPI.RuleController do
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ lib/pleroma/web/admin_api/controllers/rule_controller.ex:5: Pleroma.Web.AdminAPI.RuleController.action/2
warning: AdminAPI.FallbackController.init/1 is undefined (module AdminAPI.FallbackController is not available or is yet to be defined)
│
5 │ defmodule Pleroma.Web.AdminAPI.RuleController do
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ lib/pleroma/web/admin_api/controllers/rule_controller.ex:5: Pleroma.Web.AdminAPI.RuleController.action/2
2024-07-01 11:38:40 -04:00
Mark Felder
d3cccce9fd
Elixir 1.17 warnings for parens
...
Function calls must have parens
2024-07-01 11:38:40 -04:00
lain
ccbbee7963
Merge branch 'exif' into 'develop'
...
Ensure StripLocation works for PNGs
See merge request pleroma/pleroma!4167
2024-06-30 09:28:17 +00:00
Lain Soykaf
6d4fb53206
StripLocation: Remove all PNG extra info to make sure that GPS data is gone.
2024-06-28 21:59:00 +04:00
feld
801a9367d0
Merge branch 'fix/oban-user-refresh-unique' into 'develop'
...
Oban Jobs for refreshing users were not respecting the uniqueness setting
See merge request pleroma/pleroma!4164
2024-06-28 14:47:25 +00:00
Mark Felder
9e5adf31c0
Change Gun connection pool logs to debug
2024-06-28 10:23:02 -04:00
Mark Felder
51a36bc9b8
Oban Jobs for refreshing users were not respecting the uniqueness setting
2024-06-28 10:12:58 -04:00
Mark Felder
b135fa35a1
RichMedia: test that activity is streamed out
2024-06-24 09:47:16 -04:00
Mark Felder
634e3d4155
Add test validating the activity_id is correctly present in the Oban job
...
This was preventing the activity from being streamed over websockets.
2024-06-23 21:45:56 -04:00
Mark Felder
9ef021e2da
Switch the reclaimer to GenServer.start so it is not linked
2024-06-20 14:17:28 -04:00
Mark Felder
c765fcbe7e
Gun Connection Pool: successfully retry after reclaiming the pool
2024-06-20 14:03:22 -04:00
Mark Felder
17d04ccc8b
RichMedia backfill processing through Oban
2024-06-19 23:20:22 -04:00
Mark Felder
4dfa50f256
Rename RichMediaExpirationWorker to RichMediaWorker
2024-06-19 22:24:48 -04:00
Mark Felder
ed2976b237
Custom mix task to retry failed tests once in CI pipeline
...
This will be temporary* as we hunt down the cause of the random test failures
* gonna regret this
2024-06-19 19:04:12 -04:00
Mark Felder
3a8420b141
Remove remaining vestiges of Logger support in ConfigDB/TransferTask
2024-06-19 14:29:44 -04:00
Mark Felder
e43e09a04c
Merge remote-tracking branch 'origin/develop' into bugfix/elixir-1.15
2024-06-18 16:47:01 +00:00
Mark Felder
9c67637255
Refactor the async user refreshing to use Oban
...
Previous implementation could cause duplicate simultaneous profile fetches which is not polite.
2024-06-17 10:41:14 -04:00
Mark Felder
e37845cd35
Stale user refreshing should be done async to prevent blocking of rendering activities
2024-06-16 17:39:35 -04:00
Mark Felder
cbf8f8ac0d
Fix mix pleroma.config dump on Elixir 1.15
2024-06-13 10:48:50 -04:00
Lain Soykaf
41434ffcec
Tests: Don't spawn processes in tests.
2024-06-12 15:20:04 -04:00
Haelwenn (lanodan) Monnier
c389ea0f42
Fix compatibility with Loggers in Elixir 1.15+
2024-06-12 15:18:47 -04:00
Haelwenn (lanodan) Monnier
2180537a2b
MediaProxy: :whitelist config fallback to []
2024-06-12 15:18:47 -04:00
Haelwenn (lanodan) Monnier
66ac2e9b81
Upload.base_url: Don't pass nil to Path.join(), don't return nil
2024-06-12 15:18:47 -04:00
Haelwenn (lanodan) Monnier
cb91dab75f
Switch formatting checks to Elixir 1.15
2024-06-12 15:18:47 -04:00
Lain Soykaf
1ae5c2b020
Transmogrifier: Encode Emoji id to be valid.
2024-06-12 12:41:33 +04:00
Mark Felder
5c8afbe646
Fix tests
2024-06-11 18:55:10 -04:00
Mark Felder
6a9d9da26f
Cyclical complexity
2024-06-11 18:38:41 -04:00
Mark Felder
603a575766
The user is not always preloaded into the notification
2024-06-11 18:14:07 -04:00
Mark Felder
568819c08a
WebPush refactoring: separate build and deliver steps
2024-06-11 17:58:02 -04:00
feld
f47a124698
Merge branch 'webpush-polls' into 'develop'
...
Render nice web push notifications for polls
See merge request pleroma/pleroma!4144
2024-06-11 20:24:15 +00:00
Mark Felder
5313255b1a
Use conn.request_path for more legible error log
2024-06-11 16:07:22 -04:00
Mark Felder
c1b84edefc
Increase web push character limit for the body
2024-06-08 22:48:38 -04:00
Mark Felder
dcc50da400
Stream the notifications as part of the job
2024-06-08 22:40:08 -04:00
Mark Felder
3211557f74
Render nice web push notifications for polls
2024-06-08 22:08:12 -04:00
Mark Felder
b1ef6e5e9a
Cleanup to make the code easier to follow
2024-06-08 19:50:01 -04:00
Mark Felder
86fa0889bc
Remove unnecessary mastodon_type hack
2024-06-08 19:30:27 -04:00
Mark Felder
db88bf30d5
Add spec for send/1
2024-06-08 19:20:38 -04:00
Mark Felder
07cb89823f
More robust validation the vapid config is set
2024-06-08 18:59:51 -04:00
Mark Felder
471412ad34
Stream end of poll notification over websockets and web push
2024-06-08 13:19:41 -04:00
Mark Felder
b1c52c3062
Rename Notification.send/1 to Notification.stream/1
...
Also update other places where we use the term "send" instead of "stream". This should make it clearer that we are streaming these over websockets / web push and not sending an activity.
2024-06-08 13:14:25 -04:00
feld
b23b007d00
Merge branch 'feld/cleanup' into 'develop'
...
Minor cleanup commits
See merge request pleroma/pleroma!4142
2024-06-07 21:52:55 +00:00
feld
a4bd89c77e
Merge branch 'spex/notification-types' into 'develop'
...
Spex: Add missing notification types to the api spec
See merge request pleroma/pleroma!4141
2024-06-07 20:42:50 +00:00
feld
f44987bd0f
Merge branch 'bugfix/rich_media_config' into 'develop'
...
RichMedia: Respect configuration on status previews
See merge request pleroma/pleroma!4130
2024-06-07 20:37:19 +00:00
Mark Felder
5ed07aba7a
Add missing pool to the type
2024-06-07 16:34:32 -04:00
Mark Felder
6ded017dee
Do not start unused ConcurrentLimiter processes
2024-06-07 16:34:13 -04:00