mirrors/pleroma
1
0
Fork 0
mirror of https://git.pleroma.social/pleroma/pleroma.git synced 2024-12-31 04:20:32 +00:00
Code Issues Projects Releases Wiki Activity

Fix tests

Browse source
This commit is contained in:
Mark Felder 2024-06-11 18:54:22 -04:00
parent 6a9d9da26f
commit 5c8afbe646
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/pleroma/web/push/impl.ex
View file

@ -21,9 +21,7 @@ defmodule Pleroma.Web.Push.Impl do
@doc "Builds webpush notification payloads for the subscriptions enabled by the receiving user"
@spec build(Notification.t()) ::
list(%{content: map(), subscription: Subscription.t()})
| :error
| {:error, :unknown_type}
list(%{content: map(), subscription: Subscription.t()}) | []
def build(
%{
activity: %{data: %{"type" => activity_type}} = activity,
@ -62,9 +60,9 @@ defmodule Pleroma.Web.Push.Impl do
end)
end
def build(_) do
Logger.warning("Unknown notification type")
{:error, :unknown_type}
def build(notif) do
Logger.warning("WebPush: unknown activity type: #{inspect(notif)}")
[]
end
@doc "Deliver push notification to the provided webpush subscription"

7
test/pleroma/web/push/impl_test.exs
View file

@ -5,6 +5,7 @@
defmodule Pleroma.Web.Push.ImplTest do
use Pleroma.DataCase, async: true
import ExUnit.CaptureLog
import Mox
import Pleroma.Factory
@ -62,8 +63,10 @@ defmodule Pleroma.Web.Push.ImplTest do
end
@tag capture_log: true
test "returns error if notif does not match " do
assert Impl.build(%{}) == {:error, :unknown_type}
test "returns error if notification activity type does not match" do
assert capture_log(fn ->
assert Impl.build(%{}) == []
end) =~ "WebPush: unknown activity type"
end
@tag capture_log: true