Nicola Murino
b5cefffb9f
motioncells: use standard macro for boolean
...
https://bugzilla.gnome.org/show_bug.cgi?id=730141
2014-05-30 16:58:59 -03:00
Matthew Waters
5eb4934750
glimagesink: unref the old buffer outside the lock
...
it could very well deadlock
https://bugzilla.gnome.org/show_bug.cgi?id=723529
2014-05-30 11:46:00 +10:00
Matthew Waters
1cb7e22b98
Revert "[880/906] glimagesink: remove unused stored_buffer field"
...
This reverts commit af3a68db7d
.
Conflicts:
ext/gl/gstglimagesink.c
https://bugzilla.gnome.org/show_bug.cgi?id=723529
2014-05-30 11:35:04 +10:00
Matthew Waters
da35876537
glfeature: remove GST_GL_API_GLES3
...
instead check the gl version using gst_gl_context_check_gl_version()
2014-05-30 10:29:37 +10:00
Sebastian Dröge
546feaef5c
mssdemux: Always use the redirect target to resolve relative URIs
...
But redownload the playlists from the original URI if it's not
a permanent redirect.
2014-05-28 12:56:24 +02:00
Sebastian Dröge
ae679506b1
dashdemux: Always use the redirect target to resolve relative URIs
...
But redownload the playlists from the original URI if it's not
a permanent redirect.
2014-05-28 12:47:51 +02:00
Sebastian Dröge
9cb3d745db
hlsdemux: Don't set base URI if there was no redirect
2014-05-28 12:47:22 +02:00
Damian Ziobro
5ca7684b7d
hlsdemux: Make parsing of "-quoted key URIs more resilient
...
https://bugzilla.gnome.org/show_bug.cgi?id=730830
2014-05-28 10:58:21 +02:00
Sebastian Dröge
2f39a3d711
hlsdemux: Always use the redirect target to resolve relative URIs
...
But redownload the playlists from the original URI if it's not
a permanent redirect.
2014-05-28 10:19:40 +02:00
Matthew Waters
6ce3b82efe
gl/upload: add GstGLUploadMeta object
...
That simply deals with the provider aspect of GstVideoGLTextureUploadMeta.
2014-05-28 14:41:35 +10:00
Julien Isorce
6c92286c6e
glimagesink: make it actually honor show-preroll-frame property
...
https://bugzilla.gnome.org/show_bug.cgi?id=730802
2014-05-27 11:28:27 +01:00
Miguel París Díaz
93ba600ba9
opusenc: Use aux vars to minimize critical region
...
This avoid dead lock between gst_audio_encoder_finish_frame() and
gst_opus_enc_get_property().
Also, now bytes var is set into protected section.
https://bugzilla.gnome.org/show_bug.cgi?id=729882
2014-05-26 09:23:42 +02:00
Damian Ziobro
5b547a553d
hlsdemux: Fix storing of the IV based on the media sequence number
...
https://bugzilla.gnome.org/show_bug.cgi?id=730574
2014-05-22 13:27:37 +02:00
L. Sorin
5edf0add57
curlsshsink: post error on bus in element, not transfer thread
...
Looks like this file was missed in Bug 728960:
https://bugzilla.gnome.org/show_bug.cgi?id=728960
https://bugzilla.gnome.org/show_bug.cgi?id=730459
2014-05-21 08:36:51 +02:00
Matthew Waters
37c08c58c5
gl/eglimage: add eglimage context feature
...
Allows us to selectively use EGLImages only when available
https://bugzilla.gnome.org/show_bug.cgi?id=728234
2014-05-20 23:37:52 +10:00
L. Sorin
9c1e66302d
curlsftpsink: authenticate remote host via public key fingerprint
...
Expose one more libcurl option: CURLOPT_SSH_HOST_PUBLIC_KEY_MD5.
This allows authenticating the server by the MD5 fingerprint of
the server's public key.
https://bugzilla.gnome.org/show_bug.cgi?id=723167
2014-05-20 08:58:08 +02:00
Sebastian Dröge
8070b4e043
glimagesink: Check if context creation failed before trying to use it
...
Otherwise we will cause assertions everywhere by passing NULL to functions
and eventually crash when dereferencing a NULL pointer.
https://bugzilla.gnome.org/show_bug.cgi?id=730069
2014-05-19 12:25:51 +02:00
Sebastian Dröge
cbc37f389f
rsvgdec: Unref handle and output state on error paths
...
CID 1214604
2014-05-19 09:12:14 +02:00
Nicola Murino
bd34e62872
motioncells: fix memleak
...
Check gst_buffer_map return and remember to unmap and free memory before
returning
https://bugzilla.gnome.org/show_bug.cgi?id=730133
2014-05-14 20:15:05 -03:00
Matthew Waters
ce561913de
gl/download: update to be similar to the glupload semantics
2014-05-14 11:38:01 +10:00
Thiago Santos
a99175a31a
hlssink: do not leak playlist object
...
In finalize, also release the playlist
2014-05-13 16:29:46 -03:00
Thiago Santos
16d969b945
dashdemux: mpdparser: properly unref gstdatetime
...
Avoid leaking the GstDateTime instances when summing dates
CID #1212143
2014-05-13 11:22:58 -03:00
Thiago Santos
288e8d5c0e
dashdemux: mpdparser: avoid double free of segment timeline node
...
The parsing function already frees the old value (if any), avoid a double
free by not freeing it before calling the function without setting the
pointer to NULL
Coverity ID: 1212178
2014-05-13 10:45:29 -03:00
Thiago Santos
64bea0252b
dashdemux: mpdparser: avoid double free
...
The _parse_url function already frees the previous pointer, avoid
freeing it before without setting to null or we have a double free.
Coverity ID: 1212181
Coverity ID: 1212180
Coverity ID: 1212179
2014-05-13 10:13:37 -03:00
Edward Hervey
8299c5b5b4
schrodec: Use pool configuration
...
It was leaking the config, but also not using it...
CID #1212155
2014-05-13 14:21:15 +02:00
Edward Hervey
adecec882a
rsvg: Don't leak GstVideoCodecState
...
And avoid useless call to _get_output_state (set_output_state() already
returns it).
CID #1212160
CID #1212161
2014-05-13 14:15:24 +02:00
Edward Hervey
651a4ae2e7
dash: Don't leak GstActiveStream
...
CID #1212142
2014-05-13 13:52:48 +02:00
Thiago Santos
ce7319c62d
mssdemux: avoid deadlocking when erroring
...
It might get stuck when posting the message while
a reconfigure event is being pushed upstream
2014-05-12 18:28:45 -03:00
Thiago Santos
a1f87d0b4f
mssdemux: fix caps leak
2014-05-12 18:08:12 -03:00
Thiago Santos
6b8448c245
mssdemux: handle error messages from internal source
...
set up a bin message handler to get notified of error messages from
the internal source element
2014-05-12 18:08:12 -03:00
Thiago Santos
b627d7df83
mssdemux: Always accept the latency configure event
...
Upstream or internal elements are irrelevant and we should
always succeed.
2014-05-12 16:27:37 -03:00
Thiago Santos
b54367e211
mssdemux: reenable segment tracking for streams
...
Store the latest pushed timestamp so that mssdemux streams know
where they are in time
2014-05-12 16:27:37 -03:00
Thiago Santos
45d5859131
mssdemux: deprecate unused max-queue-size-buffers
...
There is no internal storage of buffers anymore
2014-05-12 16:27:37 -03:00
Thiago Santos
99a2e425de
mssdemux: measure bitrate similarly to hlsdemux
...
new bitrate = (old bitrate + (last fragment bitrate * 3)) / 4
2014-05-12 16:27:37 -03:00
Thiago Santos
90577c3ae7
mssdemux: remove uridownloader in favor of internal source
...
Refactor mssdemux to remove uridownloader to use an internal
source element which reduces startup latency and provides smaller
buffers for better buffering management downstream
2014-05-12 16:27:37 -03:00
Thiago Santos
4c59f7df4c
dashdemux: initialize the mutex and cond for fragment download
2014-05-12 16:27:37 -03:00
Thiago Santos
21b1d37023
dashdemux: remove unused stream uridownloader
...
The uridownloader for the stream fragments isn't used anymore.
2014-05-11 15:26:45 -03:00
Sebastian Dröge
d578cbf7d7
assrender: Do not try to add a feature to a caps features ANY
...
It does not makes sense and asserts
Based on 7f9aac386f
from gst-plugins-base.
2014-05-11 07:56:50 +02:00
Tim-Philipp Müller
ab783acd7f
rtmpsrc: error out if we get EOS immediately without any data
...
It's not really right to just go EOS as if nothing was wrong.
2014-05-10 12:57:29 +01:00
Sebastian Dröge
951bb53057
hls: Remove invalid free
...
data does not have to be freed at all here, it's a pointer to
an arbitrary position inside the current line. Also don't reuse
the data variable for anything else, that will cause crashes
in playlists that have the I-frame playlist URI followed by
other attributes.
CID 1212127
2014-05-09 15:30:00 +02:00
Julien Isorce
9a917fb8a9
gleffects: use gl_vtable
2014-05-08 16:08:08 +01:00
Matthew Waters
a49a371710
gl/upload: implement lazy init
...
Rename init_format to set_format
2014-05-08 15:33:43 +10:00
Matthew Waters
a27589629d
gl: advertise GstGLMemory usage in the caps as capsfeatures
...
https://bugzilla.gnome.org/show_bug.cgi?id=729658
2014-05-07 21:48:57 +10:00
Thiago Santos
a5b3ba09b8
dashdemux: deprecate max-buffering-time property
...
It is not used as dashdemux doesn't have a internal buffer
for fragments anymore
2014-05-07 01:00:50 -03:00
Thiago Santos
e9638fe3fd
dashdemux: removing old unused code
...
The 'catch up mode' isn't needed anymore since dashdemux
is downloading and pushing from the same thread
2014-05-07 01:00:49 -03:00
Thiago Santos
5df2edf80c
dashdemux: remember to set starting fragment to new fragments
2014-05-07 01:00:49 -03:00
Thiago Santos
733c7c0f16
dashdemux: handle a few more error cases
...
related to missing plugins, bad URI and a lockup on dealing with
errors from the source.
2014-05-07 01:00:49 -03:00
Thiago Santos
173c353716
dashdemux: Only set timestamp to the first buffer of fragments
...
Setting it to the other parts of the fragment is slightly wrong
and misleading as it isn't accurate enough.
2014-05-07 01:00:49 -03:00
Thiago Santos
f09dd7e7a5
dashdemux: handle error messages from the sources
...
Set up a message handling function to be able to catch errors
from the source element and signal the cond to allow the download
loop to retry the download.
2014-05-07 01:00:49 -03:00
Thiago Santos
15952dcd8e
dashdemux: check for errors between downloads
...
To abort earlier in case of failures
2014-05-07 01:00:49 -03:00
Thiago Santos
b5998a4c3b
dashdemux: Always accept the latency configure event
...
Upstream or internal elements are irrelevant and we should
always succeed.
2014-05-07 01:00:49 -03:00
Thiago Santos
d6671e73a6
dashdemux: measure download rate just like hlsdemux
...
new bitrate = (old bitrate + (last fragment bitrate * 3)) / 4
2014-05-07 01:00:49 -03:00
Thiago Santos
bed3d66605
dashdemux: remove uridownloader from fragments download
...
Instead, use a source element linked to a ghostpad to provide
smaller buffers and more granular control for downstream
buffering elements while also reducing startup latency
2014-05-07 01:00:49 -03:00
Matthew Waters
6f4fd70867
gl/sink: make sure we always initialize the upload object
...
https://bugzilla.gnome.org/show_bug.cgi?id=729542
2014-05-07 09:12:23 +10:00
Thiago Santos
7dfd308e8c
hlsdemux: fix internal source event leaks
2014-05-06 19:24:55 -03:00
Olivier Crête
0566be384d
srtpdec: Don't reset stream if the key hasn't changed
2014-05-06 00:49:59 -04:00
Olivier Crête
b2a6490626
srtpdec: Add "remove-key" action signal to remove a single key
...
Removing all the keys can be a problem as it also resets the various
counters, so instead add an option to remove a single key.
2014-05-06 00:49:59 -04:00
Olivier Crête
53a4e05261
srtpenc: Use %u in templates to match rtpbin
2014-05-06 00:49:22 -04:00
Olivier Crête
8c9b1ade36
srtpdec: Remove unused field
2014-05-06 00:49:15 -04:00
Thiago Santos
b891bd04d5
hlsdemux: Only set the segment position if there is a timestamp
...
Only the first buffer of a fragment has its timestamp set, so only
update the segment.position when pushing those buffers to avoid
having GST_CLOCK_TIME_NONE set to the position
https://bugzilla.gnome.org/show_bug.cgi?id=729364
2014-05-05 11:35:35 -03:00
Sebastian Dröge
0ce2b0632e
hlsdemux: Set Cache-Control header according to the caching requirements of the playlist
2014-05-05 09:46:06 +02:00
Sebastian Dröge
3c2fe80ab6
mssdemux: Update for uri downloader API changes
2014-05-05 09:41:51 +02:00
Sebastian Dröge
bb8227e279
dashdemux: Update for uri downloader API changes
2014-05-05 09:41:51 +02:00
Sebastian Dröge
816000f726
hls: Store allowcache playlist field in a boolean
2014-05-05 09:41:51 +02:00
Olivier Crête
5d3ce2c611
srtpenc: Add config for the replay window size
2014-05-02 17:27:56 -04:00
Olivier Crête
b51344651e
srtpenc: Remove unused object members
2014-05-02 17:25:35 -04:00
Olivier Crête
820200e20e
srtpenc: Remove useless structure
...
Remove now useless structure
2014-05-02 17:19:51 -04:00
Olivier Crête
2906fae146
srtpenc: Remove ssrc parsing from stream
...
It's no longer used
2014-05-02 17:19:51 -04:00
Olivier Crête
98f8bf46df
srtpenc: Remove SSRC from signal, it's meaningless
2014-05-02 17:19:51 -04:00
Olivier Crête
5a38ae5a83
srtpenc: Set the SRTP key as a shared key for all SSRCs
...
This is already how it was used.
2014-05-02 17:19:51 -04:00
Sebastian Dröge
1aacd0a963
hlsdemux: Update for URI downloader API changes
...
And make sure to set refresh=TRUE when updating the playlist.
2014-05-02 10:44:41 +02:00
Sebastian Dröge
5d34b071d9
mssdemux: Update for URI downloader API changes
...
And include the manifest file as referer in requests, and make sure
to set refresh=TRUE when updating the manifest.
2014-05-02 10:43:06 +02:00
Sebastian Dröge
f910ffb637
dashdemux: Update for URI downloader API changes
...
And include the MPD file as referer in requests, and make sure
to set refresh=TRUE when updating the MPD.
2014-05-02 10:39:22 +02:00
Matthew Waters
dfc6745143
gl: use the bufferpool's upload when available
...
Avoids duplicating GL resources
https://bugzilla.gnome.org/show_bug.cgi?id=728872
2014-05-02 15:59:28 +10:00
Olivier Crête
775e998dab
srtpdec: Only clear streams if they have been created
2014-05-01 19:16:35 -04:00
Olivier Crête
494b8e110d
srtpdec: Use object debug
2014-05-01 19:10:43 -04:00
Sebastian Dröge
9c7da93b9d
hlsdemux: Always succeed the LATENCY event
...
Upstream and our internal source is irrelevant for the latency
and we don't want the LATENCY event to ever fail.
2014-05-01 16:18:37 +02:00
Sebastian Dröge
126891e9a5
hlsdemux: Reset the last flow return before restarting the internal source
...
Otherwise we will never recover from previous errors, and especially
will never start again after a flushing seek if downstream returned
GST_FLOW_FLUSHING to us.
2014-05-01 16:18:37 +02:00
Sebastian Dröge
0d5dcba778
hlsdemux: Only set PTS on the first buffer of a fragment instead of setting the same on all of them
2014-05-01 16:18:37 +02:00
Thiago Santos
aea14053d1
hlsdemux: Always flush the internal proxy pads before downloading
...
hlsdemux can't rely on the source to push flushes on a seek on ready
as that might not make sense. So always resort to flushing the
internal proxy pads by pushing flush events from the source's src pad.
Also as the seeking is not required anymore, only seek if there is
really a byte range to be used. And store a ref to the source's
src pad to avoid doing get_static_pad for every fragment.
2014-05-01 16:18:16 +02:00
Matthew Waters
5681f78362
glcolorscale: fix operation with dual GL, GLES2 libgstgl
2014-05-01 14:11:00 +10:00
Vincent Penquerc'h
d8fb89e4e6
kate: avoid read buffer overflow in crafted stream
...
Coverity 1208777
2014-04-30 18:16:11 +01:00
Julien Isorce
56cca649d4
glcolorscale: use a shader on GLESv2
...
Otherwise you only see black frames
Fix https://bugzilla.gnome.org/show_bug.cgi?id=728947
2014-04-30 17:33:14 +01:00
Julien Isorce
a20f17e29c
glimagesink: use new helper function to avoid duplicating default shader text
2014-04-30 15:35:49 +01:00
Julien Isorce
f4626ef619
gleffects: use new helper functions to avoid duplicating the same vertex shader text
...
And also use the default fragment shader text for the identity effect
2014-04-30 15:35:49 +01:00
Sebastian Dröge
fc38c22f1b
hlsdemux: Only unref pending buffer if there is one
2014-04-30 10:14:12 +02:00
Thiago Santos
940576244c
hlsdemux: Do not push last buffer after error
...
In decryption scenario, a buffer is always stored to be sent later
to wait for more data or EOS to be able to strip the final bytes
if requested. In case an error hapenned this buffer can be ignored
and not pushed downstream.
2014-04-29 18:49:15 -03:00
Thiago Santos
bb8887baa7
hlsdemux: flush the adapter in the end of a fragment
...
In case of error there might be some data left in the
adapter when EOS is received. Clear the adapter to be
able to restart again later if requested.
2014-04-29 18:49:15 -03:00
Thiago Santos
4ab1d9f21f
hlsdemux: handle more error cases
...
Handle some more error cases:
1) When the source element fails to go to ready
2) When decryption fails
3) When there is no source to handle a specific URI
4) When the URI is invalid
2014-04-29 18:49:15 -03:00
Thiago Santos
4431388cab
hlsdemux: handle errors from internal source
...
Set up a message handling function to catch errors from the internal
source and store the last return code to identify error situations
when returning from a fragment download.
Also moves the duration increase to after the download when we
know if it was successful or not
2014-04-29 18:49:15 -03:00
Thiago Santos
f16560c520
hlsdemux: Improve pad switching conditions
...
When using the internal source, hlsdemux doesn't know the caps of
the input before adding the pad, so remove the arguments that would
use that as it is always NULL.
And use an specific flag to signal when a pad switch is required.
Using the discont flag is a bad idea now because when a fragment
download fails it will lead to exposing a pad group without any
data, causing decodebin to abort.
2014-04-29 18:49:15 -03:00
Thiago Santos
587851ba10
hlsdemux: properly flush decryption status on seeks
...
Avoids mixing decryption of different fragments when seeking happens
and leading to broken stream output.
2014-04-29 18:49:15 -03:00
Thiago Santos
ff395a7565
hlsdemux: Track fragments duration
...
When receving EOS from the internal src, increase the current positon
by the fragment duration to allow correct restoring of download position
if the bitrate changes
2014-04-29 18:49:15 -03:00
Thiago Santos
2b73e86881
hlsdemux: properly stop tasks by stopping fragment download
...
Issue a signal to the fragment download cond to stop
the task earlier
2014-04-29 18:49:15 -03:00
Thiago Santos
60eec1443a
hlsdemux: decrypt before typefinding
...
Make sure typefinding gets the decrypted content instead of
trying to typefind the encrypted data.
2014-04-29 18:49:15 -03:00
Thiago Santos
cc262b0923
hlsdemux: fix decryption function return
...
Correctly return the decrypted buffer when it succeeds and
return NULL otherwise
2014-04-29 18:49:15 -03:00
Thiago Santos
f6b0cae8b6
hlsdemux: keep connection alive between downloads
...
Use the same properties as uridownloader to keep connections alive
between consecutive fragments downloads.
1) set keep-alive property to true
2) keep the element in READY instead of in NULL
2014-04-29 18:17:07 -03:00
Thiago Santos
4b9d91d497
hlsdemux: create sources from uri
...
Instead of using always an http source, create it dynamically from
uri when needed. If not needed just replace the URI on the current
element
2014-04-29 18:17:07 -03:00
Thiago Santos
671f8c0e35
hlsdemux: do not try to run typefind again if caps is the same
...
Always reset the do_typefind flag if hls did typefind because
trying it on non-zero offsets doesn't make sense and will cause
assertions
2014-04-29 18:17:07 -03:00
Thiago Santos
cc033c7ca0
hlsdemux: enable download bitrate measure
...
Measure the download bitrate to be able to select
the best playlist.
As the buffers are directly pushed downstream and it
might block. The time is only measured from the download
until the pad push and it is started again after the push
returns.
2014-04-29 18:17:07 -03:00
Thiago Santos
c93c222786
hlsdemux: re-enable decryption after uridownloader removal
...
Now the decryption is done buffer by buffer instead of on the
whole fragment at once. As it expects multiples of 16 bytes a
GstAdapter was added to properly chunk the buffers.
Also the last buffer must be resized depending on the value of the
last byte of the fragment, so hlsdemux always keeps a pending buffer
as it doesn't know if it is the last one yet
2014-04-29 18:17:07 -03:00
Thiago Santos
3611759557
hlsdemux: replace uridownloader with a GstElement
...
The GstElement is directly linked into a ghost pad and
its buffers are pushed as received downstream. This way the
buffers are small enough and not a whole fragment that usually
causes extra latency and makes buffering harder
2014-04-29 18:17:07 -03:00
Stefan Sauer
6bb08d1267
sndfile: send a toc for the segments in the audio file
2014-04-29 18:20:30 +02:00
Julien Isorce
1525fa8bad
gl: use gst_gl_platform_from_string because we support gl shareList on all platforms
2014-04-28 15:59:06 +01:00
Sebastian Dröge
b47c92df82
hlsdemux: Set Referer in requests to the playlist URI
2014-04-28 10:04:28 +02:00
Tim-Philipp Müller
dbe6fdd6bf
docs: remove outdated and pointless 'Last reviewed' lines from docs
...
They are very confusing for people, and more often than not
also just not very accurate. Seeing 'last reviewed: 2005' in
your docs is not very confidence-inspiring. Let's just remove
those comments.
2014-04-27 00:36:32 +01:00
Sebastian Rasmussen
241c3acad5
curl*sink: report errors from curl when setting options
...
https://bugzilla.gnome.org/show_bug.cgi?id=728960
2014-04-26 10:24:24 +02:00
Sebastian Rasmussen
c75c7a9a53
curl*sink: post error on bus in element, not transfer thread
...
https://bugzilla.gnome.org/show_bug.cgi?id=728960
2014-04-26 10:23:24 +02:00
Sebastian Rasmussen
13f87a1db1
curlhttpsink: allow for unconditionally disabling proxying
...
Previously if the proxy server hostname was the empty string
curlhttpsink would never even set the libcurl option. For libcurl
however, having a proxy server hostname be the empty string means that
proxying should be disabled even if environment variables might be set.
Now with the restriction lifted, doing this is allowed.
https://bugzilla.gnome.org/show_bug.cgi?id=728960
2014-04-26 10:21:56 +02:00
Sebastian Rasmussen
da987a3219
curl*sink: fix typos
...
https://bugzilla.gnome.org/show_bug.cgi?id=728960
2014-04-26 10:20:33 +02:00
Sebastian Rasmussen
bdd2676a67
curl*sink: fix some gst-indent problems
...
https://bugzilla.gnome.org/show_bug.cgi?id=728960
2014-04-26 10:20:11 +02:00
Julien Isorce
3db1e3e1ed
gl: fails glimagesink when shader compilation went wrong
...
Those shaders are fixed and very simple so it should not fail
but it's worth to handle a such case.
2014-04-24 16:57:01 +01:00
Julien Isorce
673b813ab3
gl: call glClearColor before glClear
2014-04-24 16:57:01 +01:00
Sebastian Dröge
e50f264411
glimagesink: Use the pixel-aspect-ratio adjusted width/height when centering the frame in the display area
...
Makes sure we actually keep the display aspect ratio
2014-04-23 11:10:28 +02:00
Sebastian Dröge
ebab5b0a43
glimagesink: By default keep the display aspect ratio
...
Also the default for the pixel-aspect-ratio should be 1/1, not 0/1.
2014-04-23 10:58:12 +02:00
Sebastian Dröge
0662248347
gltestsrc: Unref context when creation failed and guard against that in fill()
2014-04-23 10:27:23 +02:00
Sebastian Dröge
89d2bb75d6
glimagesink: Call gst_object_unref() on the GstGL GObjects again
...
While they're plain GObjects it does not hurt to call gst_object_unref()
on them and potentially allows to debug reference leaks a bit easier.
2014-04-23 10:24:55 +02:00
Sebastian Dröge
38ebfb2da8
glimagesink: If creating a context or upload failed, destroy it
...
Fixes deadlocks in error cases when later code assumes the broken
context is actually usable.
https://bugzilla.gnome.org/show_bug.cgi?id=728761
2014-04-23 10:00:48 +02:00
Vincent Penquerc'h
467d9267a2
gl: a couple spelling/grammar fixes
2014-04-21 13:23:46 +01:00
Vincent Penquerc'h
7a3e141204
gl: guard against using a NULL window pointer
...
Coverity 1195145
2014-04-21 13:23:46 +01:00
Julien Isorce
09116bf10d
egl/eglglessink: remove since EGLImage and iOS support have been added in glimagesink
...
https://bugzilla.gnome.org/show_bug.cgi?id=703343
2014-04-15 18:29:53 +01:00
Edward Hervey
6a2e39eefa
wayland: Remove dead assignment
...
We set it just after variable declaration
CID #1197709
2014-04-14 07:56:16 +02:00
Matthew Waters
364b01aca9
glimagesink: remove unused texture
2014-04-13 22:16:45 +10:00
Matthew Waters
d4a72b61c0
glimagesink: move upload into _prepare()
2014-04-13 22:14:52 +10:00
Sebastian Dröge
e9dbcb69cd
gl: Set glimagesink rank to SECONDARY
...
This is a full-featured video sink now and especially should be
used instead of osxvideosink on OSX if available.
2014-04-12 22:25:14 +02:00
Sebastian Dröge
0bd53c9ccb
glimagesink: First handle GL window setup, then create the context and its thread
2014-04-12 17:01:09 +02:00
Aleix Conchillo Flaqué
01c15547d4
srtpdec: fix assertion checking ssrc from rtcp packets
...
rtcp_buffer_get_ssrc is called even with RTP buffers. this means we
might end up with an exception and not find any valid RTCP packet type
and thus hit GST_RTCP_TYPE_INVALID. we now take care of this.
https://bugzilla.gnome.org/show_bug.cgi?id=727512
2014-04-12 05:08:20 +02:00
Matthew Waters
15d0c04933
gl/mem: allocate the memory per plane
...
This patch provides the basic infrastructure required for this.
Upload and Download has been ported to this.
Has the nice effect of allowing GstGLMemory to be our
refcounted texture object for any texture type (not just RGBA).
Should not lose any features/video formats.
2014-04-11 10:37:06 +10:00
Matthew Waters
95abfda139
gl: add colorconvert object that converts between color spaces/formats
...
Currently used by both upload and download objects separately.
2014-04-11 10:37:05 +10:00
Vincent Penquerc'h
aa2b8f179e
faac: fix faac API error checking
...
Coverity 1139790
2014-04-10 17:55:21 +01:00
Vincent Penquerc'h
2e940ba253
dashdemux: do not ignore failure to register typefinder
...
Coverity 1139629
2014-04-10 17:52:02 +01:00
Vincent Penquerc'h
2dd898793e
dashdemux: fix time leak
...
Coverity 1147016
2014-04-10 17:48:03 +01:00
Vincent Penquerc'h
59654c68ee
dashdemux: remove dead code and variable
...
A recent commit made stream not able to be NULL, ending up with
a flag being always set to FALSE when it matters.
Coverity 1146968, 1147012
2014-04-10 17:46:32 +01:00
Vincent Penquerc'h
bbda6a1ab9
curl: remove unneeded NULL check
...
We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.
Coverity 1139841
2014-04-10 17:37:22 +01:00
Vincent Penquerc'h
feede7ddfa
curl: remove duplicate assignment
...
Coverity 1197708
2014-04-10 17:33:55 +01:00
Sebastian Dröge
f82d9ec4a9
hlsdemux: Also update the sequence position when updating non-live playlists
2014-04-10 16:53:42 +02:00
Sebastian Dröge
a06d4ea408
hlsdemux: Try reloading the playlist first if downloading a fragment fails
...
But only add this for non-live playlists. For live playlists we already
have another thread that is periodically updating playlists.
Reason for this is that sometimes downloading a fragment can fail because
the URIs have changed or expired since last time.
2014-04-10 15:06:53 +02:00
Sebastian Dröge
864399f299
hlsdemux: When updating a non-live playlist make sure to find the current sequence by time
...
Sequence numbers in different playlists are not guaranteed to be the same for the
same position, e.g. fragments could have different durations in different playlists.
In theory we should do exactly the same for live playlists, but unfortunately we can't
because doing this kind of seeking requires the complete playlist since we started
playback. For live playlists the server is however dropping fragments in the beginning
over time and we have no absolute time references.
2014-04-10 15:06:53 +02:00
Vincent Penquerc'h
14f8172d2b
smoothstreaming: avoid using an uninitialized manifest
...
If we did not set the manifest yet, early out in the seeking query.
Coverity 1139737
2014-04-10 09:51:07 +01:00
Vincent Penquerc'h
b3a18a2fcc
hlssink: catch failure to write playlist file
...
Coverity 1139613
2014-04-09 18:44:38 +01:00
Vincent Penquerc'h
e308986807
kate: fix implicit promotion to signed int breaking on largeish inputs
...
Coverity 1139858, 1139857
2014-04-09 18:31:31 +01:00
Vincent Penquerc'h
14dc7839cf
ladspa: remove duplicate assignment
...
Coverity 1139706
2014-04-09 18:16:52 +01:00
Vincent Penquerc'h
0e3c1f6e3a
mimdec: fix open error checking
...
Coverity 206364
2014-04-09 18:12:58 +01:00
Vincent Penquerc'h
956be9a018
schrodec: remove unnecessary check
...
The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.
Coverity 1139850
2014-04-09 17:53:57 +01:00
Vincent Penquerc'h
88879654df
smoothstreaming: remove unnecessary check
...
The function is static, the only call site passes a non NULL
pointer, and the pointer is dereferenced before anyway.
Coverity 1139839
2014-04-09 17:10:06 +01:00
Vincent Penquerc'h
54704b6f5d
srtp: remove dead assignment
...
Coverity 1197707
2014-04-09 16:55:30 +01:00
Vincent Penquerc'h
612cdeec80
resindvd: avoid crashing in pathological case
...
When we'd see an unknown stream type, then a SDDS stream.
Then we'd get to the end of the switch with a NULL temp stream
pointer, and dereference it.
Coverity 1139708
2014-04-09 14:37:48 +01:00
Vincent Penquerc'h
25d4ca70c9
opus: add missing va_end in variadic function
...
Coverity 1139944
2014-04-09 11:03:17 +01:00
Vincent Penquerc'h
084c4d5dc4
mpeg2enc: remove dead assignment
...
Coverity 1139829
2014-04-09 10:33:10 +01:00
Vincent Penquerc'h
9eab659d1d
gl: pass large structure by const pointer, not value
...
Avoids large pointless memcpy.
Coverity 206236, 206237
2014-04-09 10:31:19 +01:00
Vincent Penquerc'h
fd6a4f7372
flite: fix off by one in channel mask building
...
The first loop would shift 1 by 64, which is either undefined
or implementation defined, instead of clearing the top bit.
Coverity 1197691
2014-04-08 17:35:37 +01:00
Vincent Penquerc'h
a78e516cbf
hls: restore NULL test mistakenly removed
...
Thanks to tpm for point out I'm an idiot.
2014-04-08 17:10:27 +01:00
Vincent Penquerc'h
c319b1cc8f
hls: only set DISCONT flag on a valid buffer
...
Recent refactoring causes this code to be called with either a NULL
fragment, or a non NULL fragment. In the former case, we don't have
a buffer. In the latter case, the original code dealing with DISCONT
assumed the buffer was valid. Testing for a NULL buffer here thus
does not seem to change the intent, and fixes:
Coverity 1195147
2014-04-08 16:56:04 +01:00
Vincent Penquerc'h
45b8225a02
hls: bring NULL test before dereference
...
Coverity 1195168
2014-04-08 16:46:56 +01:00
Vincent Penquerc'h
4b5068f5dd
gl: test for frame NULLness before dereferencing it
...
Coverity 1195172, 1195171
2014-04-08 16:25:51 +01:00
Vincent Penquerc'h
db7934233f
resindvd: guard against overflow in audio subtitle streams
...
Turns out there was the same issue as with subtitles.
There is space for a single audio stream, but up to 255
may be used based on a uint8_t value in a struct, which may
or may not be read from the (untrusted) data.
A comment in ifo_types.h says this value is either 0 or 1, so
we can ensure this here without drawbacks.
Coverity 1139585
2014-04-08 14:24:31 +01:00
Vincent Penquerc'h
380f95ea01
resindvd: guard against overflow in menu subtitle streams
...
There is space for a single subtitle stream, but up to 255
may be used based on a uint8_t value in a struct, which may
or may not be read from the (untrusted) data.
A comment in ifo_types.h says this value is either 0 or 1, so
we can ensure this here without drawbacks.
Coverity 1139586
2014-04-08 14:21:53 +01:00
Vincent Penquerc'h
57a138df86
dtsdec: fix buffer overflows
...
Channels can be up to 7. Also add a guard in case more can be
returned in the future.
Coverity 1139820, 1139821
2014-04-08 12:41:16 +01:00
Edward Hervey
eb0a307e28
soundtouch: Add missing break in switch
...
Whoops, modifying the pitch when modifying the output rate ...
CID #1139749
2014-04-08 11:23:50 +02:00
Edward Hervey
2e808ca1e9
rsvg: Add missing break in switch statement
...
This wasn't fatal before (worst case it would clear an already empty
adapter).
CID #1139758
2014-04-08 11:21:44 +02:00
Edward Hervey
8ca5387b0f
mpeg2enc: Add missing break in switch
...
QUERY_CAPS is fully handled, we don't need to passthrough to the default
handler.
CID #1139756
2014-04-08 11:20:29 +02:00
Edward Hervey
334bcd433b
bz2: Initialize variables
...
There is a small chance that we might end up in the done step without
having any output available.
Furthermore, when going through not_ready, we need to ensure gst_buffer_unmap
has a properly initialized GstMapInfo.
CID #1139923
CID #1139924
CID #1139919
CID #1139920
2014-04-08 09:55:15 +02:00
Sebastian Dröge
82b7c915bb
glimagesink: Create GL context and set up window from the streaming thread
...
gst_gl_context_create() might need to dispatch some operations to the
application's main thread, and calling this in the change_state function
can cause deadlocks.
2014-04-07 11:21:07 +02:00
Wim Taymans
ff5d1a18f3
wildmidi: fix possible uninitialized variables
2014-04-03 11:54:41 +02:00
Wim Taymans
6c014f7e36
mpdparse: only add location when node existed
...
Actually return FALSE when the location node was non-existing
Only add the location node when it existed
2014-04-03 11:48:07 +02:00
Matthew Waters
e01e2cce9f
gl: pass video info's by reference
2014-04-02 23:05:47 +11:00
Matthew Waters
98c486025a
gl: fix array initialization
2014-04-02 23:05:11 +11:00
Matthew Waters
cb8f90e4c3
glbumper: remove redundant check
2014-04-02 22:54:55 +11:00
Matthew Waters
5b0da41038
gl: fix assignment of temporary variables
2014-04-02 22:43:41 +11:00
Matthew Waters
e58cd96b96
gl: avoid adding a NULL pool to propose allocation
2014-04-02 22:42:50 +11:00
Matthieu Bouron
820685409e
dashdemux: use correct print format for gint64
...
https://bugzilla.gnome.org/show_bug.cgi?id=727385
2014-03-31 14:50:17 +02:00
Sebastian Dröge
b86e502a8b
hlsdemux: Handle errors when switching playlists properly
2014-03-30 19:22:25 +02:00
Sebastian Dröge
89ca4535eb
hlsdemux: Go EOS if the end of the segment is reached
2014-03-30 19:22:25 +02:00
Sebastian Dröge
911023eb88
hlsdemux: Store buffer end position in segment.position
2014-03-30 19:22:24 +02:00
Sebastian Dröge
f701755b83
hlsdemux: Don't set the segment offset
...
It's causing wrong running times after seeks or bitrate
switches.
2014-03-29 10:33:45 +01:00
Sebastian Dröge
e11a99e26a
hlsdemux: Set DISCONT flag on all buffers in reverse playback mode
2014-03-29 10:33:45 +01:00
Sebastian Dröge
8109ed8785
hlsdemux: Fix forwards and backwards searching in the files list
2014-03-29 10:33:45 +01:00
Sebastian Dröge
6039734f3e
hlsdemux: Unset DTS of all buffers
...
We won't get a valid DTS from the source.
2014-03-29 10:33:45 +01:00
Sebastian Dröge
cad284e843
hlsdemux: Send flush start event before waiting for the tasks to finish
...
Otherwise we'll wait until buffers are completely processed downstream,
which might take quite some time.
2014-03-29 10:33:45 +01:00
Sebastian Dröge
91ec00a0c0
hlsdemux: Implement trick modes via I-frame variant lists
2014-03-29 10:33:45 +01:00
Sebastian Dröge
77231ab957
hlsdemux: Implement parsing of #EXT-X-I-FRAME-STREAM-INF
...
These are I-frame-only variant lists that can be used
for trick mode playback.
2014-03-29 10:33:45 +01:00
Rico Tzschichholz
d10fcf4d3f
build: Fix make dist
2014-03-28 20:02:40 +00:00
Julien Isorce
7dd3b2fff7
eglglessink: unref last buffer on DRAIN
...
Similar to 093574053f
in gstbasesink
https://bugzilla.gnome.org/show_bug.cgi?id=726107
2014-03-28 11:54:45 +00:00
Reynaldo H. Verdejo Pinochet
2008ec409b
eglglessink: fix wrong doc block for create_window
...
Wrong since 1ad253b9
when prop name was changed from
can_create_window to create_window.
2014-03-27 18:54:27 -03:00
Julien Isorce
75c92dc915
gl: only set CAPS_FEATURE_MEMORY_EGL_IMAGE on egl platform
2014-03-27 07:07:01 +00:00
Julien Isorce
218244a040
gl: let the user includes itself our egl headers if needed
...
Forgot to address this change.
https://bugzilla.gnome.org/show_bug.cgi?id=703343
2014-03-26 19:17:03 +00:00
Julien Isorce
0ae3c984aa
gl: add EGLImage support
...
* picked from old libgstegl:
- GstEGLImageMemory
- GstEGLImageAllocator
- last_buffer management from removed GstEGLImageBufferPool
* add-ons:
- GstEGLImageMemory now old a reference on GstGLContext
so that it can delete the EGLImage and its gltexture source
while having the associated gl context being current.
- add EGLImage support for GstVideoGLTextureUploadMeta which
mainly call EGLImageTargetTexture2D
- GstGLBufferPool now supports GstEGLImageAllocator
- glimagesink / glfilters / etc.. now propose GstEGLImageAllocator
to upstream
https://bugzilla.gnome.org/show_bug.cgi?id=703343
2014-03-26 19:09:13 +00:00
Jan Schmidt
6b784cf808
rtmpsink: Remove URL check for valid playpath.
...
The playpath is an optional component of the URL - don't require it.
2014-03-26 09:05:55 +11:00
Wim Taymans
9adb1734cf
srtpenc: unlock object lock before posting error
...
Posting an error with the object lock will deadlock. Rework the code
a bit to make things more simple.
2014-03-25 17:46:32 +01:00
Gwenole Beauchesne
21b897de2f
gl: fix out-of-source builds.
...
Always use the locally generated <gst/gl/gstglconfig.h> file.
Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
2014-03-24 17:56:13 +01:00
Matthew Waters
faa94a8737
gl: silence a critical if upstream does not provide us with meta params
2014-03-20 07:01:01 +11:00
Julien Isorce
fa4ce072ee
gl: silence warnings building for RPI related to 'vcos_*'
...
Similar than 1190a79b19
2014-03-19 14:43:13 +00:00
Julien Isorce
e870244e39
gl: keep only one occurence of '#include <EGL/egl.h>'
...
To simply maintainance if we need to put specific includes around it.
2014-03-19 14:43:13 +00:00
Thijs Vermeir
1a5560441d
make: whitespace cleanups
2014-03-17 12:00:09 +01:00
Matthew Waters
6b3fe44185
Move gst-plugins-gl to bad
2014-03-16 15:17:59 +01:00
Matthew Waters
870503dc6b
gl: silence all the compiler warnings
2014-03-16 15:17:44 +01:00
Matthew Waters
4bdf5f336a
move gl elements to ext subdirectory
2014-03-16 11:23:16 +01:00
Matthew Waters
b90d824626
[838/906] gl: Use GL_TEXTURE_2D instead of GL_TEXTURE_RECTANGLE
...
We create our textures (in Desktop GL) with GL_TEXTURE_RECTANGLE,
vaapi attempts to bind our texture to GL_TEXTURE_2D which throws a
GL_INVALID_OPERATION error and as thus, no video.
Also, by moving exclusively to GL_TEXTURE_2D and the npot extension
we also remove a difference between the Desktop GL and GLES2 code.
https://bugzilla.gnome.org/show_bug.cgi?id=712287
2014-03-15 18:37:03 +01:00
Matthew Waters
a5b877fb13
[717/906] remove outdated cmake build files
2014-03-15 18:36:56 +01:00
Matthew Waters
13067b104c
[704/906] Use gst_object_[un]ref so we can get refcounts in the log
2014-03-15 18:36:56 +01:00