mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-18 21:35:44 +00:00
Code Issues 1 Projects Releases Wiki Activity

schrodec: remove unnecessary check

Browse source 
The tag was dereferenced earier. From the libschroedinger code,
it's not obvious to see whether tag and frame would be NULL at
the same time. I think is likely that both will be non NULL
here, but that's not certain. Additional tests may be needed
to avoid dereferencing tag and/or frame, but what to do if
only one is NULL isn't obvious, as the _get_tag function does
transfer ownership so isn't undoable.

Coverity 1139850
This commit is contained in:
Vincent Penquerc'h 2014-04-09 17:37:41 +01:00
parent 88879654df
commit 956be9a018
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ext/schroedinger/gstschrodec.c
View file

@ -498,8 +498,7 @@ gst_schro_dec_process (GstSchroDec * schro_dec, gboolean eos)
schro_frame_unref (schro_frame);
}
if (tag)
schro_tag_free (tag);
schro_tag_free (tag);
if (!eos) {
go = FALSE;
}