curl: remove unneeded NULL check

We just checked for NULL and allocated if it was. And glib aborts
if it can't allocate, I'm told.

Coverity 1139841
This commit is contained in:
Vincent Penquerc'h 2014-04-10 17:37:22 +01:00
parent feede7ddfa
commit bbda6a1ab9

View file

@ -564,12 +564,10 @@ gst_curl_smtp_sink_set_payload_headers_unlocked (GstCurlBaseSink * bcsink)
sink->base64_chunk->save = 0;
if (G_UNLIKELY (!append_headers)) {
if (sink->base64_chunk != NULL) {
g_byte_array_free (sink->base64_chunk->chunk_array, TRUE);
sink->base64_chunk->chunk_array = NULL;
g_free (sink->base64_chunk);
sink->base64_chunk = NULL;
}
g_byte_array_free (sink->base64_chunk->chunk_array, TRUE);
sink->base64_chunk->chunk_array = NULL;
g_free (sink->base64_chunk);
sink->base64_chunk = NULL;
return FALSE;
}