Commit graph

1525 commits

Author SHA1 Message Date
Mouse Reeve
dfecdca6f9 Fixes display of ratings 2021-03-07 07:56:33 -08:00
Mouse Reeve
b895059f03 Uses same alt text generation for books with no cover 2021-03-07 07:42:02 -08:00
Mouse Reeve
e5bdb4b9d1 Make empty cover value null 2021-03-07 07:35:50 -08:00
Mouse Reeve
9c94be8804 Fixes typo in subject places block 2021-03-07 07:35:38 -08:00
Mouse Reeve
4eefe33d9b
Merge pull request #701 from Flameborn/ScreenReaderImprovements
Screen reader improvements
2021-03-07 07:13:47 -08:00
Mouse Reeve
9082eefd8f Sets specific proportions for book page columns 2021-03-07 07:08:19 -08:00
erion
ae8d39995d Hide avatar image to screen readers on the status pages, since there is a link present for a user already. 2021-03-07 14:39:18 +01:00
erion
cb8ec01ccf Indicate which page is the current. 2021-03-07 13:55:50 +01:00
erion
09c5275ec4 Fix typo. 2021-03-07 13:18:10 +01:00
Mouse Reeve
e4fa85c2fb
Merge pull request #699 from mouse-reeve/display-name-title
Fixes display name showing up on user page
2021-03-06 13:34:42 -08:00
Mouse Reeve
13531f107d
Merge pull request #697 from mmai/feature/isbnSearch
ISBN search
2021-03-06 13:32:31 -08:00
Mouse Reeve
9ed18a2b1d Fixes display name showing up on user page 2021-03-06 13:11:44 -08:00
Mouse Reeve
5c9a3a5667
Merge pull request #696 from arkhi/fix-js
Fix toggling all checkboxes of failed imports
2021-03-06 13:05:07 -08:00
Fabien Basmaison
a52fee4ccf Remove (potentially useful) unused CSS. 2021-03-06 21:18:39 +01:00
Henri Bourcereau
703ff60271 isbn search 2021-03-06 18:09:15 +01:00
Fabien Basmaison
99e5e3e414 [import] Show skip link to all when there is more than 10 failed imports. 2021-03-05 22:09:56 +01:00
Mouse Reeve
91a14d3a13 Updates alt text in status model tests 2021-03-05 07:50:23 -08:00
Mouse Reeve
b70e728ffb Removes the word "cover" from cover alt text
Fixes #694
2021-03-05 06:58:22 -08:00
Fabien Basmaison
097b8e5811 Fix toggling all checkboxes of failed imports:
- Rename classes and function to something more descriptive.
- Listen to the element checked status instead of a click on a non‑focusable element.
- Use specific DOM targets instead of relying on the DOM ancestor tree.
- Add a skip‑link to the end of the list and avoid tabbing through all failed items.
- Update related i18n strings in French.
- Avoid having the label on the whole width to prevent accidental click.
- Move `fieldset` out of `ul`.
2021-03-05 15:41:21 +01:00
Mouse Reeve
5c089db086 Full add author flow 2021-03-04 17:10:33 -08:00
Mouse Reeve
b2d1384bc5 UI for adding and removing authors 2021-03-04 15:10:55 -08:00
Mouse Reeve
e2622d0594 Catches a couple translations, hides profile box when empty 2021-03-04 14:27:49 -08:00
Mouse Reeve
577f5db37b
Merge pull request #680 from arkhi/main
[profile] Fix HTML errors
2021-03-04 14:01:22 -08:00
Mouse Reeve
74ab3505fe
Merge pull request #686 from mouse-reeve/french-fuzzy
Removes "fuzzy" flag from translated French strings
2021-03-04 11:47:53 -08:00
Fabien Basmaison
dab6592c12 Testing moving a comment to see what accesslint says. 2021-03-04 20:38:28 +01:00
Fabien Basmaison
16ea657b5b [a11y] Add aria-modal:
- Addresses https://github.com/mouse-reeve/bookwyrm/pull/680#issuecomment-790603940
2021-03-04 20:14:38 +01:00
Mouse Reeve
7b2a8e90ff
Merge pull request #670 from mouse-reeve/editor-default
Give new users editor permissions by default
2021-03-04 09:19:21 -08:00
Mouse Reeve
2542b72f3a Try to get github to re-run checks 2021-03-04 08:51:10 -08:00
Mouse Reeve
6caf45ac4f fixes error catching 2021-03-04 08:45:03 -08:00
Mouse Reeve
9842e63cb4 Ignore group not found error creating user 2021-03-04 08:35:13 -08:00
Mouse Reeve
4c71c5fb73 Removes "fuzzy" flag from translated French strings 2021-03-04 08:04:55 -08:00
Mouse Reeve
4a06cc7a66 Revert "Un-fuzzies French translation strings"
This reverts commit a5d2cf4677.
2021-03-04 08:04:00 -08:00
Mouse Reeve
a5d2cf4677 Un-fuzzies French translation strings 2021-03-04 08:02:57 -08:00
Mouse Reeve
208a38a34d Adds spanish locale to settings and rebuilds messages 2021-03-03 20:14:42 -08:00
Mouse Reeve
e5662b1752
Merge pull request #682 from reesporte/main
Spanish translation and one (1) typo fix
2021-03-03 20:10:52 -08:00
reese
5fe8b67ba7 fix typo :) 2021-03-03 20:08:42 -06:00
Fabien Basmaison
8c26d8a514 [profile] Updates for PR:
- Fix duplicated IDs between modals for the same status.
- Remove redundant button (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586743844).
- Remove redundant `role="navigation"` on `<nav>`.
- Add `dir="auto"` back for titles (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586715693).
- Use `exists` instead of `all` for conditional statement (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586716299).
- Fix missing spacing between avatar and username (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586740902).
2021-03-03 22:58:01 +01:00
Fabien Basmaison
a05b14c338 [profile] Various HTML fixes:
- Wrap block level elements within block level elements, not inline.
- Avoid empty blocks.
- Change `<hr>` in lists into allowed type of children.
- Fix duplicated ID (some change that was not propagated across the template?).
- Make the anchor optional in the navbar (interactive elements (`a`, `input`, `button`…) should not appear into other interactive elements).
- Remove redundant `role` on main navigation.
- Make the modal a modal with `role="dialog".
- Use `button` instead of form-less `label`.
2021-03-03 20:10:09 +01:00
Mouse Reeve
327f14a150 Merge branch 'main' into create-book 2021-03-03 08:55:40 -08:00
Fabien Basmaison
0d8eb959ea [profile] Use unique IDs on statuses. 2021-03-03 15:48:04 +01:00
Mouse Reeve
51cf580813 Revert "Fixes boost notification"
This reverts commit 3ee12345ec.
2021-03-02 20:24:51 -08:00
Mouse Reeve
3ee12345ec Fixes boost notification 2021-03-02 20:19:50 -08:00
Mouse Reeve
be3c7ac90e Fixes boost display 2021-03-02 20:17:32 -08:00
Mouse Reeve
caed268227 Adds german language to settings 2021-03-02 13:36:30 -08:00
Mouse Reeve
549d8768a6 Combine a couple very similar translation strings
plus a whitespace fix
2021-03-02 10:46:08 -08:00
Mouse Reeve
2c37893790 Adds default shelf names translations 2021-03-02 10:32:46 -08:00
Mouse Reeve
27914d07b9 Missing translation strings on book and list pages 2021-03-02 10:23:11 -08:00
Mouse Reeve
5938c438e2 Translate table titles in header 2021-03-02 09:59:15 -08:00
Mouse Reeve
8bb7d5bba0 Translates invite form values 2021-03-02 09:55:28 -08:00
Mouse Reeve
bb6a82fdff Adds simplified chinese language code to settings 2021-03-02 09:26:21 -08:00
Mouse Reeve
01df4ad321 Small fixes for translation 2021-03-02 09:25:45 -08:00
Mouse Reeve
2faf5cea2a modifies edit book code to allow creation as well 2021-03-02 09:01:31 -08:00
Mouse Reeve
99288e9183 Merge branch 'main' into edit-book-fields 2021-03-01 11:53:02 -08:00
Mouse Reeve
2c2d7c4694
Merge pull request #669 from mouse-reeve/edit-book-field
Track last edited by on partial edits
2021-03-01 11:43:17 -08:00
Mouse Reeve
d16e4dc808 Enumerates notification options for translation 2021-03-01 09:32:03 -08:00
Mouse Reeve
b9bf65ad2a Adds missing i18n imports 2021-02-28 17:52:48 -08:00
Mouse Reeve
bd44bf0980 Merge branch 'main' into i18n-second-pass 2021-02-28 17:22:25 -08:00
Mouse Reeve
6a18803417 Catches more template translation moments 2021-02-28 17:10:30 -08:00
Mouse Reeve
b2779cc6bf
Merge pull request #664 from mouse-reeve/login-csrf
Fixes csrf failure logging on from multiple tabs
2021-02-28 16:16:00 -08:00
Mouse Reeve
10130f01d4
Merge pull request #662 from mouse-reeve/titles
Puts titles in templates instead of views
2021-02-28 16:15:39 -08:00
Mouse Reeve
54687b7b35 Make users editors by default 2021-02-28 13:45:49 -08:00
Mouse Reeve
3ecdc8f93e Track last edited by on partial edits 2021-02-28 13:40:57 -08:00
Mouse Reeve
5e0a1749f3 Fixes csrf failure logging on from multiple tabs 2021-02-28 11:47:30 -08:00
Mouse Reeve
310d4a1f59
Merge pull request #653 from greatislander/tab-keyboard-accessibility
feature: keyboard accessibility for tabbed UIs (fixes #526)
2021-02-28 11:11:54 -08:00
Mouse Reeve
72c50b3f58 Fixes typo in admn layout page 2021-02-28 10:45:21 -08:00
Mouse Reeve
0cf2baccac Adds merge migration 2021-02-28 10:40:10 -08:00
Mouse Reeve
5bc4456d4e Merge branch 'main' into review-rate 2021-02-28 10:35:20 -08:00
Mouse Reeve
3e9ee0973b cleans up i18n titles 2021-02-28 10:09:56 -08:00
Ned Zimmerman
263b13f157 Adapt tab handler to vanilla JS, fix focus jump, improve accessible naming of tabs/panels 2021-02-28 14:04:04 -04:00
Mouse Reeve
c483768544 Moves titles into templates and adds i18n support 2021-02-28 10:00:36 -08:00
Mouse Reeve
c4116c93b7 Merge branch 'main' into titles 2021-02-28 09:02:21 -08:00
Mouse Reeve
4df62a8ebd Simplifies translation strings 2021-02-28 08:42:25 -08:00
Ned Zimmerman
b324e668ca Merge branch 'upstream' into tab-keyboard-accessibility 2021-02-28 12:39:56 -04:00
Mouse Reeve
d3676ff984 Removes non-existant german language support 2021-02-28 08:13:49 -08:00
Mouse Reeve
4f76d21b85 Snags more strings for i18n 2021-02-27 18:48:10 -08:00
Mouse Reeve
27316678d5 Adds test german translations
with apologies to actual german speakers
2021-02-27 16:44:58 -08:00
Mouse Reeve
2d79a52133 Translations working in templates 2021-02-27 16:18:56 -08:00
Mouse Reeve
b2e431daed Adds test localization file 2021-02-27 15:00:19 -08:00
Mouse Reeve
8e5e3a84d6 Quick first pass at tagging strings for localization 2021-02-27 14:22:39 -08:00
Mouse Reeve
791968ece5 updating language file defaults 2021-02-27 13:51:03 -08:00
Mouse Reeve
ad2a87d317 First pass at internationalization and localization 2021-02-27 13:43:55 -08:00
Mouse Reeve
04ed5d62dd
Merge pull request #649 from mmai/feature/importLibrarything
librarything import
2021-02-27 12:17:41 -08:00
Mouse Reeve
7622bef35d Adds separate privacy policy section 2021-02-27 11:53:36 -08:00
Mouse Reeve
9ed5226b58 Switches layout to use in-template html header titles 2021-02-27 11:07:16 -08:00
Ned Zimmerman
bc7f830b2b Merge branch 'upstream' into tab-keyboard-accessibility 2021-02-27 11:53:27 -04:00
Ned Zimmerman
9580bec154 feat: modify tabbed interfaces to support keyboard accessibility (fixes #526) 2021-02-27 11:47:03 -04:00
Joel Bradshaw
717cbe3034 Use very fancy SQL nonsense
This should be more efficient than running the queries one by one
2021-02-26 23:12:39 -08:00
Joel Bradshaw
ee7388052c Use SQL parameters, and make unconvert work
DBAs don't want you to know about this One Simple Trick
2021-02-26 22:57:26 -08:00
Henri Bourcereau
bfedb300ca librarything import : fix parsing & select box 2021-02-26 13:32:17 +01:00
Mouse Reeve
3ba6479e79 hide linter error on override funtion 2021-02-25 15:16:16 -08:00
Mouse Reeve
4a10c99026 Fixes handling of ratings in status views and urls 2021-02-25 15:05:51 -08:00
Mouse Reeve
2e36cfbcf6 Creates new semi-functional migration 2021-02-25 14:58:09 -08:00
Mouse Reeve
ffd57dfef4 Use modern string formatting syntax in status model 2021-02-25 10:34:28 -08:00
Mouse Reeve
ed7c13531f Merge branch 'main' into review-rate 2021-02-25 10:17:52 -08:00
Mouse Reeve
6d7e063b81 Makes rating field mandatory on ratings 2021-02-25 10:17:24 -08:00
Mouse Reeve
0ecfff0f16
Merge pull request #625 from mouse-reeve/inbox-refactor
Inbox refactor
2021-02-24 13:34:59 -08:00
Mouse Reeve
bb7c41ee5f Tweaks where serialize is called 2021-02-24 13:13:29 -08:00
Mouse Reeve
bb5838782d
Merge pull request #650 from mouse-reeve/privacy-display
Privacy display
2021-02-24 12:54:00 -08:00
Mouse Reeve
c7d8548614 Select subclasses in rss feed 2021-02-24 12:35:43 -08:00
Mouse Reeve
a5ee535ab6 fixes book reviews queryset aggregators 2021-02-24 12:29:50 -08:00
Mouse Reeve
779581c6f4 Only show dms in dm page 2021-02-24 12:06:00 -08:00
Mouse Reeve
2a5d4b83d8 Show dms in the right places 2021-02-24 11:59:21 -08:00
Mouse Reeve
bcdf2ee142 Improves privacy-related display 2021-02-24 11:35:19 -08:00
Henri Bourcereau
b85fed3595 librarything import 2021-02-24 20:20:14 +01:00
Mouse Reeve
94e95dc39d Adds test for delete activity 2021-02-24 10:07:03 -08:00
Mouse Reeve
cad19ee878 Merge branch 'main' into inbox-refactor 2021-02-24 09:51:34 -08:00
Mouse Reeve
9465455af2 Catch ssl errors in broadcast 2021-02-24 08:27:16 -08:00
Mouse Reeve
6426282db1 fixes goal page and test for goal page 2021-02-23 22:07:13 -08:00
Mouse Reeve
fcc0e0ccb6 Cleans up formatting on about page 2021-02-23 19:58:04 -08:00
Mouse Reeve
b4d9cdbe98
Merge pull request #643 from mouse-reeve/pressed-button-color
Makes comment and fav/boost buttons the same color when selected
2021-02-23 17:35:13 -08:00
Mouse Reeve
744de313c8 Makes comment and fav/boost buttons the same color when selected 2021-02-23 17:23:11 -08:00
Mouse Reeve
fba53c72e0 default safe mode for activity serialization 2021-02-23 17:19:47 -08:00
Mouse Reeve
4d0e52bf51 Test tag and list add 2021-02-23 17:18:25 -08:00
Mouse Reeve
0d68d22f73
Merge pull request #642 from mouse-reeve/invite-pagination
Invite pagination
2021-02-23 17:03:38 -08:00
Mouse Reeve
6e6bcb2f48 gotta simplify the add activity 2021-02-23 15:51:02 -08:00
Mouse Reeve
23fb5f62a2 Keep invite settings in form after save 2021-02-23 15:25:26 -08:00
Mouse Reeve
384187a263 Moves create invite form to top of invite page 2021-02-23 15:21:37 -08:00
Mouse Reeve
e042805f38
Merge pull request #632 from mouse-reeve/remote-server-set
Safer set remote server
2021-02-23 15:13:32 -08:00
Mouse Reeve
baed291889 Don't broadcast after saving remote server 2021-02-23 14:45:39 -08:00
Mouse Reeve
d3381d7a79 Paginates invite page
I sure have sent out a lot of invites
2021-02-23 14:41:33 -08:00
Mouse Reeve
3de8a20d39 Fixes boolean for is bookwyrm user in test 2021-02-23 14:36:24 -08:00
Mouse Reeve
5472281f29
Merge pull request #640 from mouse-reeve/rate-color
Makes the interactive rating element a different color
2021-02-23 14:19:32 -08:00
Mouse Reeve
2546aaedd6
Merge pull request #641 from mouse-reeve/discover-links
Makes covers clickable on discover page
2021-02-23 14:19:26 -08:00
Mouse Reeve
1db711b397
Merge pull request #639 from mouse-reeve/status-markup
Status markup
2021-02-23 14:19:19 -08:00
Mouse Reeve
1eaff91513 Makes the interactive rating element a different color 2021-02-23 14:08:52 -08:00
Mouse Reeve
31c9c07e38 Makes covers clickable on discover page 2021-02-23 14:06:08 -08:00
Mouse Reeve
d0c46060e8 Adds stars to book preview in status 2021-02-23 14:00:19 -08:00
Mouse Reeve
f9dd0b0246 Groups in book preview only used by status templates 2021-02-23 13:42:20 -08:00
Mouse Reeve
fdbd3688f4
Merge pull request #636 from mouse-reeve/follow-block-button
Cleans up display of follow/block/unfollow/unblock buttons
2021-02-23 13:38:02 -08:00
Mouse Reeve
a0b57837a7 Moves status templates into dir 2021-02-23 13:37:16 -08:00
Mouse Reeve
9ac332f6cc Adds request user for rss test 2021-02-23 13:26:44 -08:00
Mouse Reeve
152107a9af
Merge pull request #637 from mouse-reeve/mobile-header-buttons
Fixes header wrap on mobile headers
2021-02-23 13:25:17 -08:00
Mouse Reeve
a71171249d
Merge pull request #638 from mouse-reeve/list-mobile-display
List mobile display
2021-02-23 13:25:12 -08:00
Mouse Reeve
ffe5ce7251 User friendly-er add cover form
bulma has failed me. Fixes #628
2021-02-23 13:23:41 -08:00
Mouse Reeve
b9f06edc1b Fixes a few missed calls to get_user_from_username 2021-02-23 13:12:50 -08:00
Mouse Reeve
be9198fc4f Another place where get reviews is called in tests 2021-02-23 13:09:39 -08:00
Mouse Reeve
e6b4212e6b Typo fix 2021-02-23 13:05:43 -08:00
Mouse Reeve
8a3d1a0bf2 Fixes header wrap on mobile headers 2021-02-23 13:04:24 -08:00
Mouse Reeve
d1a21b851a Maintain list columns in mobile 2021-02-23 12:46:41 -08:00
Mouse Reeve
b1268b7db8 Small covers too small on mobile 2021-02-23 12:44:25 -08:00
Mouse Reeve
364b053d9a Better user block privacy 2021-02-23 12:41:37 -08:00
Mouse Reeve
a617302006 Cleans up display of follow/block/unfollow/unblock buttons 2021-02-23 12:10:54 -08:00
Mouse Reeve
c6a61abf79 Don't try to fetch reviews for remote user in test 2021-02-23 11:58:01 -08:00
Mouse Reeve
6e09d485c4 Outbox sensitive to user agent strings 2021-02-23 11:34:15 -08:00
Mouse Reeve
cbccdea468 fixes ordered collection serializations 2021-02-23 11:13:20 -08:00
Mouse Reeve
726a8739a3 way too much logging coming from http errors 2021-02-22 11:42:45 -08:00
Mouse Reeve
ef9acaf878 Adds tests for setting remote server 2021-02-22 11:38:11 -08:00
Mouse Reeve
6b74f56381 Safer set remote server 2021-02-22 10:01:19 -08:00
Mouse Reeve
bff75cedf5 Boolean error in user save causing infinite recursion 2021-02-22 09:41:52 -08:00
Mouse Reeve
f654444aab Fixes bug in saving remote server 2021-02-22 08:53:01 -08:00