Commit graph

605 commits

Author SHA1 Message Date
Fabien Basmaison 097b8e5811 Fix toggling all checkboxes of failed imports:
- Rename classes and function to something more descriptive.
- Listen to the element checked status instead of a click on a non‑focusable element.
- Use specific DOM targets instead of relying on the DOM ancestor tree.
- Add a skip‑link to the end of the list and avoid tabbing through all failed items.
- Update related i18n strings in French.
- Avoid having the label on the whole width to prevent accidental click.
- Move `fieldset` out of `ul`.
2021-03-05 15:41:21 +01:00
Mouse Reeve 5c089db086 Full add author flow 2021-03-04 17:10:33 -08:00
Mouse Reeve b2d1384bc5 UI for adding and removing authors 2021-03-04 15:10:55 -08:00
Mouse Reeve e2622d0594 Catches a couple translations, hides profile box when empty 2021-03-04 14:27:49 -08:00
Mouse Reeve 577f5db37b
Merge pull request #680 from arkhi/main
[profile] Fix HTML errors
2021-03-04 14:01:22 -08:00
Fabien Basmaison dab6592c12 Testing moving a comment to see what accesslint says. 2021-03-04 20:38:28 +01:00
Fabien Basmaison 16ea657b5b [a11y] Add aria-modal:
- Addresses https://github.com/mouse-reeve/bookwyrm/pull/680#issuecomment-790603940
2021-03-04 20:14:38 +01:00
Mouse Reeve 4c71c5fb73 Removes "fuzzy" flag from translated French strings 2021-03-04 08:04:55 -08:00
Mouse Reeve 4a06cc7a66 Revert "Un-fuzzies French translation strings"
This reverts commit a5d2cf4677.
2021-03-04 08:04:00 -08:00
Mouse Reeve a5d2cf4677 Un-fuzzies French translation strings 2021-03-04 08:02:57 -08:00
Mouse Reeve e5662b1752
Merge pull request #682 from reesporte/main
Spanish translation and one (1) typo fix
2021-03-03 20:10:52 -08:00
reese 5fe8b67ba7 fix typo :) 2021-03-03 20:08:42 -06:00
Fabien Basmaison 8c26d8a514 [profile] Updates for PR:
- Fix duplicated IDs between modals for the same status.
- Remove redundant button (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586743844).
- Remove redundant `role="navigation"` on `<nav>`.
- Add `dir="auto"` back for titles (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586715693).
- Use `exists` instead of `all` for conditional statement (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586716299).
- Fix missing spacing between avatar and username (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586740902).
2021-03-03 22:58:01 +01:00
Fabien Basmaison a05b14c338 [profile] Various HTML fixes:
- Wrap block level elements within block level elements, not inline.
- Avoid empty blocks.
- Change `<hr>` in lists into allowed type of children.
- Fix duplicated ID (some change that was not propagated across the template?).
- Make the anchor optional in the navbar (interactive elements (`a`, `input`, `button`…) should not appear into other interactive elements).
- Remove redundant `role` on main navigation.
- Make the modal a modal with `role="dialog".
- Use `button` instead of form-less `label`.
2021-03-03 20:10:09 +01:00
Mouse Reeve 327f14a150 Merge branch 'main' into create-book 2021-03-03 08:55:40 -08:00
Fabien Basmaison 0d8eb959ea [profile] Use unique IDs on statuses. 2021-03-03 15:48:04 +01:00
Mouse Reeve be3c7ac90e Fixes boost display 2021-03-02 20:17:32 -08:00
Mouse Reeve 549d8768a6 Combine a couple very similar translation strings
plus a whitespace fix
2021-03-02 10:46:08 -08:00
Mouse Reeve 2c37893790 Adds default shelf names translations 2021-03-02 10:32:46 -08:00
Mouse Reeve 27914d07b9 Missing translation strings on book and list pages 2021-03-02 10:23:11 -08:00
Mouse Reeve 5938c438e2 Translate table titles in header 2021-03-02 09:59:15 -08:00
Mouse Reeve 01df4ad321 Small fixes for translation 2021-03-02 09:25:45 -08:00
Mouse Reeve 2faf5cea2a modifies edit book code to allow creation as well 2021-03-02 09:01:31 -08:00
Mouse Reeve d16e4dc808 Enumerates notification options for translation 2021-03-01 09:32:03 -08:00
Mouse Reeve b9bf65ad2a Adds missing i18n imports 2021-02-28 17:52:48 -08:00
Mouse Reeve bd44bf0980 Merge branch 'main' into i18n-second-pass 2021-02-28 17:22:25 -08:00
Mouse Reeve 6a18803417 Catches more template translation moments 2021-02-28 17:10:30 -08:00
Mouse Reeve 10130f01d4
Merge pull request #662 from mouse-reeve/titles
Puts titles in templates instead of views
2021-02-28 16:15:39 -08:00
Mouse Reeve 310d4a1f59
Merge pull request #653 from greatislander/tab-keyboard-accessibility
feature: keyboard accessibility for tabbed UIs (fixes #526)
2021-02-28 11:11:54 -08:00
Mouse Reeve 72c50b3f58 Fixes typo in admn layout page 2021-02-28 10:45:21 -08:00
Mouse Reeve 5bc4456d4e Merge branch 'main' into review-rate 2021-02-28 10:35:20 -08:00
Mouse Reeve 3e9ee0973b cleans up i18n titles 2021-02-28 10:09:56 -08:00
Ned Zimmerman 263b13f157 Adapt tab handler to vanilla JS, fix focus jump, improve accessible naming of tabs/panels 2021-02-28 14:04:04 -04:00
Mouse Reeve c483768544 Moves titles into templates and adds i18n support 2021-02-28 10:00:36 -08:00
Mouse Reeve c4116c93b7 Merge branch 'main' into titles 2021-02-28 09:02:21 -08:00
Mouse Reeve 4df62a8ebd Simplifies translation strings 2021-02-28 08:42:25 -08:00
Ned Zimmerman b324e668ca Merge branch 'upstream' into tab-keyboard-accessibility 2021-02-28 12:39:56 -04:00
Mouse Reeve 4f76d21b85 Snags more strings for i18n 2021-02-27 18:48:10 -08:00
Mouse Reeve 27316678d5 Adds test german translations
with apologies to actual german speakers
2021-02-27 16:44:58 -08:00
Mouse Reeve 2d79a52133 Translations working in templates 2021-02-27 16:18:56 -08:00
Mouse Reeve b2e431daed Adds test localization file 2021-02-27 15:00:19 -08:00
Mouse Reeve 8e5e3a84d6 Quick first pass at tagging strings for localization 2021-02-27 14:22:39 -08:00
Mouse Reeve ad2a87d317 First pass at internationalization and localization 2021-02-27 13:43:55 -08:00
Mouse Reeve 04ed5d62dd
Merge pull request #649 from mmai/feature/importLibrarything
librarything import
2021-02-27 12:17:41 -08:00
Mouse Reeve 7622bef35d Adds separate privacy policy section 2021-02-27 11:53:36 -08:00
Mouse Reeve 9ed5226b58 Switches layout to use in-template html header titles 2021-02-27 11:07:16 -08:00
Ned Zimmerman bc7f830b2b Merge branch 'upstream' into tab-keyboard-accessibility 2021-02-27 11:53:27 -04:00
Ned Zimmerman 9580bec154 feat: modify tabbed interfaces to support keyboard accessibility (fixes #526) 2021-02-27 11:47:03 -04:00
Henri Bourcereau bfedb300ca librarything import : fix parsing & select box 2021-02-26 13:32:17 +01:00
Mouse Reeve 4a10c99026 Fixes handling of ratings in status views and urls 2021-02-25 15:05:51 -08:00
Mouse Reeve 2a5d4b83d8 Show dms in the right places 2021-02-24 11:59:21 -08:00
Henri Bourcereau b85fed3595 librarything import 2021-02-24 20:20:14 +01:00
Mouse Reeve 6426282db1 fixes goal page and test for goal page 2021-02-23 22:07:13 -08:00
Mouse Reeve fcc0e0ccb6 Cleans up formatting on about page 2021-02-23 19:58:04 -08:00
Mouse Reeve b4d9cdbe98
Merge pull request #643 from mouse-reeve/pressed-button-color
Makes comment and fav/boost buttons the same color when selected
2021-02-23 17:35:13 -08:00
Mouse Reeve 744de313c8 Makes comment and fav/boost buttons the same color when selected 2021-02-23 17:23:11 -08:00
Mouse Reeve 384187a263 Moves create invite form to top of invite page 2021-02-23 15:21:37 -08:00
Mouse Reeve d3381d7a79 Paginates invite page
I sure have sent out a lot of invites
2021-02-23 14:41:33 -08:00
Mouse Reeve 5472281f29
Merge pull request #640 from mouse-reeve/rate-color
Makes the interactive rating element a different color
2021-02-23 14:19:32 -08:00
Mouse Reeve 2546aaedd6
Merge pull request #641 from mouse-reeve/discover-links
Makes covers clickable on discover page
2021-02-23 14:19:26 -08:00
Mouse Reeve 1db711b397
Merge pull request #639 from mouse-reeve/status-markup
Status markup
2021-02-23 14:19:19 -08:00
Mouse Reeve 1eaff91513 Makes the interactive rating element a different color 2021-02-23 14:08:52 -08:00
Mouse Reeve 31c9c07e38 Makes covers clickable on discover page 2021-02-23 14:06:08 -08:00
Mouse Reeve d0c46060e8 Adds stars to book preview in status 2021-02-23 14:00:19 -08:00
Mouse Reeve f9dd0b0246 Groups in book preview only used by status templates 2021-02-23 13:42:20 -08:00
Mouse Reeve fdbd3688f4
Merge pull request #636 from mouse-reeve/follow-block-button
Cleans up display of follow/block/unfollow/unblock buttons
2021-02-23 13:38:02 -08:00
Mouse Reeve a0b57837a7 Moves status templates into dir 2021-02-23 13:37:16 -08:00
Mouse Reeve 152107a9af
Merge pull request #637 from mouse-reeve/mobile-header-buttons
Fixes header wrap on mobile headers
2021-02-23 13:25:17 -08:00
Mouse Reeve ffe5ce7251 User friendly-er add cover form
bulma has failed me. Fixes #628
2021-02-23 13:23:41 -08:00
Mouse Reeve 8a3d1a0bf2 Fixes header wrap on mobile headers 2021-02-23 13:04:24 -08:00
Mouse Reeve d1a21b851a Maintain list columns in mobile 2021-02-23 12:46:41 -08:00
Mouse Reeve a617302006 Cleans up display of follow/block/unfollow/unblock buttons 2021-02-23 12:10:54 -08:00
Mouse Reeve 8cb345886b Show lists on book page 2021-02-15 11:30:22 -08:00
Mouse Reeve 2297fe133d Uses template for generating goal status 2021-02-12 11:52:05 -08:00
Mouse Reeve 03dddaa064 Fixes list display 2021-02-12 09:58:57 -08:00
Mouse Reeve 403cc712c5 Fixes review pluralization 2021-02-12 09:55:25 -08:00
Mouse Reeve 89c0ecdca9 comma in number 2021-02-11 08:24:20 -08:00
Mouse Reeve 11504e9cef Makes covers clickable in places they aren't
Fixes #598
2021-02-10 16:45:53 -08:00
Mouse Reeve 8842db3c1b Create notification when adding or suggesting a book to a list 2021-02-10 13:46:56 -08:00
Mouse Reeve 475d0cbb26
Merge pull request #603 from mouse-reeve/rss-link
Adds link to rss feed from user page
2021-02-10 12:29:23 -08:00
Mouse Reeve f75acc385d Adds link to rss feed from user page 2021-02-10 12:13:07 -08:00
Mouse Reeve d29257e1ff Only show tabs on user page as appropriate 2021-02-10 11:48:49 -08:00
Mouse Reeve 96921e4be6
Merge pull request #574 from mouse-reeve/shelve-buttons
Shelve buttons
2021-02-10 09:01:33 -08:00
Mouse Reeve 486b660351
Merge pull request #594 from mouse-reeve/broadcast-fixes
Refactors broadcasting
2021-02-10 08:52:15 -08:00
Mouse Reeve 485de039cf
Merge branch 'main' into shelve-buttons 2021-02-09 13:28:00 -08:00
Mouse Reeve 7381536ad6 circular import issues and added_by migration 2021-02-04 14:27:26 -08:00
Mouse Reeve b015d6c9a1 Fixes hiding import book option in search for anonymous users 2021-02-04 11:46:42 -08:00
Mouse Reeve ae0034e678 Fixes mismatched html tags 2021-02-03 18:09:07 -08:00
Mouse Reeve 736f28e254 Fixes user tabs linking to logged in user 2021-02-03 17:02:04 -08:00
Mouse Reeve 3f2f27bcac Fixes logged out list view 2021-02-03 16:40:29 -08:00
Mouse Reeve 39d31060e1 Sort list preview by most recently added 2021-02-03 16:11:42 -08:00
Mouse Reeve 502e235e59 Edit shelf form using component 2021-02-03 12:45:01 -08:00
Mouse Reeve bcbcdd5b3b Uses component for create shelf form 2021-02-03 12:36:20 -08:00
Mouse Reeve 6ce4be7406 Adds inline form component 2021-02-03 12:25:33 -08:00
Mouse Reeve 0ba7c60e83
Merge pull request #577 from mouse-reeve/lists
Lists
2021-02-03 10:57:19 -08:00
Mouse Reeve 627b2ae90a Set header when opening forms 2021-02-02 15:46:58 -08:00
Mouse Reeve 3f9bb97693
Merge pull request #583 from mouse-reeve/level
adds icons to discover page
2021-02-02 12:10:59 -08:00
Mouse Reeve d37f8f68d8 Adds user lists template 2021-02-02 10:13:59 -08:00
Mouse Reeve 05c00b9eca Adds cute lil icons to discover page 2021-02-02 10:13:35 -08:00
Mouse Reeve d2fc3febb0 Show reading activity panel when no readthroughs exist 2021-02-02 09:44:29 -08:00