Fix (new) clippy warnings

.gitlab-ci.yml

@@ -347,7 +347,7 @@ clippy:
   extends: .img-stable
   stage: 'extras'
   variables:
-    CLIPPY_LINTS: -A clippy::missing_safety_doc -A clippy::manual_range_contains -A clippy::upper_case_acronyms -A clippy::wrong_self_convention -D warnings
+    CLIPPY_LINTS: -D warnings
   script:
     - cargo clippy --version
       # Keep features in sync with above

examples/src/bin/debug_ringbuffer.rs

@@ -28,7 +28,7 @@ fn example_main() {
 
     let mut context = gst::ParseContext::new();
     let pipeline =
-        match gst::parse_launch_full(&pipeline_str, Some(&mut context), gst::ParseFlags::empty()) {
+        match gst::parse_launch_full(pipeline_str, Some(&mut context), gst::ParseFlags::empty()) {
             Ok(pipeline) => pipeline,
             Err(err) => {
                 if let Some(gst::ParseError::NoSuchElement) = err.kind::<gst::ParseError>() {

examples/src/bin/thumbnail.rs

@@ -79,7 +79,7 @@ fn create_pipeline(uri: String, out_path: std::path::PathBuf) -> Result<gst::Pip
                 })?;
 
                 let caps = sample.caps().expect("Sample without caps");
-                let info = gst_video::VideoInfo::from_caps(&caps).expect("Failed to parse caps");
+                let info = gst_video::VideoInfo::from_caps(caps).expect("Failed to parse caps");
 
                 // Make sure that we only get a single buffer
                 if got_snapshot {

examples/src/glupload.rs

@@ -75,6 +75,7 @@ void main() {
 #[allow(clippy::unused_unit)]
 #[allow(clippy::too_many_arguments)]
 #[allow(clippy::manual_non_exhaustive)]
+#[allow(clippy::upper_case_acronyms)]
 pub(crate) mod gl {
     pub use self::Gles2 as Gl;
     include!(concat!(env!("OUT_DIR"), "/test_gl_bindings.rs"));

gstreamer-app/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-audio/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-base/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-check/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-controller/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-editing-services/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-gl/egl/src/lib.rs

@@ -7,6 +7,7 @@
 // except according to those terms.
 
 #![cfg_attr(all(not(doctest), doc), feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 
 pub use ffi;
 pub use gst_gl;

gstreamer-gl/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-gl/wayland/src/lib.rs

@@ -7,6 +7,7 @@
 // except according to those terms.
 
 #![cfg_attr(all(not(doctest), doc), feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 
 pub use ffi;
 pub use gst_gl;

gstreamer-gl/x11/src/lib.rs

@@ -7,6 +7,7 @@
 // except according to those terms.
 
 #![cfg_attr(all(not(doctest), doc), feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 
 pub use ffi;
 pub use gst_gl;

gstreamer-net/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-pbutils/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-player/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-rtp/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::manual_range_contains)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-rtsp-server/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-rtsp/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-sdp/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-video/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer-webrtc/src/lib.rs

@@ -1,6 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
+#![allow(clippy::missing_safety_doc)]
 #![doc = include_str!("../README.md")]
 
 pub use ffi;

gstreamer/src/caps_features_serde.rs

@@ -20,8 +20,8 @@ const CAPS_FEATURES_VARIANT_SOME_ID: u32 = 1;
 const CAPS_FEATURES_VARIANT_SOME_STR: &str = "Some";
 
 const CAPS_FEATURES_VARIANT_NAMES: &[&str] = &[
-    &CAPS_FEATURES_VARIANT_ANY_STR,
-    &CAPS_FEATURES_VARIANT_SOME_STR,
+    CAPS_FEATURES_VARIANT_ANY_STR,
+    CAPS_FEATURES_VARIANT_SOME_STR,
 ];
 
 struct CapsFeaturesForIterSe<'a>(&'a CapsFeaturesRef);
@@ -55,7 +55,7 @@ impl Serialize for CapsFeaturesRef {
                 stringify!(CapsFeatures),
                 CAPS_FEATURES_VARIANT_SOME_ID,
                 CAPS_FEATURES_VARIANT_SOME_STR,
-                &CapsFeaturesForIterSe(&self),
+                &CapsFeaturesForIterSe(self),
             )
         }
     }

gstreamer/src/caps_serde.rs

@@ -27,9 +27,9 @@ const CAPS_VARIANT_SOME_ID: u32 = 2;
 const CAPS_VARIANT_SOME_STR: &str = "Some";
 
 const CAPS_VARIANT_NAMES: &[&str] = &[
-    &CAPS_VARIANT_ANY_STR,
-    &CAPS_VARIANT_EMPTY_STR,
-    &CAPS_VARIANT_SOME_STR,
+    CAPS_VARIANT_ANY_STR,
+    CAPS_VARIANT_EMPTY_STR,
+    CAPS_VARIANT_SOME_STR,
 ];
 
 struct CapsItemSe<'a>(&'a StructureRef, Option<&'a CapsFeaturesRef>);
@@ -86,7 +86,7 @@ impl Serialize for CapsRef {
                 stringify!(Caps),
                 CAPS_VARIANT_SOME_ID,
                 CAPS_VARIANT_SOME_STR,
-                &CapsForIterSe(&self),
+                &CapsForIterSe(self),
             )
         }
     }

gstreamer/src/date_time_serde.rs

@@ -1,5 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
+#![allow(clippy::upper_case_acronyms)]
+
 use std::convert::{TryFrom, TryInto};
 
 use glib::translate::{FromGlib, IntoGlib};

gstreamer/src/lib.rs

@@ -2,6 +2,8 @@
 
 #![cfg_attr(feature = "dox", feature(doc_cfg))]
 #![recursion_limit = "256"]
+#![allow(clippy::missing_safety_doc)]
+#![allow(clippy::manual_range_contains)]
 #![doc = include_str!("../README.md")]
 
 // Re-exported for the subclass gst_plugin_define! macro

gstreamer/src/structure_serde.rs

@@ -1,5 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
+#![allow(clippy::upper_case_acronyms)]
+
 use glib::{Date, ToValue};
 
 use serde::de;

gstreamer/src/tags_serde.rs

@@ -1,5 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
+#![allow(clippy::upper_case_acronyms)]
+
 use glib::translate::{from_glib, ToGlibPtr};
 use glib::{Date, SendValue, ToValue};
 
@@ -104,7 +106,7 @@ impl<'a> Serialize for TagsSer<'a> {
     fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
         let mut tup = serializer.serialize_tuple(2)?;
         tup.serialize_element(self.0)?;
-        tup.serialize_element(&TagValuesSer::from(&self))?;
+        tup.serialize_element(&TagValuesSer::from(self))?;
         tup.end()
     }
 }

gstreamer/src/value_serde.rs

@@ -1,5 +1,7 @@
 // Take a look at the license at the top of the repository in the LICENSE file.
 
+#![allow(clippy::upper_case_acronyms)]
+
 use glib::{Date, StaticType, ToValue};
 
 use num_rational::Rational32;