diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e19f02bb9..725381885 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -347,7 +347,7 @@ clippy: extends: .img-stable stage: 'extras' variables: - CLIPPY_LINTS: -A clippy::missing_safety_doc -A clippy::manual_range_contains -A clippy::upper_case_acronyms -A clippy::wrong_self_convention -D warnings + CLIPPY_LINTS: -D warnings script: - cargo clippy --version # Keep features in sync with above diff --git a/examples/src/bin/debug_ringbuffer.rs b/examples/src/bin/debug_ringbuffer.rs index a3284ca7f..d9b8a6578 100644 --- a/examples/src/bin/debug_ringbuffer.rs +++ b/examples/src/bin/debug_ringbuffer.rs @@ -28,7 +28,7 @@ fn example_main() { let mut context = gst::ParseContext::new(); let pipeline = - match gst::parse_launch_full(&pipeline_str, Some(&mut context), gst::ParseFlags::empty()) { + match gst::parse_launch_full(pipeline_str, Some(&mut context), gst::ParseFlags::empty()) { Ok(pipeline) => pipeline, Err(err) => { if let Some(gst::ParseError::NoSuchElement) = err.kind::() { diff --git a/examples/src/bin/thumbnail.rs b/examples/src/bin/thumbnail.rs index 017414ef3..5b56ee5df 100644 --- a/examples/src/bin/thumbnail.rs +++ b/examples/src/bin/thumbnail.rs @@ -79,7 +79,7 @@ fn create_pipeline(uri: String, out_path: std::path::PathBuf) -> Result(&'a CapsFeaturesRef); @@ -55,7 +55,7 @@ impl Serialize for CapsFeaturesRef { stringify!(CapsFeatures), CAPS_FEATURES_VARIANT_SOME_ID, CAPS_FEATURES_VARIANT_SOME_STR, - &CapsFeaturesForIterSe(&self), + &CapsFeaturesForIterSe(self), ) } } diff --git a/gstreamer/src/caps_serde.rs b/gstreamer/src/caps_serde.rs index a9c7720d0..c90e81fbd 100644 --- a/gstreamer/src/caps_serde.rs +++ b/gstreamer/src/caps_serde.rs @@ -27,9 +27,9 @@ const CAPS_VARIANT_SOME_ID: u32 = 2; const CAPS_VARIANT_SOME_STR: &str = "Some"; const CAPS_VARIANT_NAMES: &[&str] = &[ - &CAPS_VARIANT_ANY_STR, - &CAPS_VARIANT_EMPTY_STR, - &CAPS_VARIANT_SOME_STR, + CAPS_VARIANT_ANY_STR, + CAPS_VARIANT_EMPTY_STR, + CAPS_VARIANT_SOME_STR, ]; struct CapsItemSe<'a>(&'a StructureRef, Option<&'a CapsFeaturesRef>); @@ -86,7 +86,7 @@ impl Serialize for CapsRef { stringify!(Caps), CAPS_VARIANT_SOME_ID, CAPS_VARIANT_SOME_STR, - &CapsForIterSe(&self), + &CapsForIterSe(self), ) } } diff --git a/gstreamer/src/date_time_serde.rs b/gstreamer/src/date_time_serde.rs index 8eea7694c..470a4ed2c 100644 --- a/gstreamer/src/date_time_serde.rs +++ b/gstreamer/src/date_time_serde.rs @@ -1,5 +1,7 @@ // Take a look at the license at the top of the repository in the LICENSE file. +#![allow(clippy::upper_case_acronyms)] + use std::convert::{TryFrom, TryInto}; use glib::translate::{FromGlib, IntoGlib}; diff --git a/gstreamer/src/lib.rs b/gstreamer/src/lib.rs index 309b582c6..8ddaf9957 100644 --- a/gstreamer/src/lib.rs +++ b/gstreamer/src/lib.rs @@ -2,6 +2,8 @@ #![cfg_attr(feature = "dox", feature(doc_cfg))] #![recursion_limit = "256"] +#![allow(clippy::missing_safety_doc)] +#![allow(clippy::manual_range_contains)] #![doc = include_str!("../README.md")] // Re-exported for the subclass gst_plugin_define! macro diff --git a/gstreamer/src/structure_serde.rs b/gstreamer/src/structure_serde.rs index 06fb45110..9c3d399c5 100644 --- a/gstreamer/src/structure_serde.rs +++ b/gstreamer/src/structure_serde.rs @@ -1,5 +1,7 @@ // Take a look at the license at the top of the repository in the LICENSE file. +#![allow(clippy::upper_case_acronyms)] + use glib::{Date, ToValue}; use serde::de; diff --git a/gstreamer/src/tags_serde.rs b/gstreamer/src/tags_serde.rs index 28798a376..f8c79dead 100644 --- a/gstreamer/src/tags_serde.rs +++ b/gstreamer/src/tags_serde.rs @@ -1,5 +1,7 @@ // Take a look at the license at the top of the repository in the LICENSE file. +#![allow(clippy::upper_case_acronyms)] + use glib::translate::{from_glib, ToGlibPtr}; use glib::{Date, SendValue, ToValue}; @@ -104,7 +106,7 @@ impl<'a> Serialize for TagsSer<'a> { fn serialize(&self, serializer: S) -> Result { let mut tup = serializer.serialize_tuple(2)?; tup.serialize_element(self.0)?; - tup.serialize_element(&TagValuesSer::from(&self))?; + tup.serialize_element(&TagValuesSer::from(self))?; tup.end() } } diff --git a/gstreamer/src/value_serde.rs b/gstreamer/src/value_serde.rs index c3d6dc03b..54d34a37f 100644 --- a/gstreamer/src/value_serde.rs +++ b/gstreamer/src/value_serde.rs @@ -1,5 +1,7 @@ // Take a look at the license at the top of the repository in the LICENSE file. +#![allow(clippy::upper_case_acronyms)] + use glib::{Date, StaticType, ToValue}; use num_rational::Rational32;