mirrors/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-01-19 22:06:17 +00:00
Code Issues Projects Releases Wiki Activity

Remove panic recovering (#3162)

Browse source
This commit is contained in:
qwerty287 2024-01-11 19:37:47 +01:00 committed by GitHub
parent f8fb28e651
commit d0380e31b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
server/queue/fifo.go
View file

@ -17,7 +17,6 @@ package queue
import ( import (
"container/list" "container/list"
"context" "context"
"runtime"
"sync" "sync"
"time" "time"
@ -241,17 +240,6 @@ func (q *fifo) process() {
return return
} }
defer func() {
// the risk of panic is low. This code can probably be removed
// once the code has been used in real world installs without issue.
if err := recover(); err != nil {
const size = 64 << 10
buf := make([]byte, size)
buf = buf[:runtime.Stack(buf, false)]
log.Error().Msgf("queue: unexpected panic: %v\n%s", err, buf)
}
}()
q.resubmitExpiredPipelines() q.resubmitExpiredPipelines()
q.filterWaiting() q.filterWaiting()
for pending, worker := q.assignToWorker(); pending != nil && worker != nil; pending, worker = q.assignToWorker() { for pending, worker := q.assignToWorker(); pending != nil && worker != nil; pending, worker = q.assignToWorker() {