From d0380e31b538393e680add35cc95eff70bd12eb3 Mon Sep 17 00:00:00 2001 From: qwerty287 <80460567+qwerty287@users.noreply.github.com> Date: Thu, 11 Jan 2024 19:37:47 +0100 Subject: [PATCH] Remove panic recovering (#3162) --- server/queue/fifo.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/server/queue/fifo.go b/server/queue/fifo.go index f86c2a866..086f1644f 100644 --- a/server/queue/fifo.go +++ b/server/queue/fifo.go @@ -17,7 +17,6 @@ package queue import ( "container/list" "context" - "runtime" "sync" "time" @@ -241,17 +240,6 @@ func (q *fifo) process() { return } - defer func() { - // the risk of panic is low. This code can probably be removed - // once the code has been used in real world installs without issue. - if err := recover(); err != nil { - const size = 64 << 10 - buf := make([]byte, size) - buf = buf[:runtime.Stack(buf, false)] - log.Error().Msgf("queue: unexpected panic: %v\n%s", err, buf) - } - }() - q.resubmitExpiredPipelines() q.filterWaiting() for pending, worker := q.assignToWorker(); pending != nil && worker != nil; pending, worker = q.assignToWorker() {