mirror of
https://git.pleroma.social/pleroma/pleroma.git
synced 2024-11-03 15:39:46 +00:00
b3c80b8404
Fix exclude_visibilities filter for followers-only Like notifications See merge request pleroma/pleroma!1957
472 lines
15 KiB
Elixir
472 lines
15 KiB
Elixir
# Pleroma: A lightweight social networking server
|
|
# Copyright © 2017-2019 Pleroma Authors <https://pleroma.social/>
|
|
# SPDX-License-Identifier: AGPL-3.0-only
|
|
|
|
defmodule Pleroma.Web.MastodonAPI.NotificationControllerTest do
|
|
use Pleroma.Web.ConnCase
|
|
|
|
alias Pleroma.Notification
|
|
alias Pleroma.Repo
|
|
alias Pleroma.User
|
|
alias Pleroma.Web.CommonAPI
|
|
|
|
import Pleroma.Factory
|
|
|
|
test "list of notifications", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
|
|
{:ok, [_notification]} = Notification.create_notifications(activity)
|
|
|
|
conn =
|
|
conn
|
|
|> assign(:user, user)
|
|
|> get("/api/v1/notifications")
|
|
|
|
expected_response =
|
|
"hi <span class=\"h-card\"><a data-user=\"#{user.id}\" class=\"u-url mention\" href=\"#{
|
|
user.ap_id
|
|
}\" rel=\"ugc\">@<span>#{user.nickname}</span></a></span>"
|
|
|
|
assert [%{"status" => %{"content" => response}} | _rest] = json_response(conn, 200)
|
|
assert response == expected_response
|
|
end
|
|
|
|
test "getting a single notification", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
|
|
{:ok, [notification]} = Notification.create_notifications(activity)
|
|
|
|
conn =
|
|
conn
|
|
|> assign(:user, user)
|
|
|> get("/api/v1/notifications/#{notification.id}")
|
|
|
|
expected_response =
|
|
"hi <span class=\"h-card\"><a data-user=\"#{user.id}\" class=\"u-url mention\" href=\"#{
|
|
user.ap_id
|
|
}\" rel=\"ugc\">@<span>#{user.nickname}</span></a></span>"
|
|
|
|
assert %{"status" => %{"content" => response}} = json_response(conn, 200)
|
|
assert response == expected_response
|
|
end
|
|
|
|
test "dismissing a single notification", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
|
|
{:ok, [notification]} = Notification.create_notifications(activity)
|
|
|
|
conn =
|
|
conn
|
|
|> assign(:user, user)
|
|
|> post("/api/v1/notifications/dismiss", %{"id" => notification.id})
|
|
|
|
assert %{} = json_response(conn, 200)
|
|
end
|
|
|
|
test "clearing all notifications", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
|
|
{:ok, [_notification]} = Notification.create_notifications(activity)
|
|
|
|
conn =
|
|
conn
|
|
|> assign(:user, user)
|
|
|> post("/api/v1/notifications/clear")
|
|
|
|
assert %{} = json_response(conn, 200)
|
|
|
|
conn =
|
|
build_conn()
|
|
|> assign(:user, user)
|
|
|> get("/api/v1/notifications")
|
|
|
|
assert all = json_response(conn, 200)
|
|
assert all == []
|
|
end
|
|
|
|
test "paginates notifications using min_id, since_id, max_id, and limit", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity1} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
{:ok, activity2} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
{:ok, activity3} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
{:ok, activity4} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
|
|
notification1_id = get_notification_id_by_activity(activity1)
|
|
notification2_id = get_notification_id_by_activity(activity2)
|
|
notification3_id = get_notification_id_by_activity(activity3)
|
|
notification4_id = get_notification_id_by_activity(activity4)
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
# min_id
|
|
result =
|
|
conn
|
|
|> get("/api/v1/notifications?limit=2&min_id=#{notification1_id}")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification3_id}, %{"id" => ^notification2_id}] = result
|
|
|
|
# since_id
|
|
result =
|
|
conn
|
|
|> get("/api/v1/notifications?limit=2&since_id=#{notification1_id}")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification4_id}, %{"id" => ^notification3_id}] = result
|
|
|
|
# max_id
|
|
result =
|
|
conn
|
|
|> get("/api/v1/notifications?limit=2&max_id=#{notification4_id}")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification3_id}, %{"id" => ^notification2_id}] = result
|
|
end
|
|
|
|
describe "exclude_visibilities" do
|
|
test "filters notifications for mentions", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, public_activity} =
|
|
CommonAPI.post(other_user, %{"status" => "@#{user.nickname}", "visibility" => "public"})
|
|
|
|
{:ok, direct_activity} =
|
|
CommonAPI.post(other_user, %{"status" => "@#{user.nickname}", "visibility" => "direct"})
|
|
|
|
{:ok, unlisted_activity} =
|
|
CommonAPI.post(other_user, %{"status" => "@#{user.nickname}", "visibility" => "unlisted"})
|
|
|
|
{:ok, private_activity} =
|
|
CommonAPI.post(other_user, %{"status" => "@#{user.nickname}", "visibility" => "private"})
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{
|
|
exclude_visibilities: ["public", "unlisted", "private"]
|
|
})
|
|
|
|
assert [%{"status" => %{"id" => id}}] = json_response(conn_res, 200)
|
|
assert id == direct_activity.id
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{
|
|
exclude_visibilities: ["public", "unlisted", "direct"]
|
|
})
|
|
|
|
assert [%{"status" => %{"id" => id}}] = json_response(conn_res, 200)
|
|
assert id == private_activity.id
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{
|
|
exclude_visibilities: ["public", "private", "direct"]
|
|
})
|
|
|
|
assert [%{"status" => %{"id" => id}}] = json_response(conn_res, 200)
|
|
assert id == unlisted_activity.id
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{
|
|
exclude_visibilities: ["unlisted", "private", "direct"]
|
|
})
|
|
|
|
assert [%{"status" => %{"id" => id}}] = json_response(conn_res, 200)
|
|
assert id == public_activity.id
|
|
end
|
|
|
|
test "filters notifications for Like activities", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, public_activity} =
|
|
CommonAPI.post(other_user, %{"status" => ".", "visibility" => "public"})
|
|
|
|
{:ok, direct_activity} =
|
|
CommonAPI.post(other_user, %{"status" => "@#{user.nickname}", "visibility" => "direct"})
|
|
|
|
{:ok, unlisted_activity} =
|
|
CommonAPI.post(other_user, %{"status" => ".", "visibility" => "unlisted"})
|
|
|
|
{:ok, private_activity} =
|
|
CommonAPI.post(other_user, %{"status" => ".", "visibility" => "private"})
|
|
|
|
{:ok, _, _} = CommonAPI.favorite(public_activity.id, user)
|
|
{:ok, _, _} = CommonAPI.favorite(direct_activity.id, user)
|
|
{:ok, _, _} = CommonAPI.favorite(unlisted_activity.id, user)
|
|
{:ok, _, _} = CommonAPI.favorite(private_activity.id, user)
|
|
|
|
activity_ids =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|> get("/api/v1/notifications", %{exclude_visibilities: ["direct"]})
|
|
|> json_response(200)
|
|
|> Enum.map(& &1["status"]["id"])
|
|
|
|
assert public_activity.id in activity_ids
|
|
assert unlisted_activity.id in activity_ids
|
|
assert private_activity.id in activity_ids
|
|
refute direct_activity.id in activity_ids
|
|
|
|
activity_ids =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|> get("/api/v1/notifications", %{exclude_visibilities: ["unlisted"]})
|
|
|> json_response(200)
|
|
|> Enum.map(& &1["status"]["id"])
|
|
|
|
assert public_activity.id in activity_ids
|
|
refute unlisted_activity.id in activity_ids
|
|
assert private_activity.id in activity_ids
|
|
assert direct_activity.id in activity_ids
|
|
|
|
activity_ids =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|> get("/api/v1/notifications", %{exclude_visibilities: ["private"]})
|
|
|> json_response(200)
|
|
|> Enum.map(& &1["status"]["id"])
|
|
|
|
assert public_activity.id in activity_ids
|
|
assert unlisted_activity.id in activity_ids
|
|
refute private_activity.id in activity_ids
|
|
assert direct_activity.id in activity_ids
|
|
|
|
activity_ids =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|> get("/api/v1/notifications", %{exclude_visibilities: ["public"]})
|
|
|> json_response(200)
|
|
|> Enum.map(& &1["status"]["id"])
|
|
|
|
refute public_activity.id in activity_ids
|
|
assert unlisted_activity.id in activity_ids
|
|
assert private_activity.id in activity_ids
|
|
assert direct_activity.id in activity_ids
|
|
end
|
|
|
|
test "filters notifications for Announce activities", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, public_activity} =
|
|
CommonAPI.post(other_user, %{"status" => ".", "visibility" => "public"})
|
|
|
|
{:ok, unlisted_activity} =
|
|
CommonAPI.post(other_user, %{"status" => ".", "visibility" => "unlisted"})
|
|
|
|
{:ok, _, _} = CommonAPI.repeat(public_activity.id, user)
|
|
{:ok, _, _} = CommonAPI.repeat(unlisted_activity.id, user)
|
|
|
|
activity_ids =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|> get("/api/v1/notifications", %{exclude_visibilities: ["unlisted"]})
|
|
|> json_response(200)
|
|
|> Enum.map(& &1["status"]["id"])
|
|
|
|
assert public_activity.id in activity_ids
|
|
refute unlisted_activity.id in activity_ids
|
|
end
|
|
end
|
|
|
|
test "filters notifications using exclude_types", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, mention_activity} = CommonAPI.post(other_user, %{"status" => "hey @#{user.nickname}"})
|
|
{:ok, create_activity} = CommonAPI.post(user, %{"status" => "hey"})
|
|
{:ok, favorite_activity, _} = CommonAPI.favorite(create_activity.id, other_user)
|
|
{:ok, reblog_activity, _} = CommonAPI.repeat(create_activity.id, other_user)
|
|
{:ok, _, _, follow_activity} = CommonAPI.follow(other_user, user)
|
|
|
|
mention_notification_id = get_notification_id_by_activity(mention_activity)
|
|
favorite_notification_id = get_notification_id_by_activity(favorite_activity)
|
|
reblog_notification_id = get_notification_id_by_activity(reblog_activity)
|
|
follow_notification_id = get_notification_id_by_activity(follow_activity)
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{exclude_types: ["mention", "favourite", "reblog"]})
|
|
|
|
assert [%{"id" => ^follow_notification_id}] = json_response(conn_res, 200)
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{exclude_types: ["favourite", "reblog", "follow"]})
|
|
|
|
assert [%{"id" => ^mention_notification_id}] = json_response(conn_res, 200)
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{exclude_types: ["reblog", "follow", "mention"]})
|
|
|
|
assert [%{"id" => ^favorite_notification_id}] = json_response(conn_res, 200)
|
|
|
|
conn_res =
|
|
get(conn, "/api/v1/notifications", %{exclude_types: ["follow", "mention", "favourite"]})
|
|
|
|
assert [%{"id" => ^reblog_notification_id}] = json_response(conn_res, 200)
|
|
end
|
|
|
|
test "destroy multiple", %{conn: conn} do
|
|
user = insert(:user)
|
|
other_user = insert(:user)
|
|
|
|
{:ok, activity1} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
{:ok, activity2} = CommonAPI.post(other_user, %{"status" => "hi @#{user.nickname}"})
|
|
{:ok, activity3} = CommonAPI.post(user, %{"status" => "hi @#{other_user.nickname}"})
|
|
{:ok, activity4} = CommonAPI.post(user, %{"status" => "hi @#{other_user.nickname}"})
|
|
|
|
notification1_id = get_notification_id_by_activity(activity1)
|
|
notification2_id = get_notification_id_by_activity(activity2)
|
|
notification3_id = get_notification_id_by_activity(activity3)
|
|
notification4_id = get_notification_id_by_activity(activity4)
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
result =
|
|
conn
|
|
|> get("/api/v1/notifications")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification2_id}, %{"id" => ^notification1_id}] = result
|
|
|
|
conn2 =
|
|
conn
|
|
|> assign(:user, other_user)
|
|
|
|
result =
|
|
conn2
|
|
|> get("/api/v1/notifications")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification4_id}, %{"id" => ^notification3_id}] = result
|
|
|
|
conn_destroy =
|
|
conn
|
|
|> delete("/api/v1/notifications/destroy_multiple", %{
|
|
"ids" => [notification1_id, notification2_id]
|
|
})
|
|
|
|
assert json_response(conn_destroy, 200) == %{}
|
|
|
|
result =
|
|
conn2
|
|
|> get("/api/v1/notifications")
|
|
|> json_response(:ok)
|
|
|
|
assert [%{"id" => ^notification4_id}, %{"id" => ^notification3_id}] = result
|
|
end
|
|
|
|
test "doesn't see notifications after muting user with notifications", %{conn: conn} do
|
|
user = insert(:user)
|
|
user2 = insert(:user)
|
|
|
|
{:ok, _, _, _} = CommonAPI.follow(user, user2)
|
|
{:ok, _} = CommonAPI.post(user2, %{"status" => "hey @#{user.nickname}"})
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
conn = get(conn, "/api/v1/notifications")
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
|
|
{:ok, _user_relationships} = User.mute(user, user2)
|
|
|
|
conn = assign(build_conn(), :user, user)
|
|
conn = get(conn, "/api/v1/notifications")
|
|
|
|
assert json_response(conn, 200) == []
|
|
end
|
|
|
|
test "see notifications after muting user without notifications", %{conn: conn} do
|
|
user = insert(:user)
|
|
user2 = insert(:user)
|
|
|
|
{:ok, _, _, _} = CommonAPI.follow(user, user2)
|
|
{:ok, _} = CommonAPI.post(user2, %{"status" => "hey @#{user.nickname}"})
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
conn = get(conn, "/api/v1/notifications")
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
|
|
{:ok, _user_relationships} = User.mute(user, user2, false)
|
|
|
|
conn = assign(build_conn(), :user, user)
|
|
conn = get(conn, "/api/v1/notifications")
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
end
|
|
|
|
test "see notifications after muting user with notifications and with_muted parameter", %{
|
|
conn: conn
|
|
} do
|
|
user = insert(:user)
|
|
user2 = insert(:user)
|
|
|
|
{:ok, _, _, _} = CommonAPI.follow(user, user2)
|
|
{:ok, _} = CommonAPI.post(user2, %{"status" => "hey @#{user.nickname}"})
|
|
|
|
conn = assign(conn, :user, user)
|
|
|
|
conn = get(conn, "/api/v1/notifications")
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
|
|
{:ok, _user_relationships} = User.mute(user, user2)
|
|
|
|
conn = assign(build_conn(), :user, user)
|
|
conn = get(conn, "/api/v1/notifications", %{"with_muted" => "true"})
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
end
|
|
|
|
test "see move notifications with `with_move` parameter", %{
|
|
conn: conn
|
|
} do
|
|
old_user = insert(:user)
|
|
new_user = insert(:user, also_known_as: [old_user.ap_id])
|
|
follower = insert(:user)
|
|
|
|
User.follow(follower, old_user)
|
|
Pleroma.Web.ActivityPub.ActivityPub.move(old_user, new_user)
|
|
Pleroma.Tests.ObanHelpers.perform_all()
|
|
|
|
conn =
|
|
conn
|
|
|> assign(:user, follower)
|
|
|> get("/api/v1/notifications")
|
|
|
|
assert json_response(conn, 200) == []
|
|
|
|
conn =
|
|
build_conn()
|
|
|> assign(:user, follower)
|
|
|> get("/api/v1/notifications", %{"with_move" => "true"})
|
|
|
|
assert length(json_response(conn, 200)) == 1
|
|
end
|
|
|
|
defp get_notification_id_by_activity(%{id: id}) do
|
|
Notification
|
|
|> Repo.get_by(activity_id: id)
|
|
|> Map.get(:id)
|
|
|> to_string()
|
|
end
|
|
end
|