mirror of
https://git.pleroma.social/pleroma/pleroma.git
synced 2024-12-23 00:26:30 +00:00
Merge branch 'feature/configure-filename-truncate' into 'develop'
Configurable filename truncation threshold Closes #1799 See merge request pleroma/pleroma!2573
This commit is contained in:
commit
ddbbefeb2e
6 changed files with 47 additions and 14 deletions
|
@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
|
||||||
- NodeInfo: `pleroma_emoji_reactions` to the `features` list.
|
- NodeInfo: `pleroma_emoji_reactions` to the `features` list.
|
||||||
- Configuration: `:restrict_unauthenticated` setting, restrict access for unauthenticated users to timelines (public and federate), user profiles and statuses.
|
- Configuration: `:restrict_unauthenticated` setting, restrict access for unauthenticated users to timelines (public and federate), user profiles and statuses.
|
||||||
- Configuration: Add `:database_config_whitelist` setting to whitelist settings which can be configured from AdminFE.
|
- Configuration: Add `:database_config_whitelist` setting to whitelist settings which can be configured from AdminFE.
|
||||||
|
- Configuration: `filename_display_max_length` option to set filename truncate limit, if filename display enabled (0 = no limit).
|
||||||
- New HTTP adapter [gun](https://github.com/ninenines/gun). Gun adapter requires minimum OTP version of 22.2 otherwise Pleroma won’t start. For hackney OTP update is not required.
|
- New HTTP adapter [gun](https://github.com/ninenines/gun). Gun adapter requires minimum OTP version of 22.2 otherwise Pleroma won’t start. For hackney OTP update is not required.
|
||||||
- Mix task to create trusted OAuth App.
|
- Mix task to create trusted OAuth App.
|
||||||
- Notifications: Added `follow_request` notification type.
|
- Notifications: Added `follow_request` notification type.
|
||||||
|
@ -47,7 +48,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
|
||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
- Healthcheck reporting the number of memory currently used, rather than allocated in total
|
- Healthcheck reporting the number of memory currently used, rather than allocated in total
|
||||||
- `InsertSkeletonsForDeletedUsers` failing on some instances
|
- `InsertSkeletonsForDeletedUsers` failing on some instances
|
||||||
|
|
||||||
## [2.0.3] - 2020-05-02
|
## [2.0.3] - 2020-05-02
|
||||||
|
|
||||||
|
|
|
@ -71,7 +71,8 @@ config :pleroma, Pleroma.Upload,
|
||||||
follow_redirect: true,
|
follow_redirect: true,
|
||||||
pool: :upload
|
pool: :upload
|
||||||
]
|
]
|
||||||
]
|
],
|
||||||
|
filename_display_max_length: 30
|
||||||
|
|
||||||
config :pleroma, Pleroma.Uploaders.Local, uploads: "uploads"
|
config :pleroma, Pleroma.Uploaders.Local, uploads: "uploads"
|
||||||
|
|
||||||
|
|
|
@ -119,6 +119,11 @@ config :pleroma, :config_description, [
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
|
},
|
||||||
|
%{
|
||||||
|
key: :filename_display_max_length,
|
||||||
|
type: :integer,
|
||||||
|
description: "Set max length of a filename to display. 0 = no limit. Default: 30"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
|
|
|
@ -498,6 +498,7 @@ the source code is here: https://github.com/koto-bank/kocaptcha. The default end
|
||||||
* `base_url`: The base URL to access a user-uploaded file. Useful when you want to proxy the media files via another host.
|
* `base_url`: The base URL to access a user-uploaded file. Useful when you want to proxy the media files via another host.
|
||||||
* `proxy_remote`: If you're using a remote uploader, Pleroma will proxy media requests instead of redirecting to it.
|
* `proxy_remote`: If you're using a remote uploader, Pleroma will proxy media requests instead of redirecting to it.
|
||||||
* `proxy_opts`: Proxy options, see `Pleroma.ReverseProxy` documentation.
|
* `proxy_opts`: Proxy options, see `Pleroma.ReverseProxy` documentation.
|
||||||
|
* `filename_display_max_length`: Set max length of a filename to display. 0 = no limit. Default: 30.
|
||||||
|
|
||||||
!!! warning
|
!!! warning
|
||||||
`strip_exif` has been replaced by `Pleroma.Upload.Filter.Mogrify`.
|
`strip_exif` has been replaced by `Pleroma.Upload.Filter.Mogrify`.
|
||||||
|
|
|
@ -396,10 +396,12 @@ defmodule Pleroma.Web.CommonAPI.Utils do
|
||||||
def to_masto_date(_), do: ""
|
def to_masto_date(_), do: ""
|
||||||
|
|
||||||
defp shortname(name) do
|
defp shortname(name) do
|
||||||
if String.length(name) < 30 do
|
with max_length when max_length > 0 <-
|
||||||
name
|
Config.get([Pleroma.Upload, :filename_display_max_length], 30),
|
||||||
|
true <- String.length(name) > max_length do
|
||||||
|
String.slice(name, 0..max_length) <> "…"
|
||||||
else
|
else
|
||||||
String.slice(name, 0..30) <> "…"
|
_ -> name
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -14,18 +14,41 @@ defmodule Pleroma.Web.CommonAPI.UtilsTest do
|
||||||
|
|
||||||
@public_address "https://www.w3.org/ns/activitystreams#Public"
|
@public_address "https://www.w3.org/ns/activitystreams#Public"
|
||||||
|
|
||||||
test "it adds attachment links to a given text and attachment set" do
|
describe "add_attachments/2" do
|
||||||
name =
|
setup do
|
||||||
"Sakura%20Mana%20%E2%80%93%20Turned%20on%20by%20a%20Senior%20OL%20with%20a%20Temptating%20Tight%20Skirt-s%20Full%20Hipline%20and%20Panty%20Shot-%20Beautiful%20Thick%20Thighs-%20and%20Erotic%20Ass-%20-2015-%20--%20Oppaitime%208-28-2017%206-50-33%20PM.png"
|
name =
|
||||||
|
"Sakura Mana – Turned on by a Senior OL with a Temptating Tight Skirt-s Full Hipline and Panty Shot- Beautiful Thick Thighs- and Erotic Ass- -2015- -- Oppaitime 8-28-2017 6-50-33 PM.png"
|
||||||
|
|
||||||
attachment = %{
|
attachment = %{
|
||||||
"url" => [%{"href" => name}]
|
"url" => [%{"href" => URI.encode(name)}]
|
||||||
}
|
}
|
||||||
|
|
||||||
res = Utils.add_attachments("", [attachment])
|
%{name: name, attachment: attachment}
|
||||||
|
end
|
||||||
|
|
||||||
assert res ==
|
test "it adds attachment links to a given text and attachment set", %{
|
||||||
"<br><a href=\"#{name}\" class='attachment'>Sakura Mana – Turned on by a Se…</a>"
|
name: name,
|
||||||
|
attachment: attachment
|
||||||
|
} do
|
||||||
|
len = 10
|
||||||
|
clear_config([Pleroma.Upload, :filename_display_max_length], len)
|
||||||
|
|
||||||
|
expected =
|
||||||
|
"<br><a href=\"#{URI.encode(name)}\" class='attachment'>#{String.slice(name, 0..len)}…</a>"
|
||||||
|
|
||||||
|
assert Utils.add_attachments("", [attachment]) == expected
|
||||||
|
end
|
||||||
|
|
||||||
|
test "doesn't truncate file name if config for truncate is set to 0", %{
|
||||||
|
name: name,
|
||||||
|
attachment: attachment
|
||||||
|
} do
|
||||||
|
clear_config([Pleroma.Upload, :filename_display_max_length], 0)
|
||||||
|
|
||||||
|
expected = "<br><a href=\"#{URI.encode(name)}\" class='attachment'>#{name}</a>"
|
||||||
|
|
||||||
|
assert Utils.add_attachments("", [attachment]) == expected
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
describe "it confirms the password given is the current users password" do
|
describe "it confirms the password given is the current users password" do
|
||||||
|
|
Loading…
Reference in a new issue