mirrors/pleroma
1
0
Fork 0
mirror of https://git.pleroma.social/pleroma/pleroma.git synced 2025-01-21 14:38:10 +00:00
Code Issues Projects Releases Wiki Activity

Add guards around the increase/decrease counts for objects functions

Browse source 
Let's raise an exception if we pass bad data through
This commit is contained in:
Mark Felder 2024-08-29 16:48:30 -04:00
parent 625a5af933
commit 7003af859b
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/pleroma/object.ex
View file

@ -285,7 +285,7 @@ defmodule Pleroma.Object do
end
end
def increase_replies_count(ap_id) do
def increase_replies_count(ap_id) when is_binary(ap_id) do
Object
|> where([o], fragment("?->>'id' = ?::text", o.data, ^to_string(ap_id)))
|> update([o],
@ -312,7 +312,7 @@ defmodule Pleroma.Object do
defp poll_is_multiple?(_), do: false
def decrease_replies_count(ap_id) do
def decrease_replies_count(ap_id) when is_binary(ap_id) do
Object
|> where([o], fragment("?->>'id' = ?::text", o.data, ^to_string(ap_id)))
|> update([o],
@ -335,7 +335,7 @@ defmodule Pleroma.Object do
end
end
def increase_quotes_count(ap_id) do
def increase_quotes_count(ap_id) when is_binary(ap_id) do
Object
|> where([o], fragment("?->>'id' = ?::text", o.data, ^to_string(ap_id)))
|> update([o],
@ -358,7 +358,7 @@ defmodule Pleroma.Object do
end
end
def decrease_quotes_count(ap_id) do
def decrease_quotes_count(ap_id) when is_binary(ap_id) do
Object
|> where([o], fragment("?->>'id' = ?::text", o.data, ^to_string(ap_id)))
|> update([o],
@ -381,7 +381,8 @@ defmodule Pleroma.Object do
end
end
def increase_vote_count(ap_id, name, actor) do
def increase_vote_count(ap_id, name, actor)
when is_binary(ap_id) and is_binary(name) and is_binary(actor) do
with %Object{} = object <- Object.normalize(ap_id, fetch: false),
"Question" <- object.data["type"] do
key = if poll_is_multiple?(object), do: "anyOf", else: "oneOf"