updated tests

lib/pleroma/web/mastodon_api/controllers/mastodon_api_controller.ex

@@ -44,6 +44,7 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do
   alias Pleroma.Web.OAuth.Authorization
   alias Pleroma.Web.OAuth.Scopes
   alias Pleroma.Web.OAuth.Token
+  alias Pleroma.Web.RichMedia
   alias Pleroma.Web.TwitterAPI.TwitterAPI
 
   alias Pleroma.Web.ControllerHelper
@@ -1530,19 +1531,16 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIController do
     end
   end
 
-  def status_card(%{assigns: %{user: user}} = conn, %{"id" => status_id}) do
+  def status_card(%{assigns: %{user: user}} = conn, %{"id" => id}) do
-    with %Activity{} = activity <- Activity.get_by_id(status_id),
+    with %Activity{} = activity <- Activity.get_by_id(id),
          true <- Visibility.visible_for_user?(activity, user) do
-      data =
+      data = RichMedia.Helpers.fetch_data_for_activity(activity)
-        StatusView.render(
-          "card.json",
-          Pleroma.Web.RichMedia.Helpers.fetch_data_for_activity(activity)
-        )
 
-      json(conn, data)
+      conn
+      |> put_view(StatusView)
+      |> render("card.json", data)
     else
-      _e ->
+      _e -> {:error, :not_found}
-        json(conn, %{})
     end
   end
 

lib/pleroma/web/mastodon_api/views/status_view.ex

@@ -343,9 +343,7 @@ defmodule Pleroma.Web.MastodonAPI.StatusView do
     }
   end
 
-  def render("card.json", _) do
+  def render("card.json", _), do: nil
-    nil
-  end
 
   def render("attachment.json", %{attachment: attachment}) do
     [attachment_url | _] = attachment["url"]

test/web/mastodon_api/mastodon_api_controller_test.exs

@@ -2798,6 +2798,18 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do
       %{user: user}
     end
 
+    test "returns empty result when rich_media disabled", %{conn: conn, user: user} do
+      Config.put([:rich_media, :enabled], false)
+      {:ok, activity} = CommonAPI.post(user, %{"status" => "https://example.com/ogp"})
+
+      response =
+        conn
+        |> get("/api/v1/statuses/#{activity.id}/card")
+        |> json_response(200)
+
+      assert response == nil
+    end
+
     test "returns rich-media card", %{conn: conn, user: user} do
       {:ok, activity} = CommonAPI.post(user, %{"status" => "https://example.com/ogp"})
 
@@ -2869,22 +2881,23 @@ defmodule Pleroma.Web.MastodonAPI.MastodonAPIControllerTest do
              }
     end
 
-    test "returns empty object when id invalid", %{conn: conn} do
+    test "returns 404 response when id invalid", %{conn: conn} do
-      response =
+      assert %{"error" => "Record not found"} =
-        conn
+               conn
-        |> get("/api/v1/statuses/9eoozpwTul5mjSEDRI/card")
+               |> get("/api/v1/statuses/9eoozpwTul5mjSEDRI/card")
-        |> json_response(200)
+               |> json_response(404)
-
-      assert response == %{}
     end
 
-    test "returns empty object when id isn't FlakeID", %{conn: conn} do
+    test "returns 404 response when id isn't FlakeID", %{conn: conn} do
-      response =
+      assert %{"error" => "Record not found"} =
-        conn
+               conn
-        |> get("/api/v1/statuses/3ebbadd1-eb14-4e20-8118/card")
+               |> get("/api/v1/statuses/3ebbadd1-eb14-4e20-8118/card")
-        |> json_response(200)
+               |> json_response(404)
 
-      assert response == %{}
+      assert %{"error" => "Record not found"} =
+               conn
+               |> get("/api/v1/statuses/8118/card")
+               |> json_response(404)
     end
   end