mirrors/pleroma
1
0
Fork 0
mirror of https://git.pleroma.social/pleroma/pleroma.git synced 2024-12-23 16:40:29 +00:00
Code Issues Projects Releases Wiki Activity

no try block in checkout connection

Browse source
This commit is contained in:
Alexander Strizhakov 2020-03-03 17:44:04 +03:00
parent 3723d72365
commit 1ad34bfdba
No known key found for this signature in database
GPG key ID: 022896A53AEF1381
1 changed files with 9 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
lib/pleroma/http/adapter/gun.ex
View file

@ -86,7 +86,6 @@ defmodule Pleroma.HTTP.Adapter.Gun do
end end
defp try_to_get_conn(uri, opts) do defp try_to_get_conn(uri, opts) do
try do
case Connections.checkin(uri, :gun_connections) do case Connections.checkin(uri, :gun_connections) do
nil -> nil ->
Logger.debug( Logger.debug(
@ -103,40 +102,6 @@ defmodule Pleroma.HTTP.Adapter.Gun do
|> Keyword.put(:conn, conn) |> Keyword.put(:conn, conn)
|> Keyword.put(:close_conn, false) |> Keyword.put(:close_conn, false)
end end
rescue
error ->
Logger.warn(
"Gun connections pool checkin caused error #{Connections.compose_uri_log(uri)} #{
inspect(error)
}"
)
opts
catch
# TODO: here must be no timeouts
:exit, {:timeout, {_, operation, [_, {method, _}, _]}} ->
{:message_queue_len, messages_len} =
:gun_connections
|> Process.whereis()
|> Process.info(:message_queue_len)
Logger.warn(
"Gun connections pool checkin with timeout error for #{operation} #{method} #{
Connections.compose_uri_log(uri)
}. Messages length: #{messages_len}"
)
opts
:exit, error ->
Logger.warn(
"Gun pool checkin exited with error #{Connections.compose_uri_log(uri)} #{
inspect(error)
}"
)
opts
end
end end
@spec format_host(String.t()) :: charlist() @spec format_host(String.t()) :: charlist()