Commit graph

19 commits

Author SHA1 Message Date
Tim-Philipp Müller
7c890c0b91 fpsdisplaysink: fix NULL ref and error handling if no video sink is found
If no video sink is set and autovideosink is not available for some
reason, post a proper error message on the bus when failing to
change state, and don't try to gst_object_ref() NULL pointers. Fixes
generic/states unit test when distchecking.
2010-02-19 10:35:10 +00:00
Tim-Philipp Müller
ec0c87486f fpsdisplaysink: fix typo in property description 2010-01-06 01:57:13 +00:00
Thiago Santos
87bfdef683 fpsdisplaysink: Internal sink improvements
Does some general improvements with the internal sink handling.
1) Do not remove and re-add the ghostpad when changing
internal sink
2) Only instantiate the default sink when changing from NULL
to READY if there is no other available
3) Avoid changing the internal sink if not on NULL state

Fixes #598682
2009-12-17 20:39:24 -03:00
Thiago Santos
a4f30d5f3d fpsdisplaysink: Minor fixes
Downgrade a warning message to debug. Remove an
already fixed FIXME and add a note about (not-)using
fpsdisplaysink in autovideosink. Change the created
ghostpad to use the name "sink" as it is advertised in
the pad template.
2009-12-17 20:26:30 -03:00
Thiago Santos
d2dce72c60 fpsdisplaysink: fix setting sync on child bin
Use GST_IS_BIN instead of G_OBJECT_TYPE to check if the
internal sink is a bin. Using the later won't work when
the sink is not a bin directly (but inherits from one, like
autovideosink).

Fixes #604280
2009-12-16 18:36:15 -03:00
Philippe Normand
9c03149e7b fpsdisplaysink: check the sync property exists on embedded sink(s)
Follow-up on 4111d6321f, the video
sink(s) used by fpsdisplaysink might not have the sync property. So we
check its existence to avoid warning from g_object_set() at runtime.

Fixes #604280
2009-12-16 18:35:58 -03:00
Philippe Normand
4111d6321f fpsdisplaysink: expose video sink using a property
Exposes the internally used sink as video-sink property and
makes the default one to be autovideosink instead of
the hardcoded xvimagesink

Fixes #604280
2009-12-12 16:50:33 -03:00
Stefan Kost
ebc417f769 fpsdisplaysink: check query return result before using it 2009-07-20 16:42:43 +03:00
Jan Schmidt
90aa8eff4c fpsdisplaysink: Fix resetting of the sink in NULL
Reset the fpsdisplaysink in NULL by removing the textoverlay if we
created it.

Fixes: #582633
2009-05-16 01:26:55 +01:00
Tim-Philipp Müller
76535b0e1f docs: make fpsdisplaysink show up in the docs 2009-05-01 14:28:43 +01:00
Tim-Philipp Müller
9b1c7c94b4 fpsdisplaysink: move private struct into plugin struct and use Gst namespace 2009-05-01 14:28:43 +01:00
Tim-Philipp Müller
e101037589 fpsdisplaysink: rename plugin (not element) to debugutilsbad
Makes it easier to add further utils here without creating yet another plugin.
2009-05-01 14:28:42 +01:00
Tristan Matthews
8d4315ee5c fpsdisplaysink: init variable to NULL to avoid compiler warning
Fixes #580901.
2009-04-30 17:09:28 +01:00
Stefan Kost
1ae52725d9 fpsdisplay: code cleanup and plug overlay as needed
Pluggin the text-ovelay causes some slowdowns and might need a colorspace
converter. We now only check the text-overlay property whne goint to ready and
plug or unplug the text-overlay at that time. If the property changes during
playing, its not switched immediately.
2009-04-30 13:48:07 +03:00
Stefan Kost
95520973d0 fpsdisplay: more cleanups
Use normal gst-defines in PLUGIN_DEFINE. Shorten _start/stop method names.
More ideas. Move debug category-init down to plugin-init.
2009-04-23 14:38:20 +03:00
Stefan Kost
314f2e26c5 fpsdisplay: use a nicer font family 2009-04-23 14:38:19 +03:00
Stefan Kost
193f638b0a fpsdisplay: various cleanups, docs and comments
Remove unused base_init. Add basic doc blob. Reuse query object. Rename
variables for clarity. Add comments and ToDos.
2009-04-23 14:38:19 +03:00
Stefan Kost
790235e29f fpsdisplay: remove iface proxy
When we get bus messages for setting the xid, we have the real sink element
instance as message_src. No need to proxy the xoverlay iface therefore
(autovideosink does not do it either). Also we don't need to rewrite the
message src of all messages from that sink.
2009-04-23 14:38:19 +03:00
Stefan Kost
e01373662a fpsdisplaysink: add a initial port of a sink with fps display
This now works with a event probe. Needs some extra work.
2009-04-16 18:39:29 +03:00