Tim-Philipp Müller
6eb38f9b3e
giobasesink: we mustn't change the format of a query response
...
Not even in the DEFAULT case. That's bad 0.10 behaviour, no caller
is ever going to check the format of the response.
2014-04-27 00:49:01 +01:00
Tim-Philipp Müller
184fe464da
playbin: add nick for soft colorbalance play flag to fix gst-inspect
...
Fix gst-inspect-1.0 playbin criticals when printing the
flags, which was caused by a missing nick name for one
of the flags.
2014-04-27 00:26:14 +01:00
Tim-Philipp Müller
bcb8068e27
docs: remove outdated and pointless 'Last reviewed' lines from docs
...
They are very confusing for people, and more often than not
also just not very accurate. Seeing 'last reviewed: 2005' in
your docs is not very confidence-inspiring. Let's just remove
those comments.
2014-04-26 23:28:57 +01:00
Sebastian Dröge
e8d176c20c
giobasesink: Implement handling of the SEEKING query
2014-04-25 17:33:33 +02:00
Edward Hervey
74eb5fa995
audiodecoder: Plug caps leaks
...
We were returning in various places without unreffing the caps, and
we were also leaking (overwriting) the caps we got from _get_current_caps()
Spotted by Haakon Sporsheim in #gstreamer
2014-04-25 11:30:37 +02:00
Sebastian Dröge
2ed8f2e503
audioresample: Don't left-shift into the sign bit, instead use unsigned integers
2014-04-22 18:28:10 +02:00
Thiago Santos
03ba34f3a8
tag: exif: avoid adding empty strings
...
Fixes assertion with some jpeg files
2014-04-22 00:21:45 -03:00
Wim Taymans
1c5c49a94c
play: Improve pipeline states
...
First set the pipeline to the PAUSED state to check if we are dealing
with a live pipeline or not. Then move to the desired state.
If we don't do this, it is possible that we receive a BUFFERING message
before we know that the pipeline is live and we would set the pipeline
to PAUSED and deadlock.
2014-04-21 15:40:33 +02:00
Wim Taymans
c268eab145
play: Update buffering state for live pipelines
...
Update the buffering variable, even for live pipelines so that we don't
print \n for each buffering message.
2014-04-21 15:40:32 +02:00
Sebastian Dröge
9398207101
videoframe: Initialise GstVideoFrame to zeroes if mapping fails
...
This should allow for more meaningful errors. Dereferencing NULL
is more useful information than dereferencing a random address
happened to be on the stack.
2014-04-16 19:53:46 +02:00
Vincent Penquerc'h
22e12979ee
exiftag: catch buffer mapping failure
...
Might be what caused:
Coverity 1139734
2014-04-16 11:43:40 +01:00
Sebastian Dröge
13954ce3e5
audioresample: Fix memory leaks in test
2014-04-15 19:31:28 +02:00
Sebastian Dröge
122446476f
audioresample: Fix up indention
2014-04-15 19:31:28 +02:00
Sebastian Dröge
5826f79980
audioresample: Fix out of bounds memory accesses
2014-04-15 19:31:28 +02:00
Sebastian Dröge
3e2a693ca9
pango: Make static caps actually static to fix a memory leak
2014-04-15 13:57:08 +02:00
Sebastian Dröge
846a4a1038
videotestsrc: Fix memory leak in test
2014-04-15 13:54:45 +02:00
Sebastian Dröge
1822a6b31c
encodebin: Fix memory leak in test
2014-04-15 13:48:46 +02:00
Sebastian Dröge
dce51830f4
encoding-profile: Free preset name in finalize
2014-04-15 13:48:17 +02:00
Sebastian Dröge
02e613b6e3
oggmux: Clear Ogg streams before initing them
...
They might've been inited before, in which case we leak
memory when initing them again without clearing.
2014-04-15 13:39:39 +02:00
Sebastian Dröge
1266fd0046
audioconvert: Fix leaks in unit test
2014-04-15 13:03:34 +02:00
Sebastian Dröge
85c502d626
videoencoder/decoder: Fix memory leaks in the tests
2014-04-15 11:55:22 +02:00
Sebastian Dröge
16275f479f
audiodecoder: Actually allocate enough memory for 64 bits, not just 32 bits
...
Also fix a memory leak.
2014-04-15 11:54:06 +02:00
Sebastian Dröge
2378848240
audioencoder: Fix memory leaks in unit test
2014-04-15 11:43:41 +02:00
Sebastian Dröge
29758da255
rtp: Fix GBytes memory leak in test
2014-04-15 10:29:12 +02:00
Wim Taymans
f2ee068729
rtpbasedepay: add stats property
...
Add a stats property that holds a structure with all the current
values of the depayloader.
See https://bugzilla.gnome.org/show_bug.cgi?id=646577
2014-04-12 07:10:36 +02:00
Wim Taymans
314eee6dd1
rtpbasepayload: update docs
2014-04-12 06:43:24 +02:00
Wim Taymans
f0348d7005
rtpbasepayload: add current timestamp and seqnum offset to stats
...
Expose the current timestamp and seqnum offset in the stats
See https://bugzilla.gnome.org/show_bug.cgi?id=646577
2014-04-12 06:27:36 +02:00
Josep Torra
40c2d3c088
textrender: push segment event after caps event
...
Fixes warning "Sticky event misordering, got 'segment' before 'caps'".
2014-04-11 10:43:39 +02:00
Vincent Penquerc'h
1791799d71
oggstream: use G_GUINT64_CONSTANT instead of ll suffix
...
Thanks slomo for pointing out it's not standard.
2014-04-10 16:08:29 +01:00
Vincent Penquerc'h
43ce84e0f4
xvimage: remove dead code
...
matching_attr can not be NULL here, we've tested that away a few
lines beforehand.
Coverity 1139655
2014-04-10 15:55:57 +01:00
Vincent Penquerc'h
ba8220a9fd
videotestsrc: bail out on unsupported caps
...
This avoids using uninitialized data (and properly rejects caps).
Coverity 1139898
2014-04-10 15:51:05 +01:00
Vincent Penquerc'h
577ec29245
typefind: remove pointless checks for data being NULL
...
It was already checked in an early out, and as it's only
incremented for at most the size of the passed buffer, it
can only become NULL in an address wraparound.
While there, don't cast away const on a pointer.
Coverity 1139845
2014-04-10 15:16:03 +01:00
Vincent Penquerc'h
9e99a1ca41
decodebin: consider "no demuxer" case to not have dynamic pads
...
This fixes a possible NULL dereference.
Coverity 1195146
2014-04-10 13:51:18 +01:00
Vincent Penquerc'h
ea176f3865
encodebin: guard against gst_pad_get_peer returning NULL
...
If it does, the pad may be leaked if it's a request pad, though.
Coverity 1139799
2014-04-10 13:28:30 +01:00
Vincent Penquerc'h
1afa3040b8
encodebin: guard against pathological NULL dereference
...
Coverity 1139798
2014-04-10 13:26:42 +01:00
Vincent Penquerc'h
f588d14cdc
audioresample: reject 0 denominator when creating resampler
...
Coverity 1195140, 1195139, 1195138
2014-04-10 12:35:03 +01:00
Vincent Penquerc'h
3d1fdf8dd8
video-overlay-composition: guard against NULL pointer dereference on error
...
If gst_video_overlay_rectangle_apply_global_alpha is called with
a rectangle with unsuitable alpha, expanding the alpha plane will
fail, and thus lead to dereferencing a NULL src pointer. It's not
certain this will happen in practice, as the function is static
and callers might ensure suitable alpha before calling, but there
is no apparent explicit such check.
Add prologue asserts for proper alpha to explicitely prevent this.
Coverity 1139707
2014-04-10 12:35:03 +01:00
Vincent Penquerc'h
4a401adf38
videometa: fix texture_type memcpy size
...
Coverity 1139589, 1139588
2014-04-10 12:35:03 +01:00
Vincent Penquerc'h
505c803765
sdpmessage: fix multi statement macros
...
Wasn't playing nice with an if statement below.
Coverity 1139767
2014-04-10 12:35:03 +01:00
Vincent Penquerc'h
dda777803c
audiocdsrc: guard aginst overflow
...
An audio CD may contain about a tenth of the samples 32 bit can
represent, so it doesn't seem likely this will be hit in practice.
Coverity 1139805
2014-04-10 12:35:03 +01:00
Tim-Philipp Müller
374e756eee
pbutils: descriptions: default to systemstream=false for partial video/mpeg caps
...
Assume systemstream=false for video/mpeg caps where that field
is missing.
2014-04-10 12:30:50 +01:00
Vincent Penquerc'h
7618699ffd
audiobasesink: avoid possible sample count overflow
...
At 48 kHz, 2<<31 samples is reached before 13 hours so it
sounds plausible this would be hit.
Coverity 1139800, 1139801
2014-04-10 11:06:00 +01:00
Vincent Penquerc'h
e7c261ff31
theoraenc: fix comparison to unset timestamp
...
Also rejects negative timestamps that aren't GST_CLOCK_TIME_NONE.
Coverity 1139797
2014-04-10 11:06:00 +01:00
Vincent Penquerc'h
55f98974a8
oggstream: fix a few left shifts operations on 32 bits cast to 64 bits
...
This should not cause any actual bug since Theora and Daala have
a maximum shift of 31, and a packet duration of 2^31 seems very
implausible. But it fixes:
Coverity 1139804, 1139803, 1139802
2014-04-10 11:06:00 +01:00
Vincent Penquerc'h
2c07c54b8a
oggstream: remove NULL test after dereference
...
And add NULLness asserts at top of function. The only call
to this passes local variable pointers, so non NULL.
Coverity 206375
2014-04-10 11:06:00 +01:00
Vincent Penquerc'h
1b0f13ebf2
oggmux: test for failure to return tag
...
It should really not happen unless the tag list it corrupt,
but the API returns a failure code so we may as well use it.
Coverity 1139595
2014-04-10 11:06:00 +01:00
Vincent Penquerc'h
54f38edd15
oggdemux: do not dereference NULL pad in warning message
...
Coverity 1197695
2014-04-10 11:06:00 +01:00
Sebastian Dröge
8c7cbeed5b
video-event: Update the running times in the force-keyunit events from the pad offsets
2014-04-10 09:18:05 +02:00
Sebastian Dröge
2c2e286c38
decodebin: In adaptive streaming mode, only have a fixed buffer limit for the non-buffering multiqueue
2014-04-09 16:06:06 +02:00
Wim Taymans
4a81605d02
sdp: guard against address parse errors.
2014-04-08 15:59:47 +02:00