mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-25 11:11:08 +00:00
Code Issues 1 Projects Releases Wiki Activity

audiobasesink: avoid possible sample count overflow

Browse source 
At 48 kHz, 2<<31 samples is reached before 13 hours so it
sounds plausible this would be hit.

Coverity 1139800, 1139801
This commit is contained in:
Vincent Penquerc'h 2014-04-10 10:57:53 +01:00
parent e7c261ff31
commit 7618699ffd
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst-libs/gst/audio/gstaudiobasesink.c
View file

@ -1126,8 +1126,8 @@ wrong_state:
static guint64
gst_audio_base_sink_get_offset (GstAudioBaseSink * sink)
{
guint64 sample;
gint writeseg, segdone, sps;
guint64 sample, sps;
gint writeseg, segdone;
gint diff;
/* assume we can append to the previous sample */
@ -1540,7 +1540,7 @@ gst_audio_base_sink_get_alignment (GstAudioBaseSink * sink,
gint64 sample_diff;
gint64 max_sample_diff;
gint segdone = g_atomic_int_get (&ringbuf->segdone) - ringbuf->segbase;
gint64 samples_done = segdone * ringbuf->samples_per_seg;
gint64 samples_done = segdone * (gint64) ringbuf->samples_per_seg;
gint64 headroom = sample_offset - samples_done;
gboolean allow_align = TRUE;
gboolean discont = FALSE;