Tim-Philipp Müller
17c107d4e4
v4l2: minor fix for closing the fd
...
The fd returned by open() could theoretically be 0 as well.
Coverity CID 1211823.
2014-05-05 12:07:25 +01:00
Olivier Crête
985897d8d9
rtpaux/rtprtx: Make tests non-racy
...
Fix the raciness by iterating on a condition instead of using the gmainloop.
Don't use the EOS as the target, otherwise the retransmission of the last
packets are lost. Also count the retranmissions requests that are dropped.
Check the condition before blocking on the GCond
https://bugzilla.gnome.org/show_bug.cgi?id=728501
2014-05-04 22:37:26 -04:00
Olivier Crête
b2a52035bf
rtprtxreceive: Wait until timeout to clear association requests
...
If two streams request a retranmission for the same SSRC, ignore the second
one if the first oen is less than one second old, otherwise time out the first
one and ignore the second.
2014-05-04 22:36:59 -04:00
Olivier Crête
0742a5a257
rtpmux: Always let upstream chose the ssrc if it wishes
2014-05-04 19:11:03 -04:00
Mark Nauwelaerts
6c584bc833
rtpjitterbuffer: avoid stall by corrupted seqnum accounting
2014-05-04 13:38:26 +02:00
Olivier Crête
39bbccdf79
pulsedevicemonitor: Index are per facility, not global
...
So need to keep the type of device in the device object
2014-05-04 01:14:39 -04:00
Olivier Crête
6c8e42944a
pulsedevicemonitor: pa_subscription_event_t are enums, not flags
...
Coverity 1195132
2014-05-04 01:14:39 -04:00
Nicolas Dufresne
717bbbbe70
v4l2devicemonitor: Port to use GstV4l2Iterator
...
https://bugzilla.gnome.org/show_bug.cgi?id=727925
2014-05-03 23:11:35 -04:00
Nicolas Dufresne
aa74871080
v4l2: Use single pass iterator for M2M probe
...
Instead of having each M2M class do their own probing, use the
GstV4l2Iterator and probe all devices in a single pass.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
2014-05-03 23:11:35 -04:00
Nicolas Dufresne
726fc3b524
v4l2: Add a common device enumerator
...
This will allow removing code duplication (hence bugs duplication).
https://bugzilla.gnome.org/show_bug.cgi?id=727925
2014-05-03 23:11:35 -04:00
Nicolas Dufresne
f7d34bd237
v4l2videodec: Simplify sub-instanciation mechanism
...
Simplify sub-instanciation by defining an absract type and using subtype
class and instance init callback. This also fixes a bug where the template
pads get initialized too late.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
2014-05-03 23:11:34 -04:00
Nicolas Dufresne
e06c9f7fce
v4l2: Cleanup plugin registration
...
There is no plan to introduce special sources for jpeg, te v4l2src works fine
for this.
https://bugzilla.gnome.org/show_bug.cgi?id=727925
2014-05-03 23:11:34 -04:00
Olivier Crête
2e54d38dd0
rtpsession: Keep local conflicting addresses in the session
...
As we now replace the local RTPSource on a conflict, it's no longer possible
to keep local conflicts in the RTPSource, so they instead need to be kept
in the RTPSession.
Also fix the rtpcollision test to generate multiple collisions instead of
one by change the address, as otherwise we detected that it was a single one.
2014-05-03 18:30:20 -04:00
Sebastian Dröge
9ea8b03946
Back to development
2014-05-03 20:48:30 +02:00
Sebastian Dröge
1d4404d883
Release 1.3.1
2014-05-03 18:02:23 +02:00
Sebastian Dröge
0ead08b26a
Update .po files
2014-05-03 18:02:01 +02:00
Sebastian Dröge
afd14aa57d
po: Update translations
2014-05-03 17:22:45 +02:00
Sebastian Dröge
3b5deb2b45
shapewipe: Send initial events after setting the elements to PLAYING
...
Otherwise we send them too early, and setting the elements to PLAYING
afterwards will drop all the events again.
2014-05-03 11:43:21 +02:00
Sebastian Dröge
cf8176392b
Automatic update of common submodule
...
From bcb1518 to 211fa5f
2014-05-03 10:15:03 +02:00
Sebastian Dröge
859c751a5d
imagefreeze: Set segment position to the stop position of the buffer
2014-05-02 17:14:29 +02:00
Sebastian Dröge
4282d75597
imagefreeze: Properly report errors before stopping the srcpad task
2014-05-02 17:14:29 +02:00
Sebastian Dröge
4933394d35
imagefreeze: Error out if we have no caps yet
2014-05-02 17:14:29 +02:00
Vincent Penquerc'h
218294b9f3
wavparse: avoid dividing by a 0 blockalign
...
This can be 0. In that case, do not try to cut off the last few
bytes from the last buffer.
Coverity 1146971
2014-05-02 14:49:27 +01:00
Vincent Penquerc'h
590e20cbc9
matroskamux: do not use uinitialized clut on error
...
If we're missing part of the clut, do not try to use it. It seems
very likely the break was meant to break out of the switch rather
than from the loop.
Coverity 1139878
2014-05-02 14:25:01 +01:00
Vincent Penquerc'h
d917c94037
flxdec: fix integer overflow
...
Coverity 1139859
2014-05-02 14:18:08 +01:00
Vincent Penquerc'h
60ba2d7aee
rtpqdmdepay: remove pointless check
...
Besides, the pointer was dereferenced earlier anyway.
Coverity 1139853
2014-05-02 14:09:02 +01:00
Vincent Penquerc'h
a846e84349
rtspsrc: remove duplicate test
...
item was dereference previously.
While there, reorder some test for faster early out.
Coverity 1139844
2014-05-02 14:06:25 +01:00
Vincent Penquerc'h
a6e7948711
vp8enc: guard against NULL pointer dereference
...
Coverity 1139838
2014-05-02 14:02:52 +01:00
Vincent Penquerc'h
d2f66f5394
flacdec: fix theoretical integer overflow
...
This code isn't actually used at the moment, unsure if I should
just remove it or not...
Coverity 1139811
2014-05-02 13:59:07 +01:00
Vincent Penquerc'h
5c22bcf6e9
matroska: blindly fix writing variable length negative values
...
Spotted while fixing something else in the area.
Nothing calls this with a negative value.
2014-05-02 13:33:02 +01:00
Vincent Penquerc'h
5b9fa4e63a
matroska: do not lose the top bits when writing a > 32 bit value
...
Coverity 1139806
2014-05-02 13:29:33 +01:00
Vincent Penquerc'h
10663decd9
videoflip: add missing break in switch
...
Coverity 1139755
2014-05-02 12:10:26 +01:00
Vincent Penquerc'h
a0bc24558e
matroska: do not try to call gst_pad_query_default on a NULL pad
...
gst_matroska_parse_query can be called explicitely with a NULL pad.
If we reach this point with a NULL pad, fail the query.
Coverity 1139715
2014-05-02 11:39:39 +01:00
Vincent Penquerc'h
3915884017
matroska: do not return GST_FLOW_OK if we did not get a buffer
...
Coverity 1139714 (which will likely come back in another guise,
as the _read_init call can have a failing _map)
2014-05-02 11:28:01 +01:00
Vincent Penquerc'h
f5a9f5e221
matroska: catch failure to map buffer
...
Avoids dereferencing NULL.
Coverity 1139712
2014-05-02 11:20:33 +01:00
Vincent Penquerc'h
94720fd3a1
avimux: refuse caps with invalid framerate
...
Coverity 1139701
2014-05-02 10:53:00 +01:00
Vincent Penquerc'h
1be86ebb2a
qtmux: handle 0 size packets without dividing by 0
...
Coverity 1139691
2014-05-02 10:21:09 +01:00
Vincent Penquerc'h
b692539b55
qtdemux: guard against invalid frame size to avoid division by 0
...
Coverity 1139690
2014-05-02 09:49:32 +01:00
Vincent Penquerc'h
436c8c11a0
qtdemux: trivial typo fix
2014-05-02 09:49:17 +01:00
Vincent Penquerc'h
74c93b8fc7
speexdec: remove dead code
...
fpp can never equal 0 here, or the loop would not execute at all.
Zero fpp was possible before as the loop condition was allowing
it specifically, but no more.
Coverity 1139681
2014-05-02 09:45:07 +01:00
Vincent Penquerc'h
81d2e9333d
oss4: remove dead mixer code
...
This was partly removed in the port to 0.11. If still needed,
it's still there in the history.
Coverity 1139687
2014-05-02 09:41:19 +01:00
Vincent Penquerc'h
1062992b4a
oss4: fix a missing unlock and a return-only-when-assertions-enabled
...
Spotted on the side while looking at another issue.
2014-05-02 09:33:51 +01:00
Nicolas Dufresne
7ff514fec6
v4l2: Correctly map RGB32 format
...
In v4l2 specification, RGB32 has the alpha, or pading, first, not last.
See http://linuxtv.org/downloads/v4l-dvb-apis/packed-rgb.html .
https://bugzilla.gnome.org/show_bug.cgi?id=540941
2014-04-30 15:36:07 -04:00
Vincent Penquerc'h
14ceb5727c
flacdec: remove dead code
...
For 8 bit width, we always have depth==gdepth==width==8.
Coverity 1139678
2014-04-30 18:06:40 +01:00
Vincent Penquerc'h
0253db6d36
mpegaudioparse: remove dead code
...
A stricer check is already done earlier, and integer overflows
do not seem possible here.
Coverity 1139675
2014-04-30 17:48:53 +01:00
Vincent Penquerc'h
a55b8e9c00
rtpvrawpay: guard against pathological "no space" condition
...
Even if one woul hope one pixel can fit in a MTU, ensure we do not
overwrite a buffer if this is not the case.
Spotted while looking at Coverity 1208786
2014-04-30 14:50:44 +01:00
Vincent Penquerc'h
dfa2df1c88
rtpjpegdepay: sanity check for NULL qtable
...
Can happen (at least in crafted stream)
Coverity 1208778
2014-04-30 11:52:10 +01:00
Tim-Philipp Müller
b1473491cf
wavparse: pass on tags from upstream if there are any
...
Don't just ignore upstream tags from e.g. an ID3 tag before
the .wav data, pass them on downstream.
https://bugzilla.gnome.org/show_bug.cgi?id=729223
2014-04-30 01:08:41 +01:00
Wim Taymans
eba3bba524
rtpjitterbuffer: optimize timer update
...
When we are not doing retransmission, we just need to find the current
seqnum so we can stop when we found it.
2014-04-29 16:26:53 +02:00
Wim Taymans
b2c9646acb
rtpjitterbuffer: small optimizations
...
Small optimizations where we can.
Add some more debug.
2014-04-29 16:21:44 +02:00