Jochen Henneberg
a0e870263e
qt: Fixup for dummy textures
...
* Initialize dummy texture Ids
* Ensure YUV->RGB matrix set for dummy textures
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6581 >
2024-04-09 13:51:27 +01:00
Sebastian Dröge
17db91c7c1
rtpbin: Don't re-use a variable for a completely different purpose temporarily
...
During RTP-Info synchronization, clock_base was temporarily switched
from the actual clock-base to the base RTP time and then back some lines
later.
Instead directly work with the base RTP time. The comment about using a
signed variable for convenience doesn't make any sense because all
calculations done with the value are unsigned.
Similarly, rtp_clock_base was overridden with the rtp_delta when
calculating it, which was fine because it is not used anymore
afterwards. Instead, introduce a new variable `rtp_delta` to make this
calculation clearer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
72c6cac8db
rtpbin: Convert clock-base to extended RTP timestamp correctly
...
It's not in the same period as the current RTP base time but always in
the very first period. This avoids using it again at a much later time.
The code in question is only triggered with rtcp-sync=rtp-info.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
bba6f097b1
rtpjitterbuffer: Use an extended RTP timestamp for the clock-base
...
It is compared to other extended RTP timestamps all over rtpjitterbuffer
and since 4df3da3bab
the initial extended RTP timestamp is not equal
anymore to the plain RTP time.
Continue passing a non-extended RTP timestamp via the `sync` signal for
backwards compatibility. It will always be a timestamp inside the first
extended timestamp period anyway.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6575 >
2024-04-08 13:22:24 +00:00
Sebastian Dröge
38ec8f1299
rtphdrext-ntp: Fix typo of the RFC number in the element metadata
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3417
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6537 >
2024-04-08 12:21:35 +00:00
Seungha Yang
f5500906ce
dwrite: Fix crash on device update
...
Selected blend mode should not be cleared on device update
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6521 >
2024-04-08 11:38:43 +00:00
Robert Guziolowski
50bd2f2109
qml6glsink: fix destruction of underlying texture
...
One should not directly delete the QRhiTexture instance.
Instead it should be marked as to be deleted once QRhi::endFrame()
is called (see: https://doc.qt.io/qt-6/qrhiresource.html#deleteLater )
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3443
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6506 >
2024-04-08 10:45:26 +00:00
Daniel Morin
b96072b810
ci/fluster: Revert results for visl
...
- Make test pass without h264parse AU boundary detection changes
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
9289fb5ce4
h264parser: maintain API changes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
59230efdd9
Revert "h264parse: test - AU align with SEI between frame slices"
...
This reverts commit 533f814fd9
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
83038c3daf
Revert "h264parse: Improved AU boundary detection"
...
This reverts commit 49f200cb54
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
115b4792b5
Revert "h264parse: Remove dead code"
...
This reverts commit 141cd38715
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
9bbf246cc4
Revert "h264parse: Fix AU collection"
...
This reverts commit 495390f63a
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
5453976f03
Revert "h264parse: Remove un-needed check on SPS state"
...
This reverts commit 73dedf9a51
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
ee7026925f
Revert "h264parse: use AUD to detect first VCL NAL"
...
This reverts commit 90a3b63eed
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Daniel Morin
c259674ed5
Revert "h264parse: correct NAL mode backlog processing"
...
This reverts commit b2098849dc
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6562 >
2024-04-07 17:40:51 +00:00
Jan Schmidt
b3d6a14737
rtpjitterbuffer: Don't use estimated_dts to do default skew adjustment
...
When the buffer DTS is estimated based on arrival time at the
jitterbuffer (rather than provided on the incoming buffer itself),
it shouldn't be used for skew adjustment. The typical case is
packets being deinterleaved from a tunnelled TCP/HTTP RTSP stream,
and the arrival times at the jitter buffer are not well enough
correlated to usefully do skew adjustments.
This restores the original intended behaviour for the 'estimated dts'
path, that was broken years ago during other jitterbuffer refactoring.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6561 >
2024-04-07 16:24:22 +01:00
Sebastian Dröge
4b6cbca300
flac: Add wrap file and add fallback for it to the flac plugin
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6560 >
2024-04-07 13:57:40 +00:00
Tim Blechmann
88dd91cb30
v4l2: enforce a pixel aspect ratio of 1/1 if no data are available
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6559 >
2024-04-07 14:17:19 +01:00
Philipp Zabel
993d8b89bc
v4l2: allocator: Fix unref log/trace on memory release
...
Use gst_object_unref() instead of g_object_unref() in
gst_v4l2_allocator_release(), so refcounting log and
tracer get to know about this unref.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6556 >
2024-04-06 23:41:52 +00:00
Edward Hervey
4ea7d5ae64
videoparsers: Demote CC warning message
...
Another warning message which isn't fatal and therefore should just be a DEBUG
line.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6555 >
2024-04-06 19:08:33 +00:00
Elliot Chen
7aa75e590a
v4l2: fix error in calculating padding bottom for tile format
...
This is a regression while porting to arbitrary tile dimensions
introduced in !3424 .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6554 >
2024-04-06 19:10:25 +01:00
Elizabeth Figura
e1b82701df
atdec: Handle channel counts greater than 2
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6546 >
2024-04-05 10:14:59 +00:00
Elizabeth Figura
b7a4b9e1ab
atdec: Use gst_audio_decoder_set_output_caps() directly
...
The code currently sets the same caps in two different ways, and neither of them correctly handle the channel mask.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6546 >
2024-04-05 10:14:59 +00:00
Seungha Yang
ce4f0d5746
avviddec: Fix AVPacket leak
...
av_packet_unref() does not release allocated memory.
av_packet_free() is the correct free function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6545 >
2024-04-05 10:28:22 +01:00
Sebastian Dröge
984b1f413a
wavpackparse: Use an unsigned integer for the block size calculations
...
It's never negative.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00
Sebastian Dröge
078ef786d2
wavpackparse: Fix potential integer overflow on ID_ODD_SIZE blocks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00
Sebastian Dröge
99bdbd78ca
wavpackparse: Explicitly handle ID_WVX_NEW_BITSTREAM
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00
Sebastian Dröge
ef72daea70
typefind: Handle WavPack block sizes > 131072
...
These are valid nowadays.
Also handle ID_ODD_SIZE and ID_WVX_NEW_BITSTREAM. The parser already
handles the former but not the latter.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3440
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6541 >
2024-04-04 17:33:48 +01:00
Robert Mader
81a800ab9e
jpegparse: turn some bus warnings into object ones
...
For some cameras `gst_jpeg_parse_app0()` fails on a invalid segment.
While this is likely a driver or firmware bug that should be addressed
accordingly, it's not fatal and likely does not deserve a bus message on
every frame, flooding journals.
Turn down the volume of the warnings by turning them into object
warnings. If we conclude that in some cases we'd still want bus
warnings, they can be done more fine-grained in the
`gst_jpeg_parse_appX()` functions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6539 >
2024-04-04 15:14:06 +01:00
Sebastian Dröge
22315a435d
pbutils: descriptions: Don't warn on MPEG-1 audio caps without layer field
...
While this is not ideal and won't give too accurate codec descriptions,
it is what tsdemux produces.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6538 >
2024-04-04 12:45:54 +01:00
Chris Spencer
f85d1efafb
vkbufferpool: correct usage flags type
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6528 >
2024-04-03 19:20:23 +00:00
Víctor Manuel Jáquez Leal
d2aa3829b8
vkh265dec: add missing VPS parameter
...
and fix coded size
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6534 >
2024-04-03 18:26:05 +00:00
Víctor Manuel Jáquez Leal
56ac5e9041
vkh26xdec: implement close() vmethod
...
Since a validation layer error is signaled at EOS because it's required to wait
for the last frame to be processed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6534 >
2024-04-03 18:26:05 +00:00
Víctor Manuel Jáquez Leal
9301f64d72
vkh26xdec: remove unused variables
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6534 >
2024-04-03 18:26:05 +00:00
Víctor Manuel Jáquez Leal
85a78f56dc
vkh265dec: fix resource info structure when layered DPB
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6534 >
2024-04-03 18:26:05 +00:00
Víctor Manuel Jáquez Leal
6f7d62eb73
msdk: sink context reference
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Víctor Manuel Jáquez Leal
db387f1b13
gtk: sink reference of internal wayland pool
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Víctor Manuel Jáquez Leal
124ceabafe
wayland: sink reference to internal pool
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Víctor Manuel Jáquez Leal
e1fa26e16f
dash: sink references of all MDP objects
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Víctor Manuel Jáquez Leal
1d7b7b04d1
va: sink reference at instantiation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Víctor Manuel Jáquez Leal
4a51579cb2
vulkan: sink references at instantiation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6527 >
2024-04-03 16:34:26 +00:00
Xavier Claessens
4836312360
clocksync: Proxy allocation queries
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6525 >
2024-04-03 15:06:40 +00:00
eri
648a1cb03a
play: Update video_snapshot
to support playbin3
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6526 >
2024-04-03 13:48:13 +00:00
Guillaume Desmottes
5fcc15514f
examples: set perfect-timestamp=true on opusenc
...
Fix audio streaming on Chrome, see https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1524
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6523 >
2024-04-03 11:35:08 +00:00
Matthew Waters
d556c02aa8
glcaopengllayer: NULL some fields when freed
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6524 >
2024-04-03 10:28:08 +01:00
Matthew Waters
6f0ad951c3
glwindow/cocoa: keep a window reference across an async callback
...
Esnures that the window is alive when the callback is fired.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6524 >
2024-04-03 10:28:08 +01:00
Matthew Waters
651ccd0175
glimagesink: avoid a possible critical on shutdown
...
It is possible that the close callback can be called after glimagesink
is changing state to NULL. Protect against that by taking the glimagesink
lock and some NULL checking.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6524 >
2024-04-03 10:28:08 +01:00
Matthew Waters
0bf962dbdf
glimagesink: unref the potential last ref outside of the glimagesink lock
...
Avoids a deadlock between the state change removing the last ref and
the destructer calling the window's on_close handler and trying to
take the glimagesink lock.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6524 >
2024-04-03 10:28:08 +01:00
Matthew Waters
e5b4f09172
glbufferpool: protect release_buffer from multiple concurrent access
...
If two different threads attempt to release buffers at the same time, then the
keep-alive-slightly-longer GQueue may become corrupted. Guard against that with
some locking.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6524 >
2024-04-03 10:28:08 +01:00