mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-19 00:01:23 +00:00
Code Issues 1 Projects Releases Wiki Activity
403 commits 44 branches 1509 tags 624 MiB
Commit graph

374 commits

Author SHA1 Message Date
Sebastian Dröge
be31e7273b omx: Fix some memory leaks and suboptimal locking 2013-01-14 10:36:57 +01:00
Sebastian Dröge
bcb181bd2d omxvideoenc: Don't forget to unmap frame in error cases 2013-01-14 10:36:50 +01:00
Sebastian Dröge
25d5c55764 omxvideoenc: Fix copying of the video frames to the OMX buffers 2013-01-14 10:36:44 +01:00
Sebastian Dröge
2fd8d72c50 omxvideodec: Fix copying of the video frames from the OMX buffers 2013-01-14 10:36:38 +01:00
Sebastian Dröge
a42f27547d omx: Implement new approach for locking that should solve all deadlocks on RPi 
No mutex is locked while calling any OpenMAX functions anymore
and everything from the OpenMAX callbacks is inserted into a message
queue and handled from outside the callbacks.

Also there's only a single mutex and condition variable per component
now for handling anything from OpenMAX callbacks and a single mutex
for keeping our component/port state sane.
 2013-01-14 10:36:32 +01:00
Sebastian Dröge
1bf69c8f69 omxvideodec: Set the OMX buffer nFilledLength field properly 2012-12-20 19:30:38 +01:00
Sebastian Dröge
29aabc223e omxrecmutex: Fix another race condition when two threads are trying to lock for recursion at the same time 2012-12-20 18:48:21 +01:00
Sebastian Dröge
500410226f omxrecmutex: Fix yet another race condition that resulted in deadlocks 2012-12-20 18:16:43 +01:00
Sebastian Dröge
e026926951 omx: Fix another race condition in the recursive mutex 
Between lock() and begin_recursion() it was possible for another thread to
try to do a recursive_lock(). This would block because the mutex was already
locked(), but not ready for recursive locking yet. unlock() would never
happen in the original thread because it was waiting for the other thread
to finish first.

Happened on the Raspberry Pi.
 2012-12-20 17:46:36 +01:00
Sebastian Dröge
1c7fcf832e omxrecmutex: Fix a small race condition when unlocking a non-recursive lock 2012-12-20 14:45:18 +01:00
Sebastian Dröge
1d01c0ebf0 omx: Fix ununsed variable compiler warning 2012-12-20 12:30:05 +01:00
Sebastian Dröge
83b4c1d892 omx: No need to start the srcpad task in ::start() already 
It will be started properly after the caps are set.
 2012-12-20 12:27:47 +01:00
Sebastian Dröge
4ef40839a2 omxvideodec: OMX_ErrorNoMore is no error and just means we ended iteration 2012-12-20 12:23:49 +01:00
Sebastian Dröge
f90a6ed9e9 omx: Improve debug output 2012-12-20 12:20:31 +01:00
Sebastian Dröge
f6f078e847 omxvideodec: Don't forget to free a GList 2012-12-20 12:02:30 +01:00
Sebastian Dröge
20280afa1f omxvideodec: Map OMX_COLOR_FormatYUV420PackedPlanar to I420 too 
This is used on the Raspberry Pi.
 2012-12-20 11:56:29 +01:00
Sebastian Dröge
a80e2b9053 omxvideodec: During negotiation of the output format make sure we use the correct OpenMAX format 2012-12-20 11:55:36 +01:00
Sebastian Dröge
07e0d674a0 omxvideodec: If negotiation fails this could also mean that the component can't do it at this point yet 2012-12-20 11:42:17 +01:00
Sebastian Dröge
7354baec66 omxvideodec: Improve format negotiation a bit 
Don't leak caps and make sure to fixate caps.
 2012-12-20 11:40:28 +01:00
Sebastian Dröge
a70a71b9a5 omx: Also initialize nStep field of the OMX structures 2012-12-19 13:05:28 +01:00
Sebastian Dröge
73dc5bb199 omx: Initialize struct version with the OMX version we compiled with 2012-12-19 13:03:37 +01:00
Sebastian Dröge
9c464924a5 omxvideodec: Extract data from the input buffer, not the codec data 2012-12-19 12:44:31 +01:00
Sebastian Dröge
b93d86abbe omx: Use has_suffix() instead of has_prefix() for the Broadcom hack 2012-12-19 12:19:12 +01:00
Sebastian Dröge
5105daba1a omx: Add hack to load and initialize libbcm_host.so 
Needed on the Raspberry Pi. Patch based on a patch by
George Kiagiadakis <george.kiagiadakis@collabora.com>
 2012-12-19 11:31:51 +01:00
Sebastian Dröge
7c53535026 configure: Add configure option to pack OpenMAX structures 
This is required to set to 4 for the Raspberry Pi for example.
 2012-12-19 11:26:36 +01:00
George Kiagiadakis
147dd89e21 omx: Initialize structures to version 1.1.2 2012-12-19 11:26:36 +01:00
Sebastian Dröge
31bf1c8bd6 config: Add raspberry-pi configuration in a different directory 2012-12-19 11:26:36 +01:00
George Kiagiadakis
78035a4848 raspberry: Add a gstomx.conf for the Raspberry Pi 2012-12-19 11:07:25 +01:00
Sebastian Dröge
3244201b49 omx: Fix some compilation errors caused by circular includes 2012-12-12 17:45:39 +00:00
Sebastian Dröge
7fa4616598 omx: Fix refcount problem with frames being dropped because of decoder bugs 2012-11-12 15:14:09 +01:00
Sebastian Dröge
2481ceb8c4 omx: Update to new GLib thread API 2012-11-12 11:29:48 +01:00
Sebastian Dröge
bced70525a omx: Use open/close vfuncs 2012-10-22 14:34:53 +02:00
Sebastian Dröge
9d0e582484 omx: Handle video meta correctly 2012-10-22 14:28:04 +02:00
Sebastian Dröge
5fdb490f1a omx: Port to video base classes from -base 2012-10-22 14:20:41 +02:00
Tim-Philipp Müller
49ba281e8b omx: gst_element_class_set_details_simple() -> set_static_metadata() 2012-10-17 17:57:43 +01:00
George Kiagiadakis
f93feb2644 omx: fix debug statement 2012-09-03 12:37:02 +03:00
George Kiagiadakis
8a669ee308 omx: use recursive_lock inside set_last_error(), since this function may be called from an event handler 2012-09-03 12:36:53 +03:00
Tim-Philipp Müller
3f963f87fb omx: fix plugin name for new GST_PLUGIN_DEFINE API 2012-08-03 19:32:13 +01:00
Sebastian Dröge
48163f60f0 omx: Update for allocation query API changes 2012-07-10 09:57:09 +02:00
Sebastian Dröge
e84fee6488 omx: Fix compilation after gst_pad_start_task() API changes 2012-06-20 11:09:13 +01:00
George Kiagiadakis
7b3dac67af omx: Fix spelling mistake found by lintian: s/Seperate/Separate/ 2012-05-08 16:16:00 +03:00
George Kiagiadakis
158775f497 Implement a new custom recursive mutex type and fix locking in callbacks so that in-context calls are allowed. 
According to the OMX specification, implementations are allowed to call
callbacks in the context of their function calls. However, our callbacks
take locks and this causes deadlocks if the unerlying OMX implementation
uses this kind of in-context calls.

A solution to the problem would be a recursive mutex. However, a normal
recursive mutex does not fix the problem because it is not guaranteed
that the callbacks are called from the same thread. What we see in Broadcom's
implementation for example is:

- OMX_Foo is called
- OMX_Foo waits on a condition
- A callback is executed in a different thread
- When the callback returns, its calling function
  signals the condition that OMX_Foo waits on
- OMX_Foo wakes up and returns

The solution I came up with here is to take a second lock inside the callback,
but only if recursion is expected to happen. Therefore, all calls to OMX
functions are guarded by calls to gst_omx_rec_mutex_begin_recursion() / _end_recursion(),
which effectively tells the mutex that at this point we want to allow calls
to _recursive_lock() to succeed, although we are still holding the master lock.
 2012-05-07 17:01:16 +03:00
George Kiagiadakis
5c15caef8e omx: Add hack to disable setting roles to components. 
Conflicts:

	omx/gstomx.c
 2012-05-03 13:21:18 +02:00
George Kiagiadakis
7ca067be28 omxvideodec: Implement no-empty-eos-buffer hack, as in omxvideoenc. 
Conflicts:

	omx/gstomxvideodec.c
 2012-05-03 12:24:43 +02:00
George Kiagiadakis
4aa3fa8a0d omxvideodec: Fix coding style in the drain-may-not-return hack code 2012-05-03 12:20:05 +02:00
Arun Raghavan
34a83c184e omx: Fix trivial debug print bug 2012-04-26 09:42:54 +05:30
Arun Raghavan
9e4cddee7e omxvideodec: Add hack for Ducati components not returning from drain 
This happens on the Galaxy Nexus, and causes the pipeline to hang waiting
endlessly for a drain. The hack replaces the wait with a wait + 500ms timeout.
 2012-04-26 09:42:52 +05:30
Arun Raghavan
036cd16756 omx: Fix deadlock between ending a flush and the event handler 
gst_omx_port_set_flushing() calls OMX_FillThisBuffer at the end of a flush
without releasing the port lock, and this can cause a deadlock with the
EventHandler. This patches fixes this by dropping the lock for the duration of
the fill buffer call.
 2012-04-26 09:42:50 +05:30
Sebastian Dröge
d99fa5e3b3 omx: Update video encoder/decoder base classes from gst-plugins-bad 2012-04-24 15:41:38 +02:00
Sebastian Dröge
3523724970 omxaudioenc: Use gst_buffer_extract() to copy the input buffer data to the OpenMAX buffer 2012-04-16 08:35:33 +02:00
Alessandro Decina
e6e3f05948 Fix relative/absolute path glitch 
Signed-off-by: Reynaldo H. Verdejo Pinochet <reynaldo@collabora.com>
 2012-04-13 17:16:42 -04:00
Olivier Crête
ff2603a727 Port to Gst 0.11 2012-04-13 12:16:34 -04:00
Reynaldo H. Verdejo Pinochet
766dc7c541 Enable building with Android's buildsystem 
This change adds prelimary buildsystem hooks to
build gst-omx with the Android buildsystem. Like
the rest of GStreamer's Android hooks, the process
relies on the availability of androgenizer. A tool
developed by Collabora to automatically generate
Android.mk files from within the auto* setup.

Androgenizer is currently available at:

http://cgit.collabora.com/git/user/derek/androgenizer.git/
 2012-01-19 14:08:12 -03:00
Sebastian Dröge
4fd185be6f basevideocodec: Don't use G_TYPE_REGISTER_BOXED() yet 
This would require GLib 2.26.
 2011-12-14 21:15:29 +01:00
Jonas Larsson
887d43c290 omxaudioenc: Add hack for encoder components that don't allow empty EOS buffers 2011-12-14 10:09:34 +01:00
Jonas Larsson
2cab5b5db5 omxvideoenc: Fix deadlock when using the EOS hack 2011-12-14 10:07:29 +01:00
Sebastian Dröge
3db75118dd omxvideoenc: Remove workaround for basevideocodec bug 2011-12-12 14:26:48 +01:00
Sebastian Dröge
4c225f9cdd omxvideodec: Remove workaround for basevideocodec bug 2011-12-12 14:26:34 +01:00
Matej Knopp
30005be2e5 basevideo: Make GstVideoFrame a reference counted boxed object 
...and also clear all existing frames when resetting the decoder or encoder.
 2011-12-12 14:24:47 +01:00
Sebastian Dröge
9e6665e8f8 omx: Add hack for encoder components that don't allow empty EOS buffers 2011-12-09 12:24:01 +01:00
Dake Gu
b8b64ac746 omxaacenc: Generate and set codec_data on the caps for raw AAC 2011-12-09 10:21:47 +01:00
Alessandro Decina
247e410df0 basevideoencoder: handle failures in start() and stop() 2011-12-08 11:56:58 +01:00
Vincent Penquerc'h
f27ca88ecc basevideoenc: do not try to calculate latency from an unknown framerate 
It'll divide by zero, and latency is unknown for an unknown framerate.

Fixes an assert in the schroenc test.

https://bugzilla.gnome.org/show_bug.cgi?id=657419
 2011-12-08 11:55:03 +01:00
Sebastian Dröge
8e662fffb0 basevideoencoder: Only make the header buffer metadata writable, not the buffer 2011-12-08 11:50:49 +01:00
Sebastian Dröge
9ea6e7d2f2 basevideoencoder: Fix handling of force-keyunit events 2011-12-08 10:18:36 +01:00
Sebastian Dröge
766f5bd161 omxaudioenc: Don't forward EOS events immediately but let all other events be handled by the base class 
Previously this logic was inversed, which did not make any sense at all.
 2011-12-06 13:28:41 +01:00
Sebastian Dröge
064e4c628c omxaudioenc: Use correct timestamp, duration and filled length for the EOS buffers 2011-12-06 12:47:25 +01:00
Sebastian Dröge
05ad3343bf omxvideodec: Use correct timestamp, duration and filled length for the EOS buffers 2011-12-06 12:47:12 +01:00
Sebastian Dröge
bd60f141e9 omxvideoenc: Use correct timestamp, duration and filled length for the EOS buffers 2011-12-06 12:46:51 +01:00
Sebastian Dröge
0cb32a4ebd omx: Improve debugging of buffer handling 2011-12-05 13:18:09 +01:00
Sebastian Dröge
781e61d569 omxvideoenc: Drop EOS events in ::finish() 
The event will be forwarded downstream from the srcpad
loop function after the last buffer was generated by the
component. Forwarding it after ::finish() will use the
sinkpad streaming thread and does not guarantee that
the encoder is completely drained.
 2011-12-05 08:12:48 +01:00
Sebastian Dröge
b4e632cefe omxvideodec: Properly drop frames due to QoS 
Instead of finishing them they should be passed to drop(), which
will then send QoS messages.
 2011-12-01 16:20:36 +01:00
Jonas Larsson
9c4b926c41 omxh264enc: Add support for resending headers after a forced-keyframe 2011-11-29 12:21:32 +01:00
Sebastian Dröge
458199abfb basevideoencoder: Pass the all-headers field of the force-key-unit event to the subclass 2011-11-29 12:20:09 +01:00
Sebastian Dröge
3cb4bbe97e basevideoencoder: Implement full support for the new force-key-unit event 
Including support for the running-time and count fields.
 2011-11-29 12:20:09 +01:00
Sebastian Dröge
11b2dea82d basevideoencoder: Use new force-keyunit event API from gst-plugins-base 2011-11-29 12:20:09 +01:00
Sebastian Dröge
77db7e5780 basevideoencoder: Adjusting padding is not required for -bad libraries 2011-11-29 12:20:09 +01:00
Sebastian Dröge
db756fb190 basevideoencoder: Move some fields to the private part of the instance struct 2011-11-29 12:20:09 +01:00
Sebastian Dröge
050700d561 basevideoencoder: Make headers metadata writable before pushing downstream 
The timestamp, duration, etc of the headers has to be changed.
 2011-11-29 12:20:09 +01:00
Sebastian Dröge
1f3f8c9dc5 basevideoencoder: Push the downstream force-keyframe event after the next keyframe 
Even if the corresponding GstVideoFrame doesn't have the is_sync_point
flag set.
 2011-11-29 12:20:09 +01:00
Sebastian Dröge
38b3f1ac00 basevideoencoder: Don't push an upstream force-keyunit event downstream 2011-11-29 12:20:09 +01:00
Jonas Larsson
36d2a21aa3 basevideoencoder: Add initial support for the all-headers field of the force-keyframe event 
See bug #607742.
 2011-11-29 12:20:09 +01:00
Tim-Philipp Müller
b42f17240a basevideodecoder: some more debug logging 2011-11-28 16:17:19 +00:00
Tim-Philipp Müller
f40c93efb0 basevideodecoder: add API to drop a frame and post a QoS message on the bus 
https://bugzilla.gnome.org/show_bug.cgi?id=640017

API: gst_base_video_decoder_drop_frame()
 2011-11-28 16:17:19 +00:00
Tim-Philipp Müller
f27800d598 docs: fix comment in gst_base_video_decoder_get_max_decode_time() docs 2011-11-28 16:17:19 +00:00
Tim-Philipp Müller
f1bbb0f8a4 basevideodecoder: fix weird event list handling 
Get rid of weird code that copies a list manually, taking
ownership of the elements and then frees the old list. Instead,
just take over the old list entirely. (If the intent was to
reverse the list, one could use g_list_reverse() instead).

Then, push events in the list out from last to first (since they
were prepended as they came in) instead of just pushing out the
last in the list and leaking the others.
 2011-11-28 16:17:19 +00:00
Sebastian Dröge
217ac7b3be omxaudioenc: Use audio base classes from gst-plugins-base instead of having our own copies 2011-11-25 11:31:58 +01:00
Sebastian Dröge
9917fbe4c5 omxaudioenc: First set ports to flushing before waiting for the srcpad streaming thread to finish 2011-11-18 10:00:31 -08:00
Sebastian Dröge
be4e1e184e omxvideoenc: First set ports to flushing before waiting for the srcpad streaming thread to finish 2011-11-18 09:59:43 -08:00
Sebastian Dröge
1c0396de0e omxvideodec: First set ports to flushing before waiting for the srcpad streaming thread to finish 2011-11-18 09:58:58 -08:00
Sebastian Dröge
47d66cadfa omx: Only disabling of a port is like flushing, enabling is like unflushing 2011-11-17 14:38:54 -08:00
Sebastian Dröge
c144ebd054 omx: Enabling/disabling a port is also like flushing 
The component returns all buffers to us and shouldn't get any
new buffers passed anymore.
 2011-11-17 14:11:51 -08:00
Sebastian Dröge
8a5fbb876c omxaudioenc: Signal the drain GCond even if downstream returned an error 2011-11-17 11:29:39 -08:00
Sebastian Dröge
1ba8ec3d37 omxvideoenc: Signal the drain GCond even if downstream returned an error 2011-11-17 11:29:39 -08:00
Sebastian Dröge
1371dafae4 omxvideodec: Signal the drain GCond even if downstream returned an error 2011-11-17 11:29:18 -08:00
Sebastian Dröge
cc50d894af basevideoencoder: Only call ::reset once in READY->PAUSED 2011-11-17 10:34:19 -08:00
Sebastian Dröge
7df465bfb3 omxaudioenc: Shutdown component in PAUSED->READY and deallocate buffers 2011-11-17 10:19:47 -08:00
Sebastian Dröge
2408e0d33a omxvideoenc: Shutdown component in PAUSED->READY and deallocate buffers 2011-11-17 10:19:47 -08:00
Sebastian Dröge
30610a746e omxvideodec: Shutdown component in PAUSED->READY and deallocate buffers 2011-11-17 10:19:47 -08:00
Sebastian Dröge
879349ba11 omxvideoenc: Set force_keyframe to FALSE after handling it 
There's no reason why the base class should forward the event
further downstream if we already handled it and will insert a
keyframe.
 2011-11-16 12:02:08 -08:00