mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2025-01-08 16:35:40 +00:00
omxvideoenc: Drop EOS events in ::finish()
The event will be forwarded downstream from the srcpad loop function after the last buffer was generated by the component. Forwarding it after ::finish() will use the sinkpad streaming thread and does not guarantee that the encoder is completely drained.
This commit is contained in:
parent
b4e632cefe
commit
781e61d569
1 changed files with 3 additions and 3 deletions
|
@ -1505,7 +1505,7 @@ buffer_fill_error:
|
|||
}
|
||||
}
|
||||
|
||||
static gboolean
|
||||
static GstFlowReturn
|
||||
gst_omx_video_enc_finish (GstBaseVideoEncoder * encoder)
|
||||
{
|
||||
GstOMXVideoEnc *self;
|
||||
|
@ -1519,7 +1519,7 @@ gst_omx_video_enc_finish (GstBaseVideoEncoder * encoder)
|
|||
/* Don't send EOS buffer twice, this doesn't work */
|
||||
if (self->eos) {
|
||||
GST_DEBUG_OBJECT (self, "Component is already EOS");
|
||||
return TRUE;
|
||||
return GST_BASE_VIDEO_ENCODER_FLOW_DROPPED;
|
||||
}
|
||||
self->eos = TRUE;
|
||||
|
||||
|
@ -1542,7 +1542,7 @@ gst_omx_video_enc_finish (GstBaseVideoEncoder * encoder)
|
|||
|
||||
GST_BASE_VIDEO_CODEC_STREAM_LOCK (self);
|
||||
|
||||
return TRUE;
|
||||
return GST_BASE_VIDEO_ENCODER_FLOW_DROPPED;
|
||||
}
|
||||
|
||||
static GstFlowReturn
|
||||
|
|
Loading…
Reference in a new issue