mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2025-02-08 23:42:28 +00:00
158775f497
According to the OMX specification, implementations are allowed to call callbacks in the context of their function calls. However, our callbacks take locks and this causes deadlocks if the unerlying OMX implementation uses this kind of in-context calls. A solution to the problem would be a recursive mutex. However, a normal recursive mutex does not fix the problem because it is not guaranteed that the callbacks are called from the same thread. What we see in Broadcom's implementation for example is: - OMX_Foo is called - OMX_Foo waits on a condition - A callback is executed in a different thread - When the callback returns, its calling function signals the condition that OMX_Foo waits on - OMX_Foo wakes up and returns The solution I came up with here is to take a second lock inside the callback, but only if recursion is expected to happen. Therefore, all calls to OMX functions are guarded by calls to gst_omx_rec_mutex_begin_recursion() / _end_recursion(), which effectively tells the mutex that at this point we want to allow calls to _recursive_lock() to succeed, although we are still holding the master lock. |
||
|---|---|---|
| .. | ||
| openmax | ||
| gstbasevideocodec.c | ||
| gstbasevideocodec.h | ||
| gstbasevideodecoder.c | ||
| gstbasevideodecoder.h | ||
| gstbasevideoencoder.c | ||
| gstbasevideoencoder.h | ||
| gstbasevideoutils.c | ||
| gstbasevideoutils.h | ||
| gstomx.c | ||
| gstomx.conf | ||
| gstomx.h | ||
| gstomxaacenc.c | ||
| gstomxaacenc.h | ||
| gstomxaudioenc.c | ||
| gstomxaudioenc.h | ||
| gstomxh263dec.c | ||
| gstomxh263dec.h | ||
| gstomxh263enc.c | ||
| gstomxh263enc.h | ||
| gstomxh264dec.c | ||
| gstomxh264dec.h | ||
| gstomxh264enc.c | ||
| gstomxh264enc.h | ||
| gstomxmpeg4videodec.c | ||
| gstomxmpeg4videodec.h | ||
| gstomxmpeg4videoenc.c | ||
| gstomxmpeg4videoenc.h | ||
| gstomxrecmutex.c | ||
| gstomxrecmutex.h | ||
| gstomxvideodec.c | ||
| gstomxvideodec.h | ||
| gstomxvideoenc.c | ||
| gstomxvideoenc.h | ||
| gstomxwmvdec.c | ||
| gstomxwmvdec.h | ||
| Makefile.am | ||