Sebastian Dröge
23d998a1db
Slightly improve code making use of element factories retrieved from an element
...
We can use `is_some_and(...)` instead of `map_or(false, ...)`.
Also in a few places the factory was retrieved multiple times, one time
with unwrapping and another time with handling the `None` case
correctly. Instead of unwrapping, move code to handle the `None` case.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1630 >
2024-06-19 13:03:37 +00:00
Arun Raghavan
8f96509f03
aws: s3: Enable tests again
...
We lost the environment variable checks during the addition of the
putobjectsink tests, which caused failures on MR branches.
It would be nicer to use some other mechanism to validate the tests can
run, so we don't count on only the environmnent, but for now this will
have to do.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1629 >
2024-06-18 11:58:43 -04:00
Sebastian Dröge
59bada0a9f
deny: Add another override for hermit-abi
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1622 >
2024-06-18 10:27:27 +03:00
Sebastian Dröge
743ab29ba8
Update Cargo.lock and MSRV to 1.71
...
cea608-types requires that now because it updated the env_logger
dependency. As a result, we can also update it here now.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1622 >
2024-06-18 10:27:27 +03:00
Sebastian Dröge
970d1c9afd
Update Cargo.lock
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1622 >
2024-06-18 10:27:27 +03:00
Sebastian Dröge
5aedcab32f
Revert "aws: s3: Re-enable tests"
...
This reverts commit b4b56eb282
.
The tests are still failing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1624 >
2024-06-18 08:50:07 +03:00
Sebastian Dröge
4677948a82
rtp: av1pay: Derive Default trait for the state instead of manual implementation
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1624 >
2024-06-18 08:07:24 +03:00
Sebastian Dröge
d357a63bf9
rtp: av1pay: Correctly use N flag for marking keyframes
...
The "first packet of a coded video sequence" means that this should be
the first packet of a keyframe that comes together with a sequence
header, not the first packet of a new frame.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/558
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1624 >
2024-06-18 08:06:59 +03:00
Sebastian Dröge
5cd9e34265
rtp: av1pay: Correctly skip over ignored OBUs
...
The reader is already after the header at this point so only the OBU
content has to be skipped.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1624 >
2024-06-18 08:06:59 +03:00
Sebastian Dröge
bbe38b9599
rtp: av1: Drop padding OBUs too like Chrome does
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1624 >
2024-06-18 08:06:59 +03:00
Arun Raghavan
b4b56eb282
aws: s3: Re-enable tests
...
These seem to have stopped working due to bad/rotated creds. Should work
fine now.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1623 >
2024-06-17 06:08:18 -04:00
Sebastian Dröge
343680ffea
rtp: av1depay: Don't return an error if parsing a packet fails
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1612 >
2024-06-14 13:13:21 +00:00
Sebastian Dröge
477855789d
rtp: av1depay: Also log warnings on errors
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1612 >
2024-06-14 13:13:21 +00:00
Sebastian Dröge
93c9821cba
rtp: av1depay: Drop unusable packets as early as possible
...
Otherwise they would pile up until a discontinuity or until we can
actually output something.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1612 >
2024-06-14 13:13:21 +00:00
Sebastian Dröge
0ca4a3778a
rtp: av1depay: Parse internal size fields of OBUs and handle them
...
They're not recommended by the spec to include in the RTP packets but it
is valid to include them. Pion is including them.
When parsing the size fields also make sure to only take that much of a
payload unit and to skip any trailing data (which should not exist in
the first place).
Pion is also currently storing multiple OBUs in a single payload unit,
which is not allowed by the spec but can be easily handled with this
code now.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/560
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1612 >
2024-06-14 13:13:21 +00:00
Sebastian Dröge
69c3c2ae46
Fix various new clippy 1.79 warnings
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1620 >
2024-06-14 08:33:49 +03:00
Sanchayan Maity
cd47bf2f04
threadshare: Handle end of stream for sources
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1581 >
2024-06-12 18:15:31 +05:30
Nirbheek Chauhan
6538803cf6
meson: Handle features needed only by examples separately
...
Currently we incorrectly require gtk4 to build the fallbackswitch, livesync,
togglerecord plugins when the examples option is allowed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
4c9ed330c8
meson: Actually build plugin examples
...
This broke in 8b5a398135
.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
7f16fd7736
meson: Fix gtk4 plugin build on linux
...
dmabuf feature needs the wayland feature too.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
3e4330686f
meson: Only enable gtk4 examples when gtk4 is found
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
3b6832724f
meson: Only enable the gtk4 plugin when deps are found
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
968e0fddb9
meson: Fix plugin requirement checking and add logging
...
We were silently skipping plugins that didn't find a required feature,
even if the plugin option was enabled.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
39f466f2c6
meson: Fix typo in gstreamer-gl dep fetching
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Nirbheek Chauhan
4eed615871
meson: Make gstreamer-gl dependency optional
...
Minimal systems like docker containers may not have GL
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1604 >
2024-06-10 18:50:05 +00:00
Sebastian Dröge
3d4d785a2a
webrtchttp: Fix race condition when unlocking
...
It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.
To solve this remember if cancellation should happen and reset this
later.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1602 >
2024-06-10 07:38:29 +00:00
Sebastian Dröge
51f6d3986f
aws: Fix race condition when unlocking
...
It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.
To solve this remember if unlock() was called and reset this in
unlock_stop().
Also implement actual unlocking in s3hlssink.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1602 >
2024-06-10 07:38:29 +00:00
Sebastian Dröge
00aaecad07
quinn: Fix race condition when unlocking
...
It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.
To solve this remember if unlock() was called and reset this in
unlock_stop().
Also actually implement unlock() / unlock_stop() for the sink, and don't
cancel in stop() as unlock() / unlock_stop() would've been called before
that already.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1602 >
2024-06-10 07:38:29 +00:00
Sebastian Dröge
c42040fbb8
spotifyaudiosrc: Fix race condition when unlocking
...
It would be possible that there is no cancellable yet when unlock() is
called, then the setup task is started and it would simply run and being
waited on instead of not being run at all.
To solve this, remember if unlock() was called and reset this in
unlock_stop().
Also make sure to not keep the abort handle locked while waiting,
otherwise cancellation would never actually work.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1602 >
2024-06-10 07:38:29 +00:00
Sebastian Dröge
9945b702b8
reqwesthttpsrc: Fix race condition when unlocking
...
It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.
To solve this remember if unlock() was called and reset this in
unlock_stop().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1602 >
2024-06-10 07:38:29 +00:00
Sebastian Dröge
f68655b5e2
Update for gst::BufferList
API changes
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1610 >
2024-06-08 09:58:10 +03:00
Sebastian Dröge
aaccc6e7f1
Update Cargo.lock
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1610 >
2024-06-07 20:23:13 +03:00
Jordan Petridis
f30cb2b56c
video/gtk4: Add --features to the flatpak example
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1608 >
2024-06-07 10:54:05 +00:00
Mathieu Duponchelle
7cec628c43
transcriberbin: make sure to always record pad property changes
...
When the pad isn't parented yet we should still record user choices,
either in our settings or in our state.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1593 >
2024-06-06 15:42:21 +00:00
Mathieu Duponchelle
0e85973e94
transcriberbin: fix regression with > 1 translation languages
...
By making sure to expose uniquely named pads on the inner transcription
bins.
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/552
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1593 >
2024-06-06 15:42:21 +00:00
Sebastian Dröge
30252a1b2e
ndi: Add support for loading NDI SDK v6
...
The library name and environment variable name have changed but the ABI
is completely compatible.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1607 >
2024-06-06 14:51:09 +00:00
Matthew Waters
1e964233c6
ci: run tests with RUST_BACKTRACE=1
...
Produces backtraces which would allow some initial debugging on hard to
find issues.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1606 >
2024-06-06 14:02:55 +00:00
Angelo Verlain
c9ac553cfe
gtk4: update flatpak integration code
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1600 >
2024-06-06 13:08:19 +00:00
Matthew Waters
260b04a1cf
rtpbin2: protoct against adding with overflow
...
If jitter is really bad, then this calculation may overflow. Protect
against that.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1605 >
2024-06-06 11:43:26 +00:00
Sebastian Dröge
ba70bb1154
deny: Add override for older tungstenite
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1603 >
2024-06-06 10:34:12 +00:00
Sebastian Dröge
85c38107cf
webrtc: Update to async-tungstenite 0.26
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1603 >
2024-06-06 10:34:12 +00:00
Sanchayan Maity
8171a00943
net/quinn: Fix pad template naming typo
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1601 >
2024-06-05 13:44:40 +05:30
Tim-Philipp Müller
ab2f5e3d8d
rtp: ac3: add some unit tests
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1586 >
2024-06-01 12:43:27 +00:00
Tim-Philipp Müller
2b68920f82
rtp: tests: add possibility to make input live
...
.. for payloaders that behave differently with live
and non-live inputs (e.g. audio payloaders which by
default will pick different aggregation modes based
on that.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1586 >
2024-06-01 12:43:27 +00:00
Tim-Philipp Müller
6597ec84eb
rtp: tests: add possibility to check duration of depayloaded buffers
...
.. and clarify an expect panic message.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1586 >
2024-06-01 12:43:27 +00:00
Tim-Philipp Müller
6b628485c5
rtp: Add AC-3 RTP payloader/depayloader
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1586 >
2024-06-01 12:43:27 +00:00
Tamas Levai
802ff6a67c
net/quinn: Make QUIC role configurable
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1575 >
2024-05-31 23:20:38 +02:00
Francisco Javier Velázquez-García
8fc652f208
webrtcsink: Refactor value retrieval to avoid lock poisoning
...
When setting an incorrect property name in settings,
start_stream_discovery_if_needed would panic because it attempts to
unwrap a poisoned lock for settings.
This refactor avoids that situation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1594 >
2024-05-31 08:10:23 +00:00
Francisco Javier Velázquez-García
568e8533fa
webrtcsink: Fix typo in property name for av1enc
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1594 >
2024-05-31 08:10:23 +00:00
Sebastian Dröge
91bc39367b
deny: Add another override for librespot for nix
2024-05-31 10:06:14 +03:00