mirrors/gst-plugins-rs
mirrors/gst-plugins-rs
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs.git synced 2024-12-04 17:26:31 +00:00
Code Issues Projects Releases Wiki Activity
3097 commits 14 branches 101 tags 48 MiB
Commit graph

3097 commits

This branch
This branch
All branches
Author SHA1 Message Date
François Laignel
0c55ac9e31 webrtcsink: don't panic with bitrate handling unsupported encoders 
When an encoder was not supported by the `VideoEncoder` `bitrate` accessors, an
`unimplemented` panic would occur which would poison `state` & `settings`
`Mutex`s resulting in other threads panicking, notably entering `end_session()`,
which lead to many failures in `BinImplExt::parent_remove_element()` until a
segmentation fault ended the process. This was observed using `vaapivp9enc`.

This commit logs a warning if an encoder isn't supported by the `bitrate`
accessors and silently by-passes `bitrate`-related operations when unsupported.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1556>
 2024-04-29 11:48:41 +03:00
Simonas Kazlauskas
18a51c360d mp4/fmp4: support flac inside the iso (f)mp4 container 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1556>
 2024-04-29 11:48:33 +03:00
Taruntej Kanakamalla
20380e699e webrtcsrc: change the producer-id type for request-encoded-filter 
With https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1477
the producer id used while emitting the request-encoded-filter
can be a None if the msid of the webrtcbin's pad is None.
This might not affect the signal handler written in C but
can panic in an existing Rust application with signal
handler which can only handle valid String type as its param
for the producer id.

So change the param type to Option<String> in the signal builder
for request-encoded-fiter signal

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1556>
 2024-04-29 11:48:25 +03:00
Tim-Philipp Müller
e8b0748faa ci: tag linter and sanity check jobs as a "placeholder" jobs 
They hardly use any resources and almost finish immediately.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1536>
 2024-04-09 19:12:53 +01:00
Tim-Philipp Müller
00362c5be4 ci: make sure version Cargo.toml matches version in meson.build 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1536>
 2024-04-09 19:12:45 +01:00
Sebastian Dröge
519371240d meson: Update version to 0.12.4 2024-04-08 16:43:35 +03:00
Sebastian Dröge
a4b28dbccc Update CHANGELOG.md for 0.12.4 2024-04-08 16:37:49 +03:00
Sebastian Dröge
efb1a47a38 Update Cargo.lock 2024-04-08 16:25:27 +03:00
Sebastian Dröge
b312642c45 Update version to 0.12.4 2024-04-08 16:25:16 +03:00
Sebastian Dröge
41dea52cfa Update Cargo.lock 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:25:03 +03:00
Sebastian Dröge
7a3f76704d deny: Update 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:20:17 +03:00
Sebastian Dröge
2718fe1169 fmp4mux: Require gstreamer-pbutils 1.20 for the examples 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:20:09 +03:00
Sebastian Dröge
58ae74467a webrtchttp: Update to reqwest 0.12 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:19:45 +03:00
Sebastian Dröge
0b0fc7f7d4 onvifmetadataparse: Reset state in PAUSED->READY after pad deactivation 
Otherwise the clock id will simply be overridden instead of unscheduling
it, and if the streaming thread of the source pad currently waits on it
then it will wait potentially for a very long time and deactivating the
pad would wait for that to happen.

Also unschedule the clock id on `Drop` of the state to be one the safe
side and not simply forget about it.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:19:21 +03:00
Taruntej Kanakamalla
98dce3c49c net/webrtc: fix inconsistencies in documentation of object names 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:19:08 +03:00
Guillaume Desmottes
3c71247ac9 web: webrtcsink: improve panic message on unexpected caps during discovery 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:18:51 +03:00
Guillaume Desmottes
762d4a4437 webrtc: webrtcsink: set perfect-timestamp=true on audio encoders 
Chrome audio decoder doesn't cope well with not perfect ts, generating
noises in the audio.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:18:43 +03:00
Sebastian Dröge
e374de1d69 fmp4: Update to dash-mpd 0.16 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:18:37 +03:00
Sebastian Dröge
57a4d2fb01 ci: Ignore env_logger for cargo-outdated 
It requires Rust >= 1.71.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:18:28 +03:00
Martin Nordholts
0faa74b74d rtpgccbwe: Add increasing_duration and counter to existing gst::log!() 
Add `self.increasing_duration` and `self.increasing_counter`
to logs to provide more details of why `overuse_filter()`
determines overuse of network.

To get access to the latest values of those fields we need
to move down the log call. But that is fine, since no other
logged data is modified between the old and new location of
`gst::log!()`.

We do not bother logging `self.last_overuse_estimate` since
that is simply the previously logged value of `estimate`. We
must put the log call before we write the latest value to it
though, in case we want to log it in the future.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:18:03 +03:00
François Laignel
d0461b190f aws: improve error message logs 
The `Display` and `Debug` trait for the AWS error messages are not very useful.

- `Display` only prints the high level error, e.g.: "service error".
- `Debug` prints all the fields in the error stack, resulting in hard to read
  messages with redudant or unnecessary information. E.g.:

> ServiceError(ServiceError { source: BadRequestException(BadRequestException {
> message: Some("1 validation error detected: Value 'test' at 'languageCode'
> failed to satisfy constraint: Member must satisfy enum value set: [ar-AE,
> zh-HK, en-US, ar-SA, zh-CN, fi-FI, pl-PL, no-NO, nl-NL, pt-PT, es-ES, th-TH,
> de-DE, it-IT, fr-FR, ko-KR, hi-IN, en-AU, pt-BR, sv-SE, ja-JP, ca-ES, es-US,
> fr-CA, en-GB]"), meta: ErrorMetadata { code: Some("BadRequestException"),
> message: Some("1 validation error detected: Value 'test' at 'languageCode'
> failed to satisfy constraint: Member must satisfy enum value set: [ar-AE,
> zh-HK, en-US, ar-SA, zh-CN, fi-FI, pl-PL, no-NO, nl-NL, pt-PT, es-ES, th-TH,
> de-DE, it-IT, fr-FR, ko-KR, hi-IN, en-AU, pt-BR, sv-SE, ja-JP, ca-ES, es-US,
> fr-CA, en-GB]"), extras: Some({"aws_request_id": "1b8bbafd-5b71-4ba5-8676-28432381e6a9"}) } }),
> raw: Response { status: StatusCode(400), headers: Headers { headers:
> {"x-amzn-requestid": HeaderValue { _private: H0("1b8bbafd-5b71-4ba5-8676-28432381e6a9") },
> "x-amzn-errortype": HeaderValue { _private:
> H0("BadRequestException:http://internal.amazon.com/coral/com.amazonaws.transcribe.streaming/") },
> "date": HeaderValue { _private: H0("Tue, 26 Mar 2024 17:41:31 GMT") },
> "content-type": HeaderValue { _private: H0("application/x-amz-json-1.1") },
> "content-length": HeaderValue { _private: H0("315") }} }, body: SdkBody {
> inner: Once(Some(b"{\"Message\":\"1 validation error detected: Value 'test'
> at 'languageCode' failed to satisfy constraint: Member must satisfy enum value
> set: [ar-AE, zh-HK, en-US, ar-SA, zh-CN, fi-FI, pl-PL, no-NO, nl-NL, pt-PT,
> es-ES, th-TH, de-DE, it-IT, fr-FR, ko-KR, hi-IN, en-AU, pt-BR, sv-SE, ja-JP,
> ca-ES, es-US, fr-CA, en-GB]\"}")), retryable: true }, extensions: Extensions {
> extensions_02x: Extensions, extensions_1x: Extensions } } })

This commit adopts the most informative and concise solution I could come up
with to log AWS errors. With the above error case, this results in:

> service error: Error { code: "BadRequestException", message: "1 validation
> error detected: Value 'test' at 'languageCode' failed to satisfy constraint:
> Member must satisfy enum value set: [ar-AE, zh-HK, en-US, ar-SA, zh-CN, fi-FI,
> pl-PL, no-NO, nl-NL, pt-PT, es-ES, th-TH, de-DE, it-IT, fr-FR, ko-KR, hi-IN,
> en-AU, pt-BR, sv-SE, ja-JP, ca-ES, es-US, fr-CA, en-GB]",
> aws_request_id: "a40a32a8-7b0b-4228-a348-f8502087a9f0" }

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:17:56 +03:00
François Laignel
85ce07d184 aws: use fixed BehaviorVersion 
Quoting [`BehaviorVersion` documentation]:

> Over time, new best-practice behaviors are introduced. However, these
> behaviors might not be backwards compatible. For example, a change which
> introduces new default timeouts or a new retry-mode for all operations might
> be the ideal behavior but could break existing applications.

This commit uses `BehaviorVersion::v2023_11_09()`, which is the latest
major version at the moment. When a new major version is released, the method
will be deprecated, which will warn us of the new version and let us decide
when to upgrade, after any changes if required. This is safer that using
`latest()` which would silently use a different major version, possibly
breaking existing code.

[`BehaviorVersion` documentation]: https://docs.rs/aws-config/1.1.8/aws_config/struct.BehaviorVersion.html

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:17:49 +03:00
Sebastian Dröge
6e126b9a3c deny: Add overrides for duplicates hyper / reqwest dependencies 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:17:40 +03:00
Sebastian Dröge
b05436d6d3 reqwest: Update to reqwest 0.12 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:17:31 +03:00
Philippe Normand
23403b5c9a Fix clippy warnings after upgrade to Rust 1.77 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1531>
 2024-04-08 15:15:26 +03:00
Sebastian Dröge
5f6ed181c2 Update version to 0.12.3 2024-03-21 18:53:12 +02:00
Sebastian Dröge
10d7324d90 Update CHANGELOG.md for 0.12.3 2024-03-21 18:47:31 +02:00
Sebastian Dröge
03166bcc35 Update Cargo.lock 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
François Laignel
fd154d272c webrtcsrc: add do-retransmission property 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
Sebastian Dröge
77e91e96ff livesync: Ignore another racy test 
Same problem as https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/328

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
François Laignel
ede354d7a5 webrtcsink: prevent video-info error log for audio streams 
The following error is logged when `webrtcsink` is feeded with an audio stream:

> ERROR video-info video-info.c:540:gst_video_info_from_caps:
>       wrong name 'audio/x-raw', expected video/ or image/

This commit bypasses `VideoInfo::from_caps` for audio streams.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
François Laignel
158fe80779 rtp: gccbwe: don't break downstream assumptions pushing buffer lists 
Some elements in the RTP stack assume all buffers in a `gst::BufferList`
correspond to the same timestamp. See in [`rtpsession`] for instance.
This also had the effect that `rtpsession` did not create correct RTCP as it
only saw some of the SSRCs in the stream.

`rtpgccbwe` formed a packet group by gathering buffers in a `gst::BufferList`,
regardless of whether they corresponded to the same timestamp, which broke
synchronization under certain circonstances.

This commit makes `rtpgccbwe` push the buffers as they were received: one by one.

[`rtpsession`]: bc858976db/subprojects/gst-plugins-good/gst/rtpmanager/gstrtpsession.c (L2462)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
Guillaume Desmottes
a502dba6d5 webrtc: janus: handle 'hangup' messages from Janus 
Fix error about this message not being handled:

{
   "janus": "hangup",
   "session_id": 4758817463851315,
   "sender": 4126342934227009,
   "reason": "Close PC"
}

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
Guillaume Desmottes
be055f6dfa webrtc: janus: handle 'destroyed' messages from Janus 
Fix this error when the room is destroyed:

ERROR   webrtc-janusvr-signaller imp.rs:413:gstrswebrtc::janusvr_signaller:👿:Signaller::handle_msg:<GstJanusVRWebRTCSignallerU64@0x55b166a3fe40> Unknown message from server: {
   "janus": "event",
   "session_id": 6667171862739941,
   "sender": 1964690595468240,
   "plugindata": {
      "plugin": "janus.plugin.videoroom",
      "data": {
         "videoroom": "destroyed",
         "room": 8320333573294267
      }
   }
}

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
Sebastian Dröge
c982db73a7 rtp: Switch from chrono to time 
Which allows to simplify quite a bit of code and avoids us having to
handle some API deprecations.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-21 13:30:20 +02:00
Sebastian Dröge
4def418b45 fmp4mux: Move away from deprecated chrono function 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Sebastian Dröge
dab1ff7dd9 version-helper: Use non-deprecated type alias from toml_edit 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Sebastian Dröge
c0970c6cf4 deny: Add override for heck 0.4 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
21f59c65da webrtc: allow resolution and framerate input changes 
Some changes do not require a WebRTC renegotiation so we can allow
those.

Fix #515

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Mathieu Duponchelle
2374147b0b gstregex: add support for switches exposed by RegexBuilder 
The builder allows for instance for switching off case-sensitiveness for
the entire pattern, instead of having to do so inline with `(?i)`.

All the options exposed by the builder at
<https://docs.rs/regex/latest/regex/struct.RegexBuilder.html> can now be
passed as fields of invidual commands, snake-cased.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
3f0c6e654b gtk4: scale texture position 
Fix regression in 0.12 introduced by 3423d05f77

Code from Ivan Molodetskikh suggested on Matrix.

Fix #519

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Nirbheek Chauhan
ce2aa0aecf meson: Disable docs completely when the option is disabled 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
6b7e41e551 threadshare: disable racy tests 
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/250

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
40402f8e58 livesync: disable racy tests 
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/328
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/issues/357

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
14ed7b0db1 togglerecord: disable racy test_two_stream_close_open_nonlivein_liveout test 
See https://gitlab.freedesktop.org/gdesmott/gst-plugins-rs/-/jobs/56183085

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Guillaume Desmottes
2d350252c0 spotify: document how to use with non Facebook accounts 
See discussion on #203.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Seungha Yang
2cb76f2ff2 sccparse: Ignore invalid timecode during seek as well 
sccparse holds last timecode in order to ignore invalid timecode
and fallback to the previous timecode. That should happen
when sccparse is handling seek event too. Otherwise single invalid
timecode before the target seek position will cause flow error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Jordan Yelloz
7a90e96332 livekit_signaller: Added missing getter for excluded-producer-peer-ids 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Jordan Yelloz
283d1568b4 webrtcsrc: Removed incorrect URIHandler from LiveKit source 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00
Sebastian Dröge
12533a4c0d Remove empty line from the CHANGELOG.md that confuses the GitLab renderer 
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1508>
 2024-03-20 16:24:55 +01:00