Commit graph

4970 commits

Author SHA1 Message Date
Mouse Reeve
1a2c85a327
Merge pull request #1938 from willhoh/main
Change cover class
2022-02-12 11:03:32 -08:00
Mouse Reeve
5df8bf03e6 Fixes black versioning error 2022-02-12 11:00:24 -08:00
Mouse Reeve
7fdf07c6ec Updates tests 2022-02-12 10:56:55 -08:00
Willi Hohenstein
164e0686b9 add class for correct display 2022-02-12 19:35:44 +01:00
Mouse Reeve
9827cef9a9 Python formatting 2022-02-12 10:34:16 -08:00
Mouse Reeve
1761db5444
Merge pull request #1920 from bookwyrm-social/branch-convergence
Moves towards single branch setup
2022-02-12 10:31:55 -08:00
Mouse Reeve
a2d9bf50c5 Fixes display name of list contributor comments 2022-02-12 10:18:14 -08:00
Mouse Reeve
d49e9b4dcd Updates packages 2022-02-12 09:41:18 -08:00
Willi Hohenstein
67ea18c840 Changed cover class for proper image size in mobile 2022-02-12 17:58:36 +01:00
Joachim
c33cf60624 aria-hidden elements do not contain focusable elements
https://dequeuniversity.com/rules/axe/4.3/aria-hidden-focus
2022-02-12 16:33:16 +01:00
Joachim
7877524116 ARIA button, link, and menuitem must have an accessible name
https://dequeuniversity.com/rules/axe/4.3/aria-command-name

In this case, the menuitem wasn't displayed (because the div was hidden). I prefer not to include the menuitem in that situation.
2022-02-12 16:25:40 +01:00
Joachim
f742cc023b ARIA attributes must conform to valid values
https://dequeuniversity.com/rules/axe/4.3/aria-valid-attr-value
2022-02-12 16:18:56 +01:00
Joachim
b27b6a5980 Certain ARIA roles must contain particular children
https://dequeuniversity.com/rules/axe/4.3/aria-required-children

In order to make this work, I had to translate Bulma's style so it doesn't use `ul` and `li` anymore.

The JS code had to be adapted, I also changed `button` to `tab` (seemed like a more relevant name) and added a `scrollIntoView()` on load the active tab is always visible.
2022-02-12 16:14:35 +01:00
Joachim
bbb89605a5 Page must have one main landmark
https://dequeuniversity.com/rules/axe/4.3/landmark-one-main
2022-02-12 16:10:40 +01:00
Mouse Reeve
89de03bffe Adds breadcrumbs 2022-02-11 14:58:40 -05:00
Mouse Reeve
b95f0ed287 Use color in announcement 2022-02-11 14:43:37 -05:00
Mouse Reeve
01b52f023a Adds edit announcement view 2022-02-11 14:42:47 -05:00
Mouse Reeve
cfa91e2570 Adds color options to announcements 2022-02-11 14:00:01 -05:00
Mouse Reeve
ee23aba994 Use details and summary for announcement panel 2022-02-11 13:50:55 -05:00
Mouse Reeve
62741a5d2e Allow html in announcement header 2022-02-11 13:36:08 -05:00
Mouse Reeve
059fd84d06 Adds delete button to announcements list view
It's handy to have it there
2022-02-11 13:33:42 -05:00
Mouse Reeve
c06817e9ff Python formatting 2022-02-09 12:23:01 -05:00
Mouse Reeve
6323b0e700 Use correct model type for federated links 2022-02-09 12:20:11 -05:00
Mouse Reeve
73b611d68d Tick version number 2022-02-04 20:12:26 -08:00
Mouse Reeve
a73960a0da Python formatting 2022-02-04 19:44:03 -08:00
Mouse Reeve
49ceb2a978 Fixes warning in author view tests 2022-02-04 19:41:21 -08:00
Mouse Reeve
a9a6fd1242 Adds test for author page bug 2022-02-04 19:34:37 -08:00
Mouse Reeve
28a8edfdc4 Fixes author page query 2022-02-04 19:06:47 -08:00
Mouse Reeve
bc7aa91b97 Fixes pylint complaints 2022-02-04 18:50:57 -08:00
Mouse Reeve
7811a9920e Copy config from prod branch to main 2022-02-04 18:36:12 -08:00
Mouse Reeve
70bd6b9a65
Merge pull request #1917 from bookwyrm-social/list-page-error
Fixes errors in how lists with notes display
2022-02-04 15:44:49 -08:00
Mouse Reeve
18768a23f3 Fixes test 2022-02-04 15:30:58 -08:00
Mouse Reeve
0c3b6e6938
Merge pull request #1900 from willhoh/main
Added check for bocked or pending domains. Fixes #1850
2022-02-04 12:11:41 -08:00
Mouse Reeve
547d246375 Fixes 500 error 2022-02-04 12:09:20 -08:00
Mouse Reeve
0683ce1c33 Proper markdown formatting 2022-02-04 12:07:26 -08:00
Mouse Reeve
fefb7e582a Fixes list note display 2022-02-04 12:02:10 -08:00
Mouse Reeve
719df5621c Unit test to catch error on list page 2022-02-04 11:58:03 -08:00
Mouse Reeve
82aacf8f2a
Update forms.py 2022-02-04 11:47:18 -08:00
Mouse Reeve
e80a4c16f0
Merge pull request #1915 from bookwyrm-social/url-validation
Adds some simple url validation
2022-02-04 08:45:43 -08:00
Willi Hohenstein
495af09c4c
Merge branch 'bookwyrm-social:main' into main 2022-02-04 14:11:50 +01:00
Mouse Reeve
7c0d51ed14 Fixes duplicted shelves on user view 2022-02-03 18:59:08 -08:00
Mouse Reeve
3e635f497e Adds some simple url validation 2022-02-03 15:11:01 -08:00
Willi Hohenstein
58fb9ba0d4
Merge branch 'bookwyrm-social:main' into main 2022-02-03 23:55:17 +01:00
Mouse Reeve
ebc3f14f22
Merge pull request #1914 from bookwyrm-social/static-close-buttons
Show cancel buttons on modals in static mode
2022-02-03 14:08:36 -08:00
Mouse Reeve
9013b1417a Show cancel buttons on modals in static mode 2022-02-03 13:59:53 -08:00
Mouse Reeve
3b12af63b6 Fixes links on import page 2022-02-03 13:49:33 -08:00
Mouse Reeve
582b84ecaa
Merge pull request #1911 from bookwyrm-social/more-tests
Activitystreams tests
2022-02-03 13:33:15 -08:00
Mouse Reeve
85aad7c219 Another sorting order error 2022-02-03 13:25:44 -08:00
Mouse Reeve
cae7191a2b Python formatting 2022-02-03 13:19:56 -08:00
Mouse Reeve
2c7a6e8518 Correct status order 2022-02-03 13:17:16 -08:00
Mouse Reeve
1f6ecc39ac Adds allowlist for html attrs 2022-02-03 13:15:06 -08:00
Mouse Reeve
7b5bee8d7b Merge branch 'main' into more-tests 2022-02-03 12:48:11 -08:00
Mouse Reeve
5a3ce5e328 Fixes rating in about page superlatives 2022-02-03 11:48:56 -08:00
Mouse Reeve
a370602903
Merge pull request #1860 from cincodenada/image-generation-add-cjk
Use Source Han Sans for preview images generation (bis)
2022-02-03 11:11:38 -08:00
Mouse Reeve
c58a3ac114
Merge branch 'main' into main 2022-02-03 10:40:27 -08:00
Mouse Reeve
a46ab96d9b Fixes add/edit notes form on list page 2022-02-03 10:30:30 -08:00
Mouse Reeve
2c16b8f33b Fix shelf names on books page 2022-02-03 08:44:51 -08:00
Willi Hohenstein
1b313c2b62 added check of existing url for book
sould also fix #1899
2022-02-02 22:34:30 +01:00
Mouse Reeve
e18f6fbfaf Adds migration for locale name update 2022-02-02 12:44:11 -08:00
Mouse Reeve
f8bd0800f1
Merge pull request #1904 from bookwyrm-social/book-page-add-list
Fixes adding book to list from book page
2022-02-02 12:40:44 -08:00
Mouse Reeve
36a52019fb Fixes adding book to list from book page 2022-02-02 12:29:01 -08:00
Mouse Reeve
e9370fe4c9 Fixes name of Swedish locale 2022-02-02 11:43:54 -08:00
Willi Hohenstein
4503dd6864 Merge branch 'main' of github.com:willhoh/bookwyrm 2022-02-02 19:51:23 +01:00
Willi Hohenstein
e37982d285 added domain pending or blocked check
fixes #1850
2022-02-02 19:35:26 +01:00
Mouse Reeve
6fd3ac0cb1 Changes how test image data is loaded 2022-02-02 09:36:47 -08:00
Mouse Reeve
194c69f512 Fixes return values of null responses 2022-02-02 07:09:35 -08:00
Joel Bradshaw
060f515aea Be even more conservative on errors
This runs at startup of anything, so we should be extra sure to not
break anything, and lots of things can go wrong downloading files from
the internet
2022-02-01 21:59:07 -08:00
Joel Bradshaw
d6abd9b32d Ensure directory exists, don't crash if we fail to write
We should be creating the directory because the static tree from the
repo isn't actually copied into the container, so we can't rely on it
existing.

And if we can't write it, we should catch that error instead of crashing
the whole thing, oops!
2022-02-01 21:45:13 -08:00
Mouse Reeve
754e24812b Check image extensions before saving 2022-02-01 21:18:25 -08:00
Mouse Reeve
9611815b44 Extract wikipedia and inventaire ids 2022-01-30 12:02:18 -08:00
Mouse Reeve
44dad43f36 Load new fields via connector 2022-01-30 11:41:33 -08:00
Mouse Reeve
c4b8e7949d Add more book identifier fields 2022-01-30 11:41:31 -08:00
Mouse Reeve
1dfe4d0f52
Merge pull request #1890 from bookwyrm-social/shelf-display
Don't display empty shelves on user page
2022-01-30 11:39:25 -08:00
Mouse Reeve
e674f85d4e Don't display empty shelves on user page 2022-01-30 11:23:23 -08:00
Mouse Reeve
4e607d38eb
Merge pull request #1888 from bookwyrm-social/ap-delete
More resilient hanlding of deletions
2022-01-30 11:21:16 -08:00
Mouse Reeve
a7afd4c47b Fixes display of dm button 2022-01-30 11:10:18 -08:00
Mouse Reeve
f2d2d050f5
Merge pull request #1886 from bookwyrm-social/filter-panels-display
Fixes form element display inside details panel
2022-01-30 10:45:26 -08:00
Mouse Reeve
18b53a608c More resilient hanlding of deletions 2022-01-30 10:42:29 -08:00
Mouse Reeve
65496fea49 Fixes black regression 2022-01-30 10:26:28 -08:00
Mouse Reeve
ae0e67f076 Fixes form element display inside details panel 2022-01-30 09:31:57 -08:00
Mouse Reeve
68f9ee9d8a Fixes access level control in report view 2022-01-30 09:20:26 -08:00
Mouse Reeve
24c1d5a168 Add prompt to respond to reporter 2022-01-30 09:17:12 -08:00
Mouse Reeve
c04bf4638f Avoid duplicate emails 2022-01-30 08:59:32 -08:00
Mouse Reeve
8a07f5c396 Fixes report remote id 2022-01-30 08:50:53 -08:00
Mouse Reeve
ae53b479f5 Fixes status field on report modal form 2022-01-30 08:36:20 -08:00
Mouse Reeve
aaccab6dce Merge branch 'main' into cache-fix 2022-01-30 07:09:32 -08:00
Mouse Reeve
f86016ba33 Python formatting for black update 2022-01-30 07:01:38 -08:00
Mouse Reeve
3c2aa72424 Fixes bad cache on status shelve buttons 2022-01-30 06:56:15 -08:00
Mouse Reeve
29a7c59d5f Bring prod and main into sync on urls 2022-01-30 06:43:50 -08:00
Mouse Reeve
224dc4100a Activitstreams tests 2022-01-28 17:32:41 -08:00
Mouse Reeve
c6c1534c85 Adds id to report page 2022-01-27 20:05:17 -08:00
Mouse Reeve
1d45e8b4cc Updates ip blocklists tests 2022-01-27 19:43:42 -08:00
Mouse Reeve
778975d492 Merge branch 'misc-tests' into user-view 2022-01-27 19:39:19 -08:00
Mouse Reeve
89aa1673b2 Admin views tests 2022-01-27 19:39:07 -08:00
Mouse Reeve
afdaa776e2 Fixes syntax 2022-01-27 19:38:51 -08:00
Mouse Reeve
e7ecae0f96 Adds annual review test 2022-01-27 18:57:18 -08:00
Mouse Reeve
40a14a05ad
Merge pull request #1865 from bookwyrm-social/unread-status-translation
Calculate and translate unread status counts in view
2022-01-27 18:47:35 -08:00
Mouse Reeve
107f02e4e5
Merge pull request #1876 from bookwyrm-social/initdb-tests
Adds tests for initdb command
2022-01-27 18:38:55 -08:00
Mouse Reeve
59b5369654 Updates tests 2022-01-27 18:23:31 -08:00
Mouse Reeve
d711c7a5a2 Test fixes 2022-01-27 13:32:49 -08:00
Mouse Reeve
047e3a324a
Merge pull request #1855 from bookwyrm-social/instance-default-language
Makes default language configurable
2022-01-27 13:25:12 -08:00
Mouse Reeve
ba18e1e34b Adds tests for initdb command 2022-01-27 13:23:29 -08:00
Mouse Reeve
b3d9a46c98
Merge pull request #1869 from bookwyrm-social/list-notes
Let users add info about their list entry submissions
2022-01-27 13:04:08 -08:00
Mouse Reeve
d925395f9d
Merge pull request #1874 from willhoh/main
This fixes #1871 and fixes #1873
2022-01-27 13:01:50 -08:00
Mouse Reeve
a80c19d3e5 Screen reader fixes for list view 2022-01-27 12:55:53 -08:00
Mouse Reeve
2cf10b932d
Merge pull request #1875 from bookwyrm-social/get-started-books
Don't check suggested books against shelved books
2022-01-27 12:43:04 -08:00
Willi Hohenstein
72c22cdcc0 reformatted file 2022-01-27 21:21:28 +01:00
Mouse Reeve
577bc18a47 Minor simplification for user shelf view 2022-01-27 12:05:26 -08:00
officialkzhang
f62e66f5ee
Revised HTML element for onboarding logo
Added navbar class to the parent header of the onboarding logo and removed the previously appended icon class from the image.
2022-01-27 14:51:57 -05:00
Mouse Reeve
c0dabeee04 Don't check suggested books against shelved books
It takes too long, and ideally this is your first action so you don't
have any books shelved yet.
2022-01-27 11:45:40 -08:00
Mouse Reeve
d62473c432 Tests that list item notes federate 2022-01-27 11:04:30 -08:00
Willi Hohenstein
dd35c90042 fix linging errors 2022-01-27 19:54:12 +01:00
Willi Hohenstein
f8afdfc6a9 This fixes #1871 huge amount of traffic from bots
and closes #1873 that leaves a file after testing.
2022-01-27 17:30:02 +01:00
officialkzhang
13edeffb53
Added a class for fixing onboarding logo's size
Added a CSS class for fixing the onboarding logo's size to a reasonable dimension (about 3rem).
2022-01-27 00:22:50 -05:00
Mouse Reeve
0d69d9b48b Adds more unit tests for list views 2022-01-26 12:02:48 -08:00
Mouse Reeve
65b9872c72 Fixes approving curated submissions 2022-01-26 10:37:50 -08:00
Mouse Reeve
eddd9ccc32 Refer to user by id in form tests 2022-01-25 13:57:12 -08:00
Mouse Reeve
2eabe29401 Show notes on curation page 2022-01-25 13:54:44 -08:00
Mouse Reeve
3f9a401d98 Put list action tests in correct files 2022-01-25 13:54:38 -08:00
Mouse Reeve
3a5289a999 Separate lists view test files 2022-01-25 13:38:13 -08:00
Mouse Reeve
dd16fb2a26 Move embed view to separate file 2022-01-25 13:37:57 -08:00
Mouse Reeve
d456ab7306 Move lists tests into directory 2022-01-25 13:22:04 -08:00
Mouse Reeve
f85158191b Use form for saving list items 2022-01-25 12:11:17 -08:00
Mouse Reeve
a43731b335 Fixes tests for list actions 2022-01-25 10:08:54 -08:00
Mouse Reeve
e1599384b0 Fixes list views tests 2022-01-25 09:46:00 -08:00
Mouse Reeve
38ccc23cd5 Add notes form 2022-01-25 09:40:03 -08:00
Mouse Reeve
6009593b6b Migration formatting 2022-01-25 09:17:00 -08:00
Mouse Reeve
037cc35eeb Adds merge migration and python formatting 2022-01-25 08:45:22 -08:00
Mouse Reeve
de4576bc44 Merge branch 'main' into list-notes 2022-01-25 08:44:29 -08:00
Mouse Reeve
9902794bbd Adds edit note view 2022-01-25 08:44:04 -08:00
Joel Bradshaw
0c53f4e003 Fix linting and formatting 2022-01-25 01:09:27 -08:00
Joel Bradshaw
a1a3aa45f4 Don't log autoload debug
This is just too much
2022-01-25 00:53:15 -08:00
Joel Bradshaw
9e6390662b Download fonts at app startup instead
We can't bake the font into the Docker image as such, because we mount
the volumes which blows away anything we have in the app tree
beforehand.

We could stash it somewhere in the image and then copy it from there on
app startup or something, but at that point we might as well just
download it as part of the app startup.
2022-01-25 00:53:01 -08:00
Joachim
766a0cc652 Fix tests 2022-01-24 23:16:15 -08:00
Joachim
6f5115c716 Use Source Han Sans for preview images generation 2022-01-24 23:16:15 -08:00
Joel Bradshaw
284eb620dd Add Source Han font for preview generation to Docker image
Include the license and a README explaining things in the repo itself.

Depending on an external source for this is intended to be temporary,
the goal is to have a Bookywrm-managed source for these, but this should
be stable enough for now.

We build it into the Dockerfile to make it available without adding it
to the git repo itself, because git history is forever and we don't want
to bake large files into the history.

Theoretically it would make sense to gate this download on the
ENABLE_PREVIEW_IMAGES environment variable, but ENV variables aren't
available at Docker image build time (for sensible reasons), so we just
unconditonally download it.

This does mean users will ultimately download it anyway, but the benefit
to doing this over adding it to the git history is that if we switch
fonts, or update this one, or change strategies altogether, this version
of the font will no longer have to be downloaded.

Additionally, the font won't be downloaded until the application is
actually built, which involves a bunch of other downloading (of Docker
images and the like), so it's a reasonable time to do it.
2022-01-24 23:16:14 -08:00
Mouse Reeve
ca0dbeb0ab Move list views into more files 2022-01-24 19:39:30 -08:00
Mouse Reeve
a1a84b28b0 Adds edit box 2022-01-24 13:56:18 -08:00
Mouse Reeve
8280386f0e Context for note block in list item 2022-01-24 13:45:52 -08:00
Mouse Reeve
5206d08dbb Adds demo display of comment in list entry 2022-01-24 13:37:51 -08:00
Mouse Reeve
d0a4c78d02 Limit length on list item note 2022-01-24 12:02:05 -08:00
Mouse Reeve
eeee62cd04 Adds Swedish to the app 2022-01-24 09:39:13 -08:00
Joel Bradshaw
7373fb4132
Fix typo from models refactor
Looks like this got caught up when moving to importing `models`
instead of the individual models, and was throwing an error on
`./bw-dev initdb`
2022-01-23 23:41:22 -08:00
Mouse Reeve
191079a922 Python formatting 2022-01-22 19:01:42 -08:00
Mouse Reeve
e5c8500547 Updates cache buster 2022-01-22 17:05:31 -08:00
Mouse Reeve
3fc690e763 Calculate and translate unread status counts in view 2022-01-22 17:03:48 -08:00
Mouse Reeve
67c3091aa1 Fixes option checking in initdb management command 2022-01-22 15:09:30 -08:00
Mouse Reeve
b35efb6eab
Merge pull request #1857 from bookwyrm-social/about-page-superlatives
Fixes display controls for about page superlatives
2022-01-20 17:20:04 -08:00
Mouse Reeve
ce30f8a8f0
Merge pull request #1854 from bookwyrm-social/pending-users
Activate users in pending state when site registration mode changes
2022-01-20 17:02:28 -08:00
Mouse Reeve
a8776843bd Fixes display toggle for about page superlatives 2022-01-20 17:00:15 -08:00