rafaelcaricio/moviewyrm
1
0
Fork 0
forked from mirrors/bookwyrm
Code Issues 4 Pull requests Projects Releases Wiki Activity
3926 commits 16 branches 11 tags 32 MiB
Commit graph

183 commits

Author SHA1 Message Date
Fabien Basmaison
2f90b4ce66 [assets] Fix broken actions for focus and checkbox: 
This commit should address the following two comments:

- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609172258
- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609174513
 2021-04-08 11:37:14 +02:00
Fabien Basmaison
83bd417878 [assets] Update interactions code: 
This commit should address https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609381969.

- Disable the button being used to submit the form.
- Rename variables based on @mouse-reeve’s explanations. Thanks! ✨
 2021-04-08 11:08:13 +02:00
Fabien Basmaison
be0cabc415 [css] Improve quotes. 2021-04-07 18:07:32 +02:00
Fabien Basmaison
2a0924027b [css] Use more visible comments to split blocks. 2021-04-07 17:33:28 +02:00
Fabien Basmaison
f77088b964 [assets] Remove redundant class already provided by bulma: 
Replace all classes `hidden` with `is-hidden` in templates, CSS and JS.
 2021-04-07 17:31:00 +02:00
Fabien Basmaison
f2a2b410a1 [assets] Add comment to mention replacing font icons with SVG. 2021-04-07 10:49:52 +02:00
Fabien Basmaison
54805afb51 [assets] Tweak JSDoc. 2021-04-07 10:37:11 +02:00
Fabien Basmaison
5d569e8926 [assets] Only update status if the promise is successful: 
- Use promises in `ajaxPost` and `interact`.
- Add some animations in CSS.
 2021-04-07 09:24:34 +02:00
Fabien Basmaison
1c05107f2b [assets] Tweak comments. 2021-04-07 07:53:30 +02:00
Fabien Basmaison
44040201f9 [assets] Move interact function. 2021-04-06 17:57:39 +02:00
Fabien Basmaison
9d95f54aa2 [assets] Refactor toggleAction and toggleMenu a bit. 2021-04-06 17:48:56 +02:00
Fabien Basmaison
52d2f0e331 [assets] Document functions and variables: 
- Use expressive names for variables.
- Add docblocks for each function.
- Add ESLint rules for comments.
 2021-04-06 16:17:20 +02:00
Fabien Basmaison
5d3d00f694 [assets] Use dataset + use expressive names for some variables. 2021-04-06 15:36:34 +02:00
Fabien Basmaison
62fe2ef600 [assets] Replace inline events with addEventListener; this breaks sliding menu. 2021-04-06 11:37:23 +02:00
Fabien Basmaison
7e49b3cb26 [assets] Simplify addRemoveClass function. 2021-04-06 11:19:44 +02:00
Fabien Basmaison
70c652d565 [assets] Add rules to ESLint: 
- Fix long line.
- Enforce a few stylistic habits:

    - Avoid some potential dangerous constructs.
    - `arrow-spacing`: Use at least one space around arrows.
    - `keyword-spacing`: Use at least one space around keywords (if, else, for…).
    - `no-multiple-empty-lines`: Only use one empty line between code.
	- `no-var`: Use `let` or `const` instead of `var`:
    - `padded-blocks`: Do not pad blocks.
    - `padding-line-between-statements`: Use empty lines between some statements.
    - `space-before-blocks`: Use at least one space before the opening brace of a block.
 2021-04-06 10:42:52 +02:00
Fabien Basmaison
991d897ac7 [assets] Listen to events as soon as possible. 2021-04-06 09:57:52 +02:00
Fabien Basmaison
2f2f7db086 [assets] Use classes for JS files: 
- Classes strictly parse code implicitly.
- Fix previously updated code.
 2021-04-06 09:44:59 +02:00
Fabien Basmaison
f430363be0 [assets] Simplify a function expression. 2021-04-06 09:11:56 +02:00
Fabien Basmaison
f6c3e581b9 [assets] Replace Array.from(document.getElementsByClassName(…)) by querySelectorAll(…). 2021-04-06 09:11:27 +02:00
Fabien Basmaison
6b0a3ce4b1 [assets] Move localStorage chunks of code to their own file: 
This should prevent a sync issue with updateDisplay not always being loaded on time.
 2021-04-06 09:06:51 +02:00
Fabien Basmaison
964b47ea97 [assets] Fix path for icomoon font. 2021-04-05 16:46:30 +02:00
Fabien Basmaison
cbed5e331b [assets] Move some frontend assets to _vendor_ directories: 
This simplifies linting of files we have no grasp on, and clarifies responsibilities.

- Add .eslintignore.
- Restrict linting to bookwyrm/static.
 2021-04-05 16:17:11 +02:00
Fabien Basmaison
5aea7343b4 [assets] Rename some files for consistency. 2021-04-05 16:16:48 +02:00
Fabien Basmaison
6971c9b133 [assets] Move toggleAllCheckboxes code to its own file. 2021-04-05 16:16:05 +02:00
Mouse Reeve
abd6a78295
Merge pull request #862 from mouse-reeve/disabled-link 
Valid html solution to disabling pagination links
 2021-04-04 10:59:22 -07:00
Fabien Basmaison
485b0fa0f3 Simplify rating form: 
- Create a snippet to regroup similar code.
- Reduce and document tricky logic of CSS.
- Add i18n strings.
 2021-04-04 15:08:42 +02:00
Mouse Reeve
8d7527dee3 CSS linter fixes 2021-04-03 11:59:14 -07:00
Mouse Reeve
3cb91098e6 Valid html solution to disabling pagination links 2021-04-03 11:54:15 -07:00
Mouse Reeve
7483cb5919 Adds getting started find books view 2021-03-31 13:56:26 -07:00
Fabien Basmaison
53f03457cc Add linter for JS files with basic recommended rules: 
- Add Github Action.
- Fix JS files to match rules; mostly `globals` and `exported`.
 2021-03-31 17:07:28 +02:00
Fabien Basmaison
cc01105bf0 Add linter for CSS files: 
- Add Github Action.
- Update .gitignore.
- Add .stylelintignore for vendor related files.
- Fix format.css to match rules (includes hacks with @todo).
 2021-03-31 16:17:05 +02:00
Mouse Reeve
0ef33d2acb Adds shared books as a metric for recommending follows 2021-03-27 07:36:14 -07:00
Mouse Reeve
b0e1095fe6 Adds "suggested follows" panel 2021-03-26 10:32:42 -07:00
Mouse Reeve
8d5630e059 Adds css transitions to notification and unread statuses 2021-03-23 17:52:58 -07:00
Mouse Reeve
b8cd1d5bce Show unread status reload link 2021-03-23 12:52:38 -07:00
Mouse Reeve
d8a20175b6 Adds email template layout and formatting 2021-03-21 12:06:12 -07:00
Mouse Reeve
dd15e87073 Merge branch 'main' into progress-update-ui 2021-03-20 17:38:22 -07:00
Mouse Reeve
942c4a6664 Move progress updates into modal 2021-03-20 17:18:18 -07:00
Fabien Basmaison
fa79070b59 [lint] Update editorconfig linting: 
- Add settings for comments.
- Remove custom settings that don’t work.
- Fix vendor JS file:
 2021-03-20 16:33:18 +01:00
Fabien Basmaison
b9a61162d7 Merge branch 'main' into ci 2021-03-20 15:26:51 +01:00
Mouse Reeve
c31bf1f0c8 Fixes loading javascript listeners 2021-03-19 15:59:28 -07:00
Mouse Reeve
5ad645c225 Move check all js into separate file 2021-03-19 10:51:45 -07:00
Mouse Reeve
443daab128 Move tabs javascript into separate file 2021-03-19 10:47:32 -07:00
Mouse Reeve
baee0796cd Moves localstorage handlers into its own file 2021-03-18 09:02:07 -07:00
Mouse Reeve
091ad53061 JS linting and whitespace fixes 2021-03-13 12:14:34 -08:00
Fabien Basmaison
a52fee4ccf Remove (potentially useful) unused CSS. 2021-03-06 21:18:39 +01:00
Fabien Basmaison
99e5e3e414 [import] Show skip link to all when there is more than 10 failed imports. 2021-03-05 22:09:56 +01:00
Fabien Basmaison
097b8e5811 Fix toggling all checkboxes of failed imports: 
- Rename classes and function to something more descriptive.
- Listen to the element checked status instead of a click on a non‑focusable element.
- Use specific DOM targets instead of relying on the DOM ancestor tree.
- Add a skip‑link to the end of the list and avoid tabbing through all failed items.
- Update related i18n strings in French.
- Avoid having the label on the whole width to prevent accidental click.
- Move `fieldset` out of `ul`.
 2021-03-05 15:41:21 +01:00
Fabien Basmaison
1cb84b0f62 [lint] Fix indentation in JS files. 2021-03-04 19:36:17 +01:00
Fabien Basmaison
420a33d79f [lint] fix indentation in CSS files. 2021-03-04 19:27:03 +01:00
Fabien Basmaison
fc16211125 [lint] Ignore newline in svg files within fonts/. 2021-03-04 19:24:11 +01:00
Ned Zimmerman
263b13f157 Adapt tab handler to vanilla JS, fix focus jump, improve accessible naming of tabs/panels 2021-02-28 14:04:04 -04:00
Ned Zimmerman
bc7f830b2b Merge branch 'upstream' into tab-keyboard-accessibility 2021-02-27 11:53:27 -04:00
Ned Zimmerman
9580bec154 feat: modify tabbed interfaces to support keyboard accessibility (fixes #526) 2021-02-27 11:47:03 -04:00
Mouse Reeve
b1268b7db8 Small covers too small on mobile 2021-02-23 12:44:25 -08:00
Mouse Reeve
485de039cf
Merge branch 'main' into shelve-buttons 2021-02-09 13:28:00 -08:00
Mouse Reeve
76491e4e35 Back off notification polling 2021-02-09 10:38:43 -08:00
Mouse Reeve
05c00b9eca Adds cute lil icons to discover page 2021-02-02 10:13:35 -08:00
Mouse Reeve
e5746d6117 Menu list for shelf button options 2021-01-30 11:43:40 -08:00
Mouse Reeve
b53ef73faf Feed templates 2021-01-29 10:25:31 -08:00
Mouse Reeve
2a6a000e05 Moves avatar crop into function and adds test 2021-01-26 08:03:16 -08:00
Mouse Reeve
2411b4fe79 puts @'mentions directly in compose box 2021-01-19 16:16:22 -08:00
Mouse Reeve
1778e8dd46 Uses timeout instead of interval 2021-01-19 14:59:46 -08:00
Mouse Reeve
94a41498cf Remove counts when notifications are deleted 2021-01-19 14:32:08 -08:00
Mouse Reeve
3fce67a60d Only update on change 2021-01-19 14:25:04 -08:00
Mouse Reeve
394666357f Poll for notifications 2021-01-18 16:32:02 -08:00
Mouse Reeve
c7b03fec5a Fixes rate action 2021-01-18 09:57:44 -08:00
Mouse Reeve
7308d8d1e9 javascript cleanup 
I got my linter working!
 2021-01-18 08:26:04 -08:00
Mouse Reeve
51ddada8f6 Fixes mobile menu dropdown 2021-01-17 20:31:37 -08:00
Mouse Reeve
3f136c40da Uses js pattern for tabs 2021-01-17 20:19:09 -08:00
Mouse Reeve
0a70d6e981 Makes dropdown clickable, and work with screen reader 
I'm lightly peeved with bulma that it wasn't clear how to make hover
menus accessible, but clickable menus are just fine with my anyway.
 2021-01-17 16:29:46 -08:00
Mouse Reeve
ff743ed9d6 Javascript button for reply form 2021-01-17 10:38:34 -08:00
Mouse Reeve
47d5b907ac Readthrough interactions 2021-01-17 10:10:59 -08:00
Mouse Reeve
f7e3cbda84 Uses toggle button snippet for content warning 2021-01-17 08:50:47 -08:00
Mouse Reeve
afdf5fc8ec starts replacing pure css buttons with javascript buttons 
RIP, but it was time
 2021-01-17 08:26:28 -08:00
Mouse Reeve
f42fd28c73 Removes unused javascript 2021-01-16 19:59:08 -08:00
Mouse Reeve
3e58163f0d refactors content warning button 2021-01-16 19:57:20 -08:00
Mouse Reeve
739b6e19e2 Dismiss reading goal using localstorage 2021-01-16 09:21:19 -08:00
Mouse Reeve
11ea829657 Adds icon to goal form 2021-01-16 08:54:16 -08:00
Mouse Reeve
f61a25cfb1
Merge branch 'main' into html-interaction 2021-01-15 09:45:33 -08:00
Mouse Reeve
861249080b Moves toggle menu javascript out of html 2021-01-14 15:45:30 -08:00
Mouse Reeve
7abe39b7d5 Tab change javascript out of html 2021-01-14 15:29:37 -08:00
Mouse Reeve
4d4e692f49 Javascript cleanup 2021-01-14 15:16:18 -08:00
Mouse Reeve
5591024933 Moves interaction javascript out of html 2021-01-14 14:38:33 -08:00
Mouse Reeve
e57c4f4bcd Adds focus control javascript 2021-01-14 13:02:28 -08:00
Mouse Reeve
766c7afdb9 Don't let long titles display past card title box 2021-01-13 19:38:26 -08:00
Mouse Reeve
4319e58079 Fixes squished avatars 2021-01-11 18:09:12 -08:00
Mouse Reeve
aa151c111f Smaller max width for large covers 2021-01-10 09:50:17 -08:00
Mouse Reeve
b1d4b75926 Fixes tail end of shelving pulldown getting hidden 2021-01-06 19:56:56 -08:00
Mouse Reeve
8e923d6333 User container class in layout 2021-01-03 12:53:51 -08:00
Mouse Reeve
721d20efab Creates snippets for discover preview boxes 2021-01-03 11:24:26 -08:00
Mouse Reeve
ef42d29bd9 Discovery landing page 2021-01-03 11:10:04 -08:00
Mouse Reeve
ef696782ab Allow markdown in html fields 2020-12-19 18:54:56 -08:00
Mouse Reeve
3f1bf4e1d6 Set max width on cover container 2020-12-17 12:57:56 -08:00
Mouse Reeve
6cc1e241fe display images at a reasonable size 2020-11-24 12:07:00 -08:00
Mouse Reeve
6300c37a4e Select all checkbox 2020-11-13 10:14:24 -08:00
Mouse Reeve
44b798b423 Puts reply form below button that shows it 
still think this is janky.
 2020-11-11 18:32:52 -08:00
Mouse Reeve
a5a1af418c Adds ui for editing and adding shelves 2020-11-10 13:39:37 -08:00
Mouse Reeve
79f7c55a04 indicate if menu has been expanded 2020-11-09 11:58:19 -08:00