Commit graph

356 commits

Author SHA1 Message Date
Joachim
8712b2fdab ESLint 2021-11-24 19:02:07 +01:00
Joachim
db5e7a886a Handle count of notifications banner 2021-11-24 19:00:30 +01:00
Chad Nelson
6be9ac4f70 Abstract JS for multivalue form fields 2021-11-21 17:32:48 -05:00
Hugh Rundle
e247e96832
remove incorrect comment 2021-11-20 19:34:37 +11:00
Hugh Rundle
a3270551f9
code cleanup 2021-11-20 19:19:51 +11:00
Hugh Rundle
b273123708
code style 2021-11-20 16:06:16 +11:00
Hugh Rundle
9ffe4d340e
trigger reading status modals from move button
- unhide reading status shelves
- trigger modals when moving to a read status shelf
- force page refresh when using move button
2021-11-20 08:06:13 +11:00
Hugh Rundle
6e5c0cc4c3 Merge branch 'main' into bookwyrm-groups
There are database migrations in main ahead of this branch so they need to be merged in to the branch before we can merge back into main.
2021-10-17 06:22:04 +11:00
Mouse Reeve
9ac5384d68 Fixes test and css linter 2021-10-15 09:54:14 -07:00
Mouse Reeve
2f40394c0a Updates edited display 2021-10-15 09:41:29 -07:00
Hugh Rundle
5d7f77021b dammit eslint 2021-10-10 14:02:55 +11:00
Hugh Rundle
3d74b10c5f eslinting 2021-10-10 13:55:18 +11:00
Hugh Rundle
726217577f linting 2021-10-10 13:18:16 +11:00
Hugh Rundle
48fc85c761 adjust commenting on js file 2021-10-08 18:45:28 +11:00
Hugh Rundle
ec7d0db843 linting fixes 2021-10-05 21:48:59 +11:00
Hugh Rundle
3a90311129 update indenting for linter 2021-10-04 22:20:02 +11:00
Hugh Rundle
602664b8d7 Merge branch 'main' into groups-merge-test
Big merge of a couple of weeks' work from the main project back into this branch. :ohno:
2021-10-03 10:49:38 +11:00
Mouse Reeve
eaa77906b2
Merge pull request #1485 from bookwyrm-social/notifications
Refactors notifications templates
2021-10-02 11:41:18 -07:00
Mouse Reeve
db74538345 Update for js linter 2021-10-02 11:28:16 -07:00
Mouse Reeve
b9632039f9 Link notification block to its main path 2021-10-02 11:26:22 -07:00
Mouse Reeve
bd463ea6fe Lint fixes 2021-10-01 18:09:11 -07:00
Mouse Reeve
29ee99c03e Styles for the thread page 2021-10-01 18:05:48 -07:00
Mouse Reeve
d78c278665 Progress update flow for modal 2021-09-29 10:59:36 -07:00
Hugh Rundle
762202c4b0 fix UI for group curated list editing
When creating or editing a list, the group selection dropdown will only appear if the user selects "group" as the curation option (or it is already selected).

- fix typo in bookwyrm.js comments
- add data-hides trigger for hiding elements after they have been unhidden, where simple toggles are not the right approach
2021-09-27 11:03:41 +10:00
Mouse Reeve
6022e7b232 Adds IP blocklist views 2021-09-17 13:04:10 -07:00
Mouse Reeve
ccdfaa3187 Linter fixes 2021-09-12 11:48:25 -07:00
Mouse Reeve
7cfb0a4271 Supports Safari in form submission event 2021-09-12 11:45:18 -07:00
Mouse Reeve
a011a9eab5 Linting fixes 2021-09-12 10:41:16 -07:00
Mouse Reeve
b5cc75e078 Adds css for file input buttons 2021-09-12 10:36:06 -07:00
Mouse Reeve
926eb7646f Removes duplicate selector 2021-09-10 15:03:01 -07:00
Mouse Reeve
3fdbd3035a how to disable linter complaint?? 2021-09-10 14:58:08 -07:00
Mouse Reeve
da5003c45e Fixes hover states 2021-09-10 14:56:45 -07:00
Mouse Reeve
daf42a30da Adds javascript for half star ratings 2021-09-10 14:27:08 -07:00
Mouse Reeve
2665e3640e CSS for half stars 2021-09-10 14:19:57 -07:00
Mouse Reeve
5c329c35f0 Warn http error 2021-09-10 10:22:28 -07:00
Mouse Reeve
5e9b8eb571 Removes unused variable 2021-09-10 10:20:40 -07:00
Mouse Reeve
08d2bff7ca General function for displaying messages 2021-09-10 10:12:37 -07:00
Mouse Reeve
e3ab5afcbd Catch error responses from API 2021-09-10 08:59:49 -07:00
Mouse Reeve
718744a92d Adds css animation for pending create status
Co-authored-by: Fabien Basmaison <contact@arkhi.org>
2021-09-10 08:30:28 -07:00
Mouse Reeve
136cc1a6e9 Adds spinner icon 2021-09-10 08:07:46 -07:00
Mouse Reeve
3c38a64a81 Return http responses for ajax requests 2021-09-10 08:03:22 -07:00
Mouse Reeve
909293bbb0 Re-adds error handling code written a while back
Co-authored-by: Fabien Basmaison <contact@arkhi.org>
2021-09-09 19:56:42 -07:00
Mouse Reeve
f9b9a66224 Linter appeasement 2021-09-09 17:07:48 -07:00
Mouse Reeve
9ba066ad6d Cleanup after submitting modal 2021-09-09 17:04:16 -07:00
Mouse Reeve
06b0325c1b Update dropdown options on shelve action 2021-09-09 16:43:47 -07:00
Mouse Reeve
9ee1a110a9 Update visible shelve buttons on read action 2021-09-09 15:36:58 -07:00
Mouse Reeve
5f584c1403 Lints for the Linter god 2021-09-09 08:24:36 -07:00
Mouse Reeve
055cced75b Close reply panel 2021-09-09 08:20:55 -07:00
Mouse Reeve
49f1226f3a Close modals after submit 2021-09-09 08:06:36 -07:00
Mouse Reeve
053e2cea0d Clear localstorage items 2021-09-09 07:39:38 -07:00
Mouse Reeve
dfaf085843 Move status code into the new file 2021-09-09 06:54:34 -07:00
Mouse Reeve
b0e7a5e468 Post statuses asynchronously 2021-09-08 19:30:45 -07:00
Mouse Reeve
c007f44030 Linter's have demands 2021-09-08 17:54:50 -07:00
Mouse Reeve
03b608565d Save status drafts in localstorage 2021-09-08 13:58:10 -07:00
Mouse Reeve
4570d042a9 Tooltip icon 2021-09-08 08:56:13 -07:00
Mouse Reeve
457415f874 Adds bookmark icon 2021-08-23 11:36:22 -07:00
Mouse Reeve
451cb38c6c Linter fix 2021-08-19 15:33:23 -07:00
Mouse Reeve
8ba695c21d Adds max height to modals so they don't disappear on small screens 2021-08-19 15:19:10 -07:00
Mouse Reeve
0829696add
Merge pull request #1138 from joachimesque/images-django-imagekit
Generate thumnails for books
2021-08-18 19:53:12 -06:00
Mouse Reeve
8b5ac6b012 Javascript linter 2021-08-17 09:28:39 -07:00
Mouse Reeve
3026a86b11 Refines preventDefault logic 2021-08-17 09:21:57 -07:00
Mouse Reeve
2f93017eaa Fixes event propogation 2021-08-17 08:45:10 -07:00
Mouse Reeve
011175a6e3 Appeases js linter 2021-08-16 12:44:36 -07:00
Mouse Reeve
e6b785d731 No-update mode for "want to read" 2021-08-16 12:28:04 -07:00
Mouse Reeve
45e82abda4
Merge branch 'main' into images-django-imagekit 2021-08-11 12:47:25 -06:00
Mouse Reeve
21a954c7df Always use underscores in html ids
Plus some other shifting around
2021-08-08 19:44:12 -07:00
Mouse Reeve
b116df723f prevent large text from janking up view 2021-08-07 16:48:53 -07:00
Mouse Reeve
af34dc6520
Merge branch 'main' into images-django-imagekit 2021-08-02 13:43:59 -06:00
Kylie
a6b8d44627 Summary display updates 2021-07-31 20:30:21 -04:00
Kylie
f2186d6861 Add preserve-whitespace CSS tag 2021-07-31 13:15:49 -04:00
Joachim
e251b687dc Merge remote-tracking branch 'upstream/main' into images-django-imagekit 2021-06-19 19:32:56 +02:00
Mouse Reeve
973b23856c
Merge branch 'main' into opengraph-image-generation 2021-06-17 15:17:54 -07:00
Mouse Reeve
e65bc09e7a Linter fixes 2021-06-08 12:42:45 -07:00
Mouse Reeve
eb12506985 No script fallback mode 2021-06-08 12:40:01 -07:00
Mouse Reeve
bbbae9fc9d
Merge branch 'main' into images-django-imagekit 2021-06-05 11:46:57 -07:00
Mouse Reeve
ff45238667
Merge pull request #1123 from eatsleepdeploy/add-max-upload-size-config
Add max upload size config
2021-06-01 14:09:50 -07:00
Joachim
3ea935e7ce Update OFL.txt 2021-05-26 15:49:08 +02:00
Joachim
d4fc1b0fdf Fix line endings 2021-05-26 15:17:28 +02:00
Joachim
fa7334826c Update 2021-05-25 23:04:28 +02:00
Joachim
d1737b44bd First functioning commit
TODO

- [ ] Delay task (Celery?)
- [ ] Store the image in a subfolder unique to the edition, to make cleaning up the image easy
- [ ] Clean up the image before replacing it
- [ ] Ensure that the image will be cleaned when the edition is deleted ??
- [ ] Use instance custom colors?
- [ ] Use book cover color base?
2021-05-25 00:41:53 +02:00
Joachim
c1456ce853 Update .cover-caption name and styles 2021-05-24 16:16:33 +02:00
Joachim
251c8bbd08 Merge remote-tracking branch 'upstream/main' into list-style-fixes 2021-05-23 15:14:50 +02:00
Joachim
0708d64bf1 Update bookwyrm.css 2021-05-23 12:10:57 +02:00
Jason Kelly
7eb5f3b026 Making magic number more readable 2021-05-23 14:31:22 +08:00
Jason Kelly
6e655cb0e0 Added new widget to alert if a file is set at larger than 10 MB.
- Updated default widget to use template that adds a notification box.
- Added JS to add onchange & load events to look at the value in the input and trigger the notification & disable the form submits.
2021-05-23 14:12:00 +08:00
Mouse Reeve
b8e9b9f57e Cleans up show/hide behavior 2021-05-20 11:46:24 -07:00
Joachim
1f747e4f68
Merge branch 'main' into list-style-fixes 2021-05-05 16:06:48 +02:00
Joachim
4c021e6357 Add Mobile styles 2021-05-02 21:34:43 +02:00
Mouse Reeve
454dd25681 Only make notification count red for mentions 2021-04-30 07:49:34 -07:00
Joachim
bbac0ad7ab Update bookwyrm.css 2021-04-29 21:51:42 +02:00
Joachim
d4dffe48a7 Update bookwyrm.css 2021-04-29 21:48:35 +02:00
Joachim
fa17386a6e Fix 2021-04-29 21:45:48 +02:00
Joachim
0a71fb094f Move counter in Ordered List 2021-04-29 21:41:43 +02:00
Fabien Basmaison
e37cbcd88d cover: Comment CSS rules a bit more and add rules for consistency. 2021-04-28 15:02:47 +02:00
Fabien Basmaison
bba60c99e9 cover: Rearrange some CSS rules. 2021-04-28 14:48:25 +02:00
Fabien Basmaison
baaaeef4c0 cover: Fix little details. 2021-04-28 10:47:14 +02:00
Fabien Basmaison
8a1c8cb061 cover: Update goal:
- Remove `.content` from template when not dealing with markdown-generated markup.
- Fix some duplicated CSS selectors.
2021-04-27 21:07:54 +02:00
Fabien Basmaison
a5359d1f80 cover: Update author. 2021-04-27 20:30:10 +02:00
Fabien Basmaison
d8b6676976 cover: Udpate logged out home and discover. 2021-04-27 16:27:39 +02:00
Fabien Basmaison
8ddc292ee6 cover: Change the logic again:
- Work on feeds.
- Add `.is-cover` to modify the behaviours of columns.
- Only apply logic for dimensions on the cover container; too many contextual side effects otherwise.
- Add classes to dimension and align, including auto margins for flex.
- Rename classes in templates accordingly.
2021-04-27 16:24:20 +02:00
Fabien Basmaison
b089f6c86a Update Bulma from v0.9.1 to v0.9.2. 2021-04-26 15:20:48 +02:00
Fabien Basmaison
26cacf502c Rationalise behaviours of context, container and cover:
- Set minimum dimensions to avoid having to pass classes all over the place.
- Outline the container to show white on white covers properly.
- Remove extraneous code.
- Better size caption when no cover is available.
- Create Alignments, Positions and Spacings sections and move some existing dimensions.
- Update previous templates.
2021-04-26 13:39:17 +02:00
Fabien Basmaison
30bed6c963 Merge branch 'main' into frontend-book-cover 2021-04-26 11:35:10 +02:00
Joachim
e92166c7f7 Directory: Homogenize cards heights
When the content of a profile card stretches it in height, the grid is not homogenous. This PR adds a CSS class that'll display cards as stretchable columns. The card content will be able to grow, which should always place the card footer at the bottom of the card.
2021-04-25 20:05:31 +02:00
Mouse Reeve
2fd8e12b96
Merge pull request #974 from joachimesque/list-table
Add mobile styles for book preview table
2021-04-25 10:42:27 -07:00
Fabien Basmaison
a268f339c0 Fix linting issues. 2021-04-25 15:45:49 +02:00
Fabien Basmaison
953dff90bb cover: tweak styles:
- `optimizeQuality` > `smooth` (CSS language evolution)
- Use `auto` instead of a fixed width.
- Add exceptions for heights and apply them to some previously modified templates.
- Remove `is-large` exception.
- Widen the content column on list curation.
2021-04-25 15:37:46 +02:00
Fabien Basmaison
23985e4357 Merge branch 'main' into frontend-book-cover 2021-04-25 11:24:21 +02:00
Fabien Basmaison
cf5a4ebe90 Fix typo:
Addresses https://github.com/bookwyrm-social/bookwyrm/pull/994#discussion_r619688900.
2021-04-24 21:27:05 +02:00
Fabien Basmaison
eea8b4e750 cover: Handle covers with specific heights:
- Have an explicit contextual class on `cover-container`.
- Use more flexible, consistent and searchable variable name for passing classes to covers.
- Consistently use `'…'` with django variables.
- Give the option to not hide covers to screen readers.
- consitently give a title to the cover container if `alt_text` exists.
- [lists] Remove `.content` which is applying too extensive default styles.
2021-04-24 21:27:05 +02:00
Joachim
e06154c457
Merge branch 'main' into smaller-statuses-dense-cards 2021-04-24 20:07:13 +02:00
Fabien Basmaison
32fb06c9e6 Prevent stars from wrapping on multiple lines. 2021-04-24 13:23:03 +02:00
Fabien Basmaison
7f0b3184a1 cover: Use book-cover as component:
- Avoid specifying context-dependent values in CSS for components. Those values can be defined by the context calling the component.
- Use `<figure>` with optional caption.
- Reduce redundant markup.
- Allow more variables to be passed to the book-cover (image path and class for the container).
- Hide the book cover to screen readers.
2021-04-24 12:48:55 +02:00
Mouse Reeve
c6e8161a9f Removes scroll padding 2021-04-22 13:08:22 -07:00
Joachim
15c7a1dc82 Update bookwyrm.css 2021-04-22 20:57:24 +02:00
Joachim
2749e6ad95 Fix CSS for linter 2021-04-21 22:36:07 +02:00
Joachim
0b0a283e64 Fix buttons styles 2021-04-21 22:32:14 +02:00
Joachim
e4836bd9b3 Fix for lint 2021-04-21 21:29:28 +02:00
Joachim
2ae9085e55 Vertically align cells in desktop view 2021-04-21 21:26:20 +02:00
Joachim
482774f1e1 Add mobile styles for book preview table 2021-04-21 21:25:37 +02:00
Joachim
71390f1735 Set body height 2021-04-15 21:51:14 +02:00
Fabien Basmaison
e016006ade [css] Rename all classes consistently: :shamed:
This commit addresses https://github.com/mouse-reeve/bookwyrm/pull/883#pullrequestreview-632930445.
2021-04-10 19:51:18 +02:00
Fabien Basmaison
b92ff9752d [assets] Remove UI and behaviours for interactions:
This commit addresses https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609739553.
2021-04-08 17:37:29 +02:00
Fabien Basmaison
2f90b4ce66 [assets] Fix broken actions for focus and checkbox:
This commit should address the following two comments:

- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609172258
- https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609174513
2021-04-08 11:37:14 +02:00
Fabien Basmaison
83bd417878 [assets] Update interactions code:
This commit should address https://github.com/mouse-reeve/bookwyrm/pull/883#discussion_r609381969.

- Disable the button being used to submit the form.
- Rename variables based on @mouse-reeve’s explanations. Thanks! 
2021-04-08 11:08:13 +02:00
Fabien Basmaison
be0cabc415 [css] Improve quotes. 2021-04-07 18:07:32 +02:00
Fabien Basmaison
2a0924027b [css] Use more visible comments to split blocks. 2021-04-07 17:33:28 +02:00
Fabien Basmaison
f77088b964 [assets] Remove redundant class already provided by bulma:
Replace all classes `hidden` with `is-hidden` in templates, CSS and JS.
2021-04-07 17:31:00 +02:00
Fabien Basmaison
f2a2b410a1 [assets] Add comment to mention replacing font icons with SVG. 2021-04-07 10:49:52 +02:00
Fabien Basmaison
54805afb51 [assets] Tweak JSDoc. 2021-04-07 10:37:11 +02:00
Fabien Basmaison
5d569e8926 [assets] Only update status if the promise is successful:
- Use promises in `ajaxPost` and `interact`.
- Add some animations in CSS.
2021-04-07 09:24:34 +02:00
Fabien Basmaison
1c05107f2b [assets] Tweak comments. 2021-04-07 07:53:30 +02:00
Fabien Basmaison
44040201f9 [assets] Move interact function. 2021-04-06 17:57:39 +02:00
Fabien Basmaison
9d95f54aa2 [assets] Refactor toggleAction and toggleMenu a bit. 2021-04-06 17:48:56 +02:00
Fabien Basmaison
52d2f0e331 [assets] Document functions and variables:
- Use expressive names for variables.
- Add docblocks for each function.
- Add ESLint rules for comments.
2021-04-06 16:17:20 +02:00
Fabien Basmaison
5d3d00f694 [assets] Use dataset + use expressive names for some variables. 2021-04-06 15:36:34 +02:00
Fabien Basmaison
62fe2ef600 [assets] Replace inline events with addEventListener; this breaks sliding menu. 2021-04-06 11:37:23 +02:00
Fabien Basmaison
7e49b3cb26 [assets] Simplify addRemoveClass function. 2021-04-06 11:19:44 +02:00
Fabien Basmaison
70c652d565 [assets] Add rules to ESLint:
- Fix long line.
- Enforce a few stylistic habits:

    - Avoid some potential dangerous constructs.
    - `arrow-spacing`: Use at least one space around arrows.
    - `keyword-spacing`: Use at least one space around keywords (if, else, for…).
    - `no-multiple-empty-lines`: Only use one empty line between code.
	- `no-var`: Use `let` or `const` instead of `var`:
    - `padded-blocks`: Do not pad blocks.
    - `padding-line-between-statements`: Use empty lines between some statements.
    - `space-before-blocks`: Use at least one space before the opening brace of a block.
2021-04-06 10:42:52 +02:00
Fabien Basmaison
991d897ac7 [assets] Listen to events as soon as possible. 2021-04-06 09:57:52 +02:00
Fabien Basmaison
2f2f7db086 [assets] Use classes for JS files:
- Classes strictly parse code implicitly.
- Fix previously updated code.
2021-04-06 09:44:59 +02:00
Fabien Basmaison
f430363be0 [assets] Simplify a function expression. 2021-04-06 09:11:56 +02:00
Fabien Basmaison
f6c3e581b9 [assets] Replace Array.from(document.getElementsByClassName(…)) by querySelectorAll(…). 2021-04-06 09:11:27 +02:00
Fabien Basmaison
6b0a3ce4b1 [assets] Move localStorage chunks of code to their own file:
This should prevent a sync issue with updateDisplay not always being loaded on time.
2021-04-06 09:06:51 +02:00
Fabien Basmaison
964b47ea97 [assets] Fix path for icomoon font. 2021-04-05 16:46:30 +02:00
Fabien Basmaison
cbed5e331b [assets] Move some frontend assets to _vendor_ directories:
This simplifies linting of files we have no grasp on, and clarifies responsibilities.

- Add .eslintignore.
- Restrict linting to bookwyrm/static.
2021-04-05 16:17:11 +02:00
Fabien Basmaison
5aea7343b4 [assets] Rename some files for consistency. 2021-04-05 16:16:48 +02:00
Fabien Basmaison
6971c9b133 [assets] Move toggleAllCheckboxes code to its own file. 2021-04-05 16:16:05 +02:00
Mouse Reeve
abd6a78295
Merge pull request #862 from mouse-reeve/disabled-link
Valid html solution to disabling pagination links
2021-04-04 10:59:22 -07:00
Fabien Basmaison
485b0fa0f3 Simplify rating form:
- Create a snippet to regroup similar code.
- Reduce and document tricky logic of CSS.
- Add i18n strings.
2021-04-04 15:08:42 +02:00