Fabien Basmaison
dab6592c12
Testing moving a comment to see what accesslint says.
2021-03-04 20:38:28 +01:00
Fabien Basmaison
16ea657b5b
[a11y] Add aria-modal:
...
- Addresses https://github.com/mouse-reeve/bookwyrm/pull/680#issuecomment-790603940
2021-03-04 20:14:38 +01:00
Fabien Basmaison
8c26d8a514
[profile] Updates for PR:
...
- Fix duplicated IDs between modals for the same status.
- Remove redundant button (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586743844 ).
- Remove redundant `role="navigation"` on `<nav>`.
- Add `dir="auto"` back for titles (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586715693 ).
- Use `exists` instead of `all` for conditional statement (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586716299 ).
- Fix missing spacing between avatar and username (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586740902 ).
2021-03-03 22:58:01 +01:00
Fabien Basmaison
a05b14c338
[profile] Various HTML fixes:
...
- Wrap block level elements within block level elements, not inline.
- Avoid empty blocks.
- Change `<hr>` in lists into allowed type of children.
- Fix duplicated ID (some change that was not propagated across the template?).
- Make the anchor optional in the navbar (interactive elements (`a`, `input`, `button`…) should not appear into other interactive elements).
- Remove redundant `role` on main navigation.
- Make the modal a modal with `role="dialog".
- Use `button` instead of form-less `label`.
2021-03-03 20:10:09 +01:00
Mouse Reeve
b9bf65ad2a
Adds missing i18n imports
2021-02-28 17:52:48 -08:00
Mouse Reeve
6a18803417
Catches more template translation moments
2021-02-28 17:10:30 -08:00
Mouse Reeve
485de039cf
Merge branch 'main' into shelve-buttons
2021-02-09 13:28:00 -08:00
Mouse Reeve
6ce4be7406
Adds inline form component
2021-02-03 12:25:33 -08:00
Mouse Reeve
e5fd14b206
Confirmation modal for to-read shelve action
2021-01-30 13:11:43 -08:00
Mouse Reeve
6ccf7841e1
Moves components out of snippets
2021-01-29 08:51:36 -08:00
