Commit graph

14 commits

Author SHA1 Message Date
Mouse Reeve
30bf84fe7b Adds aria-described-by to modal component 2021-12-31 10:39:18 -08:00
Mouse Reeve
2f4899dc1f Remove old modal, new modal is our best friend now 2021-12-30 19:19:55 -08:00
Mouse Reeve
99904618ac Fixes close buttons on modals 2021-09-05 15:24:09 -07:00
Mouse Reeve
21a954c7df Always use underscores in html ids
Plus some other shifting around
2021-08-08 19:44:12 -07:00
Mouse Reeve
1231d40e80 Want to read view 2021-06-08 11:23:53 -07:00
Joachim
6f105fcdcc Front: Modal title fit 2021-06-02 18:56:24 +02:00
Fabien Basmaison
f77088b964 [assets] Remove redundant class already provided by bulma:
Replace all classes `hidden` with `is-hidden` in templates, CSS and JS.
2021-04-07 17:31:00 +02:00
Mouse Reeve
a952d59eb8 Fixes translation on modal close labels 2021-04-01 13:15:21 -07:00
Fabien Basmaison
dab6592c12 Testing moving a comment to see what accesslint says. 2021-03-04 20:38:28 +01:00
Fabien Basmaison
16ea657b5b [a11y] Add aria-modal:
- Addresses https://github.com/mouse-reeve/bookwyrm/pull/680#issuecomment-790603940
2021-03-04 20:14:38 +01:00
Fabien Basmaison
8c26d8a514 [profile] Updates for PR:
- Fix duplicated IDs between modals for the same status.
- Remove redundant button (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586743844).
- Remove redundant `role="navigation"` on `<nav>`.
- Add `dir="auto"` back for titles (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586715693).
- Use `exists` instead of `all` for conditional statement (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586716299).
- Fix missing spacing between avatar and username (https://github.com/mouse-reeve/bookwyrm/pull/680#discussion_r586740902).
2021-03-03 22:58:01 +01:00
Fabien Basmaison
a05b14c338 [profile] Various HTML fixes:
- Wrap block level elements within block level elements, not inline.
- Avoid empty blocks.
- Change `<hr>` in lists into allowed type of children.
- Fix duplicated ID (some change that was not propagated across the template?).
- Make the anchor optional in the navbar (interactive elements (`a`, `input`, `button`…) should not appear into other interactive elements).
- Remove redundant `role` on main navigation.
- Make the modal a modal with `role="dialog".
- Use `button` instead of form-less `label`.
2021-03-03 20:10:09 +01:00
Mouse Reeve
e5fd14b206 Confirmation modal for to-read shelve action 2021-01-30 13:11:43 -08:00
Mouse Reeve
6ccf7841e1 Moves components out of snippets 2021-01-29 08:51:36 -08:00
Renamed from bookwyrm/templates/snippets/components/modal.html (Browse further)