Deduplicate notifications in notification model

bookwyrm/models/favorite.py

@@ -26,11 +26,6 @@ class Favorite(ActivityMixin, BookWyrmModel):
         if self.status.user.local and self.status.user != self.user:
             notification_model = apps.get_model(
                 'bookwyrm.Notification', require_ready=True)
-            if notification_model.objects.filter(
-                    user=self.status.user, related_user=self.user,
-                    related_status=self.status, notification_type='FAVORITE'
-                ).exists():
-                return
             notification_model.objects.create(
                 user=self.status.user,
                 notification_type='FAVORITE',

bookwyrm/models/import_job.py

@@ -64,7 +64,6 @@ class ImportJob(models.Model):
             )
 
 
-
 class ImportItem(models.Model):
     ''' a single line of a csv being imported '''
     job = models.ForeignKey(

bookwyrm/models/notification.py

@@ -25,6 +25,21 @@ class Notification(BookWyrmModel):
     notification_type = models.CharField(
         max_length=255, choices=NotificationType.choices)
 
+    def save(self, *args, **kwargs):
+        ''' save, but don't make dupes '''
+        # there's probably a better way to do this
+        if self.__class__.objects.filter(
+                user=self.user,
+                related_book=self.related_book,
+                related_user=self.related_user,
+                related_status=self.related_status,
+                related_import=self.related_import,
+                related_list_item=self.related_list_item,
+                notification_type=self.notification_type,
+            ).exists():
+            return
+        super().save(*args, **kwargs)
+
     class Meta:
         ''' checks if notifcation is in enum list for valid types '''
         constraints = [

bookwyrm/models/status.py

@@ -276,11 +276,6 @@ class Boost(ActivityMixin, Status):
 
         notification_model = apps.get_model(
             'bookwyrm.Notification', require_ready=True)
-        if notification_model.objects.filter(
-                user=self.boosted_status.user,
-                related_status=self.boosted_status,
-                related_user=self.user, notification_type='BOOST').exists():
-            return
         notification_model.objects.create(
             user=self.boosted_status.user,
             related_status=self.boosted_status,

bookwyrm/tests/views/test_notifications.py

@@ -30,7 +30,7 @@ class NotificationViews(TestCase):
     def test_clear_notifications(self):
         ''' erase notifications '''
         models.Notification.objects.create(
-            user=self.local_user, notification_type='MENTION')
+            user=self.local_user, notification_type='FAVORITE')
         models.Notification.objects.create(
             user=self.local_user, notification_type='MENTION', read=True)
         self.assertEqual(models.Notification.objects.count(), 2)