rafaelcaricio/moviewyrm
1
0
Fork 0
forked from mirrors/bookwyrm
Code Issues 4 Pull requests Projects Releases Wiki Activity

Fixes missing f format in preview image string

Browse source 
plus a unit test for it
This commit is contained in:
Mouse Reeve 2021-09-20 17:40:59 -07:00
parent 1be33c97a2
commit 90c74f00c9
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
bookwyrm/preview_images.py
View file

@ -415,7 +415,7 @@ def generate_user_preview_image_task(user_id):
texts = { texts = {
"text_one": user.display_name, "text_one": user.display_name,
"text_three": "@{user.localname}@{settings.DOMAIN}", "text_three": f"@{user.localname}@{settings.DOMAIN}",
} }
if user.avatar: if user.avatar:

9
bookwyrm/tests/test_preview_images.py
View file

@ -20,6 +20,7 @@ from bookwyrm.preview_images import (
# pylint: disable=unused-argument # pylint: disable=unused-argument
# pylint: disable=missing-function-docstring # pylint: disable=missing-function-docstring
# pylint: disable=consider-using-with
class PreviewImages(TestCase): class PreviewImages(TestCase):
"""every response to a get request, html or json""" """every response to a get request, html or json"""
@ -120,3 +121,11 @@ class PreviewImages(TestCase):
self.assertEqual( self.assertEqual(
self.local_user.preview_image.height, settings.PREVIEW_IMG_HEIGHT self.local_user.preview_image.height, settings.PREVIEW_IMG_HEIGHT
) )
def test_generate_user_preview_images_task(self, *args, **kwargs):
"""test task's external calls"""
with patch("bookwyrm.preview_images.generate_preview_image") as generate_mock:
generate_user_preview_image_task(self.local_user.id)
args = generate_mock.call_args.kwargs
self.assertEqual(args["texts"]["text_one"], "possum")
self.assertEqual(args["texts"]["text_three"], f"@possum@{settings.DOMAIN}")