rafaelcaricio/moviewyrm
1
0
Fork 0
forked from mirrors/bookwyrm
Code Issues 4 Pull requests Projects Releases Wiki Activity

forceReload prevents ajax submission

Browse source 
...instead of weird hacky workarounds forcing refreshes later.
This commit is contained in:
Hugh Rundle 2021-11-25 19:12:03 +11:00
parent b91915d316
commit 5b67226571
No known key found for this signature in database
GPG key ID: CD23D6039184286B
4 changed files with 1 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
bookwyrm/static/js/status_cache.js
View file

@ -74,7 +74,7 @@ let StatusCache = new class {
// This allows the form to submit in the old fashioned way if there's a problem
if (!trigger || !form) {
if (!trigger || !form || response.headers.get("forceReload")) {
return;
}
@ -90,12 +90,6 @@ let StatusCache = new class {
trigger.removeAttribute('disabled');
})
.then(response => {
if (response.headers.get("forceReload")) {
BookWyrm.addRemoveClass(form, 'is-processing', true);
trigger.setAttribute('disabled', null);
return location.reload();
}
if (!response.ok) {
throw new Error();

2
bookwyrm/views/reading.py
View file

@ -102,8 +102,6 @@ class ReadingStatus(View):
!= desired_shelf.identifier
):
return unshelve(request, referer=referer, book_id=book_id)
# don't try to unshelve a read status shelf: it has already been deleted.
return HttpResponse(headers={"forceReload": "true"})
if is_api_request(request):
return HttpResponse()

2
bookwyrm/views/shelf/shelf_actions.py
View file

@ -101,6 +101,4 @@ def unshelve(request, referer=None, book_id=False):
)
shelf_book.raise_not_deletable(request.user)
shelf_book.delete()
if bool(referer):
return HttpResponse(headers={"forceReload": "true"})
return redirect(request.headers.get("Referer", "/"))

4
bookwyrm/views/status.py
View file

@ -125,10 +125,6 @@ class CreateStatus(View):
except Http404:
pass
# force page reload if this was triggered from 'move' button
if bool(request.POST.get("shelf")):
return HttpResponse(headers={"forceReload": "true"})
if is_api_request(request):
return HttpResponse()
return redirect("/")