rafaelcaricio/moviewyrm
1
0
Fork 0
forked from mirrors/bookwyrm
Code Issues 4 Pull requests Projects Releases Wiki Activity

Make get_rank() a regular method

Browse source 
It doesn't act like a property, and we have edition_rank as a proper
property anyway
This commit is contained in:
Joel Bradshaw 2021-01-13 18:43:05 -08:00
parent ec2a43faa5
commit 0b703a252b
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bookwyrm/models/book.py
View file

@ -178,7 +178,6 @@ class Edition(Book):
activity_serializer = activitypub.Edition activity_serializer = activitypub.Edition
name_field = 'title' name_field = 'title'
@property
def get_rank(self): def get_rank(self):
''' calculate how complete the data is on this edition ''' ''' calculate how complete the data is on this edition '''
if self.parent_work and self.parent_work.default_edition == self: if self.parent_work and self.parent_work.default_edition == self:
@ -204,7 +203,7 @@ class Edition(Book):
self.isbn_13 = isbn_10_to_13(self.isbn_10) self.isbn_13 = isbn_10_to_13(self.isbn_10)
# set rank # set rank
self.edition_rank = self.get_rank self.edition_rank = self.get_rank()
return super().save(*args, **kwargs) return super().save(*args, **kwargs)