rafaelcaricio/lvgl-rs
1
0
Fork 0
Code Issues 12 Pull requests 2 Projects Releases 4 Wiki Activity

Fix lvgl-sys not respecting DEP_LV_CONFIG_PATH #45

Merged
Spadi0 merged 1 commit from fix-lv-conf-include into master 2021-05-19 12:24:01 +00:00
Conversation 0 Commits 1 Files changed 3 +3 -3
Spadi0 commented 2021-05-19 09:01:53 +00:00 (Migrated from github.com)
Copy link

Previously, the vendored lv_conf.h file was always before the DEP_LV_CONFIG_PATH environment variable in the include path (lvgl-sys/vendor), meaning that it was always used. This caused the environment variable to always be ignored. This PR moves the vendored config file to its own directory (lvgl-sys/vendor/include/lv_conf.h) so that the DEP_LV_CONFIG_PATH environment variable is properly used.

This also requires changing the basic_sanity_check test to check against the horizontal and vertical resolution defined in the config file, not against a hard-coded value of 240.

Previously, the vendored `lv_conf.h` file was always before the `DEP_LV_CONFIG_PATH` environment variable in the include path (`lvgl-sys/vendor`), meaning that it was always used. This caused the environment variable to always be ignored. This PR moves the vendored config file to its own directory (`lvgl-sys/vendor/include/lv_conf.h`) so that the `DEP_LV_CONFIG_PATH` environment variable is properly used. This also requires changing the `basic_sanity_check` test to check against the horizontal and vertical resolution defined in the config file, not against a hard-coded value of `240`.
rafaelcaricio (Migrated from github.com) approved these changes 2021-05-19 12:05:55 +00:00
rafaelcaricio (Migrated from github.com) left a comment
Copy link

Thank you!!!! 😊

Thank you!!!! 😊
Sign in to join this conversation.
Reviewers
No reviewers
rafaelcaricio
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: rafaelcaricio/lvgl-rs#45
No description provided.
Delete branch "fix-lv-conf-include"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?