gstreamer-rs/gstreamer-rtp/src/rtp_header_extension.rs
Sebastian Dröge 28fe70f479 rtpheaderextension: Don't pass a mutable output buffer reference to write()
The extension is only supposed to use it for potentially reading metas
from it, and `GstRTPBasePay` is currently passing the same buffer as the
one that owns the data so we currently end up with the possibility to
e.g. resize the buffer which would invalidate the data.

This change prevents at least the biggest problems, but would still
allow getting an immutable and mutable reference to the same data with a
bit of effort.

See also https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/375

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1399>
2024-02-22 12:17:13 +02:00

91 lines
2.8 KiB
Rust

use glib::{object::IsA, translate::*};
use crate::{RTPHeaderExtension, RTPHeaderExtensionFlags};
mod sealed {
pub trait Sealed {}
impl<T: super::IsA<super::RTPHeaderExtension>> Sealed for T {}
}
pub trait RTPHeaderExtensionExtManual: sealed::Sealed + IsA<RTPHeaderExtension> + 'static {
#[doc(alias = "gst_rtp_header_extension_read")]
fn read(
&self,
read_flags: RTPHeaderExtensionFlags,
data: &[u8],
buffer: &mut gst::BufferRef,
) -> bool {
let size = data.len();
unsafe {
from_glib(ffi::gst_rtp_header_extension_read(
self.as_ref().to_glib_none().0,
read_flags.into_glib(),
data.to_glib_none().0,
size,
buffer.as_mut_ptr(),
))
}
}
#[doc(alias = "gst_rtp_header_extension_write")]
fn write(
&self,
input_meta: &gst::Buffer,
write_flags: RTPHeaderExtensionFlags,
output: &gst::BufferRef,
data: &mut [u8],
) -> Result<usize, glib::BoolError> {
let size = data.len();
unsafe {
let res = ffi::gst_rtp_header_extension_write(
self.as_ref().to_glib_none().0,
input_meta.to_glib_none().0,
write_flags.into_glib(),
mut_override(output.as_ptr()),
data.to_glib_none().0,
size,
);
if res < 0 {
Err(glib::bool_error!("Failed to write header extension"))
} else {
Ok(res as usize)
}
}
}
#[doc(alias = "gst_rtp_header_extension_set_caps_from_attributes")]
fn set_caps_from_attributes(&self, caps: &mut gst::CapsRef) -> bool {
unsafe {
from_glib(ffi::gst_rtp_header_extension_set_caps_from_attributes(
self.as_ref().to_glib_none().0,
caps.as_mut_ptr(),
))
}
}
#[doc(alias = "gst_rtp_header_extension_set_caps_from_attributes_helper")]
fn set_caps_from_attributes_helper(&self, caps: &mut gst::CapsRef, attributes: &str) -> bool {
unsafe {
from_glib(
ffi::gst_rtp_header_extension_set_caps_from_attributes_helper(
self.as_ref().to_glib_none().0,
caps.as_mut_ptr(),
attributes.to_glib_none().0,
),
)
}
}
#[doc(alias = "gst_rtp_header_extension_update_non_rtp_src_caps")]
fn update_non_rtp_src_caps(&self, caps: &mut gst::CapsRef) -> bool {
unsafe {
from_glib(ffi::gst_rtp_header_extension_update_non_rtp_src_caps(
self.as_ref().to_glib_none().0,
caps.as_mut_ptr(),
))
}
}
}
impl<O: IsA<RTPHeaderExtension>> RTPHeaderExtensionExtManual for O {}