rafaelcaricio/gstreamer-rs
1
0
Fork 0
forked from mirrors/gstreamer-rs
Code Pull requests Activity

gstreamer/element: Use from_glib_none() for the release_pad() trampoline

Browse source 
The reference to the pad we get passed is not guaranteed to be valid for
the whole scope of release_pad(). It might be the last reference as
owned by GstElement, and gst_element_remove_pad() would destroy it then.
This commit is contained in:
Sebastian Dröge 2019-08-14 11:58:05 +03:00
parent 2829c7ee2f
commit e00781309b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gstreamer/src/subclass/element.rs
View file

@ -373,7 +373,7 @@ unsafe extern "C" fn element_release_pad<T: ObjectSubclass>(
let wrap: Element = from_glib_borrow(ptr);
gst_panic_to_error!(&wrap, &instance.panicked(), (), {
imp.release_pad(&wrap, &from_glib_borrow(pad))
imp.release_pad(&wrap, &from_glib_none(pad))
})
}