rafaelcaricio/gstreamer-rs
1
0
Fork 0
forked from mirrors/gstreamer-rs
Code Pull requests Activity

pbutils/encoding_profile: Prevent copies by taking data by value

Browse source
This commit is contained in:
SeaDve 2022-09-20 08:33:42 +08:00 committed by Sebastian Dröge
parent 238f9baee5
commit d8a57e6d4a
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gstreamer-pbutils/src/encoding_profile.rs
View file

@ -443,7 +443,7 @@ macro_rules! declare_encoding_profile_builder_common(
fn set_common_fields<T: EncodingProfileBuilderCommon>( fn set_common_fields<T: EncodingProfileBuilderCommon>(
profile: &T, profile: &T,
base_data: &EncodingProfileBuilderCommonData, base_data: EncodingProfileBuilderCommonData,
) { ) {
skip_assert_initialized!(); skip_assert_initialized!();
profile.set_name(base_data.name); profile.set_name(base_data.name);
@ -459,8 +459,9 @@ fn set_common_fields<T: EncodingProfileBuilderCommon>(
} }
#[cfg(feature = "v1_20")] #[cfg(feature = "v1_20")]
{ {
if let Some(ref element_properties) = base_data.element_properties { let mut base_data = base_data;
profile.set_element_properties(element_properties.clone()); if let Some(element_properties) = base_data.element_properties.take() {
profile.set_element_properties(element_properties);
} }
} }
} }
@ -498,7 +499,7 @@ impl<'a> EncodingAudioProfileBuilder<'a> {
self.base.presence, self.base.presence,
); );
set_common_fields(&profile, &self.base); set_common_fields(&profile, self.base);
profile profile
} }
@ -556,7 +557,7 @@ impl<'a> EncodingVideoProfileBuilder<'a> {
video_profile.set_pass(self.pass); video_profile.set_pass(self.pass);
video_profile.set_variableframerate(self.variable_framerate); video_profile.set_variableframerate(self.variable_framerate);
set_common_fields(&video_profile, &self.base); set_common_fields(&video_profile, self.base);
video_profile video_profile
} }
@ -593,7 +594,7 @@ impl<'a> EncodingContainerProfileBuilder<'a> {
container_profile.add_profile(&profile); container_profile.add_profile(&profile);
} }
set_common_fields(&container_profile, &self.base); set_common_fields(&container_profile, self.base);
container_profile container_profile
} }