Silence/fix various clippy warnings

.gitlab-ci.yml

@@ -345,7 +345,7 @@ clippy:
   extends: .img-stable
   stage: 'extras'
   variables:
-    CLIPPY_LINTS: -A clippy::missing_safety_doc -A clippy::manual_range_contains -A clippy::upper_case_acronyms -D warnings
+    CLIPPY_LINTS: -A clippy::missing_safety_doc -A clippy::manual_range_contains -A clippy::upper_case_acronyms -A clippy::wrong_self_convention -D warnings
   script:
     - cargo clippy --version
       # Keep features in sync with above

gstreamer-audio/src/audio_format.rs

@@ -363,9 +363,7 @@ mod tests {
         assert_eq!(count, crate::AudioFormat::iter_raw().len());
 
         assert!(crate::AudioFormat::iter_raw().any(|f| f == crate::AudioFormat::F64be));
-        assert!(crate::AudioFormat::iter_raw()
+        assert!(!crate::AudioFormat::iter_raw().any(|f| f == crate::AudioFormat::Encoded));
-            .find(|f| *f == crate::AudioFormat::Encoded)
-            .is_none());
 
         let caps = crate::AudioFormat::iter_raw().into_audio_caps(crate::AudioLayout::Interleaved);
         assert!(caps.is_some());

gstreamer-audio/src/audio_meta.rs

@@ -325,13 +325,13 @@ mod tests {
         {
             let cmeta = AudioLevelMeta::add(buffer.get_mut().unwrap(), 10, true);
             assert_eq!(cmeta.level(), 10);
-            assert_eq!(cmeta.voice_activity(), true);
+            assert!(cmeta.voice_activity());
         }
 
         {
             let cmeta = buffer.meta::<AudioLevelMeta>().unwrap();
             assert_eq!(cmeta.level(), 10);
-            assert_eq!(cmeta.voice_activity(), true);
+            assert!(cmeta.voice_activity());
         }
     }
 }

gstreamer-rtp/src/rtp_buffer.rs

@@ -425,7 +425,7 @@ mod tests {
         assert!(rtp_buffer.csrc(2).is_none());
 
         rtp_buffer.set_extension(true);
-        assert_eq!(rtp_buffer.is_extension(), true);
+        assert!(rtp_buffer.is_extension());
 
         assert_eq!(rtp_buffer.extension_bytes(), None);
     }

gstreamer-video/src/video_format.rs

@@ -506,9 +506,7 @@ mod tests {
         assert_eq!(count, crate::VideoFormat::iter_raw().len());
 
         assert!(crate::VideoFormat::iter_raw().any(|f| f == crate::VideoFormat::Nv12));
-        assert!(crate::VideoFormat::iter_raw()
+        assert!(!crate::VideoFormat::iter_raw().any(|f| f == crate::VideoFormat::Encoded));
-            .find(|f| *f == crate::VideoFormat::Encoded)
-            .is_none());
 
         let caps = crate::VideoFormat::iter_raw().into_video_caps();
         assert!(caps.is_some());

gstreamer/src/clock_time.rs

@@ -556,11 +556,11 @@ mod tests {
         assert!(ct_3 > ct_0);
         assert!(Some(ct_3) > Some(ct_0));
 
-        assert_eq!(opt_ct_none < None, false);
+        assert!(!(opt_ct_none < None));
-        assert_eq!(opt_ct_none > None, false);
+        assert!(!(opt_ct_none > None));
         // This doesn't work due to the `PartialOrd` impl on `Option<T>`
         //assert_eq!(Some(ct_0) > opt_ct_none, false);
-        assert_eq!(Some(ct_0) < opt_ct_none, false);
+        assert!(!(Some(ct_0) < opt_ct_none));
     }
 
     #[test]

gstreamer/src/event.rs

@@ -2021,7 +2021,7 @@ mod tests {
             .build();
         match flush_stop_evt.view() {
             EventView::FlushStop(flush_stop_evt) => {
-                assert_eq!(flush_stop_evt.resets_time(), true);
+                assert!(flush_stop_evt.resets_time());
                 assert!(flush_stop_evt.structure().is_some());
                 if let Some(other_fields) = flush_stop_evt.structure() {
                     assert!(other_fields.has_field("extra-field"));

gstreamer/src/subclass/element.rs

@@ -804,6 +804,6 @@ mod tests {
 
         let imp = imp::TestElement::from_instance(&element);
         assert_eq!(imp.n_buffers.load(atomic::Ordering::SeqCst), 100);
-        assert_eq!(imp.reached_playing.load(atomic::Ordering::SeqCst), true);
+        assert!(imp.reached_playing.load(atomic::Ordering::SeqCst));
     }
 }