rafaelcaricio/gstreamer-rs
1
0
Fork 0
forked from mirrors/gstreamer-rs
Code Pull requests Activity

utils: streamproducer: Remove StreamProducer::forward()

Browse source 
Most applications forget to call `forward()` in the beginning and then
nothing works.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/433

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/1189>
This commit is contained in:
Sebastian Dröge 2023-01-14 19:07:54 +02:00
parent f8d17555c5
commit a68c37e4eb
1 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gstreamer-utils/src/streamproducer.rs
View file

@ -181,13 +181,6 @@ impl StreamProducer {
} }
} }
/// Stop discarding data samples and start forwarding them to the consumers.
///
/// This is useful for example for prerolling live sources.
pub fn forward(&self) {
self.consumers.lock().unwrap().discard = false;
}
/// configure if EOS from appsrc should be forwarded to all the consumers /// configure if EOS from appsrc should be forwarded to all the consumers
pub fn set_forward_eos(&self, forward_eos: bool) { pub fn set_forward_eos(&self, forward_eos: bool) {
self.consumers.lock().unwrap().forward_eos = forward_eos; self.consumers.lock().unwrap().forward_eos = forward_eos;
@ -225,7 +218,6 @@ impl<'a> From<&'a gst_app::AppSink> for StreamProducer {
current_latency: None, current_latency: None,
latency_updated: false, latency_updated: false,
consumers: HashMap::new(), consumers: HashMap::new(),
discard: true,
forward_eos: true, forward_eos: true,
})); }));
@ -242,10 +234,6 @@ impl<'a> From<&'a gst_app::AppSink> for StreamProducer {
} }
}; };
if consumers.discard {
return Ok(gst::FlowSuccess::Ok);
}
let (is_discont, is_keyframe) = if let Some(buf) = sample.buffer() { let (is_discont, is_keyframe) = if let Some(buf) = sample.buffer() {
let flags = buf.flags(); let flags = buf.flags();
@ -385,8 +373,6 @@ struct StreamConsumers {
latency_updated: bool, latency_updated: bool,
/// The consumers, AppSrc pointer value -> consumer /// The consumers, AppSrc pointer value -> consumer
consumers: HashMap<gst_app::AppSrc, StreamConsumer>, consumers: HashMap<gst_app::AppSrc, StreamConsumer>,
/// Whether appsrc samples should be forwarded to consumers yet
discard: bool,
/// Whether appsrc EOS should be forwarded to consumers /// Whether appsrc EOS should be forwarded to consumers
forward_eos: bool, forward_eos: bool,
} }
@ -599,7 +585,6 @@ mod tests {
gst::init().unwrap(); gst::init().unwrap();
let (producer_pipe, producer_src, _producer_sink, producer) = create_producer(); let (producer_pipe, producer_src, _producer_sink, producer) = create_producer();
producer.forward();
producer_pipe producer_pipe
.set_state(gst::State::Playing) .set_state(gst::State::Playing)
.expect("Couldn't set producer pipeline state"); .expect("Couldn't set producer pipeline state");