rafaelcaricio/gstreamer-rs
1
0
Fork 0
forked from mirrors/gstreamer-rs
Code Pull requests Activity

gstreamer/object: Don't provide bindings for functions to modify an object name

Browse source 
It's generally not safe to change the object name after construction and
not really a good idea.
This commit is contained in:
Sebastian Dröge 2020-06-21 19:40:08 +03:00
parent 210e7c8777
commit 059dc5b2cb
2 changed files with 7 additions and 51 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Gir_Gst.toml
View file

@ -665,20 +665,19 @@ status = "generate"
trait_name = "GstObjectExt"
[[object.function]]
name = "set_name"
[object.function.return]
bool_return_is_error = "Failed to set object name"
# Don't allow changing the name at random times
ignore = true
[[object.property]]
name = "name"
# There are accessor functions for this
ignore = true
[[object.function]]
name = "get_name"
[object.function.return]
nullable = false
[[object.function]]
name = "set_name"
[[object.function.parameter]]
name = "name"
nullable = false
[[object.function]]
name = "get_path_string"
[object.function.return]

43
gstreamer/src/auto/object.rs
View file

@ -89,8 +89,6 @@ pub trait GstObjectExt: 'static {
fn set_control_rate(&self, control_rate: ClockTime);
fn set_name(&self, name: &str) -> Result<(), glib::error::BoolError>;
fn set_parent<P: IsA<Object>>(&self, parent: &P) -> Result<(), glib::error::BoolError>;
fn suggest_next_sync(&self) -> ClockTime;
@ -101,11 +99,6 @@ pub trait GstObjectExt: 'static {
//fn connect_deep_notify<Unsupported or ignored types>(&self, f: F) -> SignalHandlerId;
fn connect_property_name_notify<F: Fn(&Self) + Send + Sync + 'static>(
&self,
f: F,
) -> SignalHandlerId;
fn connect_property_parent_notify<F: Fn(&Self) + Send + Sync + 'static>(
&self,
f: F,
@ -238,15 +231,6 @@ impl<O: IsA<Object>> GstObjectExt for O {
}
}
fn set_name(&self, name: &str) -> Result<(), glib::error::BoolError> {
unsafe {
glib_result_from_gboolean!(
gst_sys::gst_object_set_name(self.as_ref().to_glib_none().0, name.to_glib_none().0),
"Failed to set object name"
)
}
}
fn set_parent<P: IsA<Object>>(&self, parent: &P) -> Result<(), glib::error::BoolError> {
unsafe {
glib_result_from_gboolean!(
@ -289,33 +273,6 @@ impl<O: IsA<Object>> GstObjectExt for O {
// Ignored prop: GObject.ParamSpec
//}
fn connect_property_name_notify<F: Fn(&Self) + Send + Sync + 'static>(
&self,
f: F,
) -> SignalHandlerId {
unsafe extern "C" fn notify_name_trampoline<P, F: Fn(&P) + Send + Sync + 'static>(
this: *mut gst_sys::GstObject,
_param_spec: glib_sys::gpointer,
f: glib_sys::gpointer,
) where
P: IsA<Object>,
{
let f: &F = &*(f as *const F);
f(&Object::from_glib_borrow(this).unsafe_cast_ref())
}
unsafe {
let f: Box_<F> = Box_::new(f);
connect_raw(
self.as_ptr() as *mut _,
b"notify::name\0".as_ptr() as *const _,
Some(transmute::<_, unsafe extern "C" fn()>(
notify_name_trampoline::<Self, F> as *const (),
)),
Box_::into_raw(f),
)
}
}
fn connect_property_parent_notify<F: Fn(&Self) + Send + Sync + 'static>(
&self,
f: F,