mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-12-23 08:56:29 +00:00
52d3652f2e
Use IDs of the forge to fetch repositories instead of their names and owner names. This improves handling of renamed and transferred repos. TODO - [ ] try to support as many forges as possible - [x] Gogs (no API) - [ ] Bitbucket Server - [x] Coding (no API?) - [x] update repo every time it is fetched or received from the forge - [x] if repo remote IDs are not available, use owner / name to get it - [x] handle redirections (redirect a renamed repo to its new path) - [x] ~~pull all repos once during migration to update ID (?)~~ issue fixed by on-demand loading of remote IDs - [x] handle redirections in web UI - [ ] improve handling of hooks after a repo was renamed (currently it checks for a redirection to the repo) - [x] tests - [x] `UNIQUE` constraint for remote IDs after migration shouldn't work (all repos have an empty string as remote ID) close #854 close #648 partial close https://codeberg.org/Codeberg-CI/feedback/issues/46 Possible follow-up PRs - apply the same scheme on everything fetched from the remote (currently only users) Co-authored-by: 6543 <6543@obermui.de>
119 lines
3.2 KiB
Go
119 lines
3.2 KiB
Go
// Copyright 2018 Drone.IO Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package shared
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/woodpecker-ci/woodpecker/server/model"
|
|
"github.com/woodpecker-ci/woodpecker/server/remote"
|
|
"github.com/woodpecker-ci/woodpecker/server/store"
|
|
)
|
|
|
|
// TODO(974) move to new package
|
|
|
|
// UserSyncer syncs the user repository and permissions.
|
|
type UserSyncer interface {
|
|
Sync(ctx context.Context, user *model.User) error
|
|
}
|
|
|
|
type Syncer struct {
|
|
Remote remote.Remote
|
|
Store store.Store
|
|
Perms model.PermStore
|
|
Match FilterFunc
|
|
}
|
|
|
|
// FilterFunc can be used to filter which repositories are
|
|
// synchronized with the local datastore.
|
|
type FilterFunc func(*model.Repo) bool
|
|
|
|
func NamespaceFilter(namespaces map[string]bool) FilterFunc {
|
|
if len(namespaces) == 0 {
|
|
return noopFilter
|
|
}
|
|
return func(repo *model.Repo) bool {
|
|
return namespaces[repo.Owner]
|
|
}
|
|
}
|
|
|
|
// noopFilter is a filter function that always returns true.
|
|
func noopFilter(*model.Repo) bool {
|
|
return true
|
|
}
|
|
|
|
// SetFilter sets the filter function.
|
|
func (s *Syncer) SetFilter(fn FilterFunc) {
|
|
s.Match = fn
|
|
}
|
|
|
|
func (s *Syncer) Sync(ctx context.Context, user *model.User, flatPermissions bool) error {
|
|
unix := time.Now().Unix() - (3601) // force immediate expiration. note 1 hour expiration is hard coded at the moment
|
|
repos, err := s.Remote.Repos(ctx, user)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
remoteRepos := make([]*model.Repo, 0, len(repos))
|
|
for _, repo := range repos {
|
|
if s.Match(repo) {
|
|
repo.Perm = &model.Perm{
|
|
UserID: user.ID,
|
|
RepoID: repo.ID,
|
|
Repo: repo,
|
|
Synced: unix,
|
|
}
|
|
|
|
// TODO(485) temporary workaround to not hit api rate limits
|
|
if flatPermissions {
|
|
if repo.Perm == nil {
|
|
repo.Perm.Pull = true
|
|
repo.Perm.Push = true
|
|
repo.Perm.Admin = true
|
|
}
|
|
} else {
|
|
remotePerm, err := s.Remote.Perm(ctx, user, repo)
|
|
if err != nil {
|
|
return fmt.Errorf("could not fetch permission of repo '%s': %v", repo.FullName, err)
|
|
}
|
|
repo.Perm.Pull = remotePerm.Pull
|
|
repo.Perm.Push = remotePerm.Push
|
|
repo.Perm.Admin = remotePerm.Admin
|
|
}
|
|
|
|
remoteRepos = append(remoteRepos, repo)
|
|
}
|
|
}
|
|
|
|
err = s.Store.RepoBatch(remoteRepos)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// this is here as a precaution. I want to make sure that if an api
|
|
// call to the version control system fails and (for some reason) returns
|
|
// an empty list, we don't wipe out the user repository permissions.
|
|
//
|
|
// the side-effect of this code is that a user with 1 repository whose
|
|
// access is removed will still display in the feed, but they will not
|
|
// be able to access the actual repository data.
|
|
if len(repos) == 0 {
|
|
return nil
|
|
}
|
|
|
|
return s.Perms.PermFlush(user, unix)
|
|
}
|