mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-07-04 04:56:02 +00:00
bffc9c8ff8
Fix Issue: https://github.com/woodpecker-ci/woodpecker/issues/3288 The way the pod service starts up makes it impossible to run two or more pipelines at the same time when we have a service section. The idea is to set the name of the service in the same way we did for the pod name. Pipeline: ```yaml services: mydb: image: mysql environment: - MYSQL_DATABASE=test - MYSQL_ROOT_PASSWORD=example ports: - 3306/tcp steps: get-version: image: ubuntu commands: - ( apt update && apt dist-upgrade -y && apt install -y mysql-client 2>&1 )> /dev/null - sleep 30s # need to wait for mysql-server init - echo 'SHOW VARIABLES LIKE "version"' | mysql -uroot -hmydb test -pexample ``` Running more than one pipeline result:  --------- Co-authored-by: elias.souza <elias.souza@quintoandar.com.br>
106 lines
3.1 KiB
Go
106 lines
3.1 KiB
Go
// Copyright 2022 Woodpecker Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package kubernetes
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/rs/zerolog/log"
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/api/errors"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/util/intstr"
|
|
|
|
"go.woodpecker-ci.org/woodpecker/v2/pipeline/backend/types"
|
|
)
|
|
|
|
const (
|
|
ServiceLabel = "service"
|
|
servicePrefix = "wp-svc-"
|
|
)
|
|
|
|
func mkService(step *types.Step, config *config) (*v1.Service, error) {
|
|
name, err := serviceName(step)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
selector := map[string]string{
|
|
ServiceLabel: name,
|
|
}
|
|
|
|
var svcPorts []v1.ServicePort
|
|
for _, port := range step.Ports {
|
|
svcPorts = append(svcPorts, servicePort(port))
|
|
}
|
|
|
|
log.Trace().Str("name", name).Interface("selector", selector).Interface("ports", svcPorts).Msg("creating service")
|
|
return &v1.Service{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: name,
|
|
Namespace: config.Namespace,
|
|
},
|
|
Spec: v1.ServiceSpec{
|
|
Type: v1.ServiceTypeClusterIP,
|
|
Selector: selector,
|
|
Ports: svcPorts,
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
func serviceName(step *types.Step) (string, error) {
|
|
return dnsName(servicePrefix + step.UUID + "-" + step.Name)
|
|
}
|
|
|
|
func servicePort(port types.Port) v1.ServicePort {
|
|
portNumber := int32(port.Number)
|
|
portProtocol := strings.ToUpper(port.Protocol)
|
|
return v1.ServicePort{
|
|
Name: fmt.Sprintf("port-%d", portNumber),
|
|
Port: portNumber,
|
|
Protocol: v1.Protocol(portProtocol),
|
|
TargetPort: intstr.IntOrString{IntVal: portNumber},
|
|
}
|
|
}
|
|
|
|
func startService(ctx context.Context, engine *kube, step *types.Step) (*v1.Service, error) {
|
|
engineConfig := engine.getConfig()
|
|
svc, err := mkService(step, engineConfig)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
log.Trace().Str("name", svc.Name).Interface("selector", svc.Spec.Selector).Interface("ports", svc.Spec.Ports).Msg("creating service")
|
|
return engine.client.CoreV1().Services(engineConfig.Namespace).Create(ctx, svc, metav1.CreateOptions{})
|
|
}
|
|
|
|
func stopService(ctx context.Context, engine *kube, step *types.Step, deleteOpts metav1.DeleteOptions) error {
|
|
svcName, err := serviceName(step)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
log.Trace().Str("name", svcName).Msg("deleting service")
|
|
|
|
err = engine.client.CoreV1().Services(engine.config.Namespace).Delete(ctx, svcName, deleteOpts)
|
|
if errors.IsNotFound(err) {
|
|
// Don't abort on 404 errors from k8s, they most likely mean that the pod hasn't been created yet, usually because pipeline was canceled before running all steps.
|
|
log.Trace().Err(err).Msgf("unable to delete service %s", svcName)
|
|
return nil
|
|
}
|
|
return err
|
|
}
|