woodpecker/pipeline/backend
Fernando Barbosa c7467b9828
fix: agent panic when node is terminated during step execution (#3331)
Fixes https://github.com/woodpecker-ci/woodpecker/issues/3330

This adds error handling on the agent's WaitStep function, on two
sections where it could encounter a `panic: runtime error: invalid
memory address or nil pointer dereference` in case it could no longer
access complete information about a specific pod.

This error was found to happen if the node in which the pod was running
was terminated during the step's execution.
spite active pipelines being executed on the node.

Now instead of a panic on the agent's logs and undefined behavior on the
UI it will display a more helpful error message on the UI.

### Additional context

We observed the bug first on v2.1.1, but tested the fix internally on
top of 2.3.0.


![image](https://github.com/woodpecker-ci/woodpecker/assets/7269710/dfbcf089-85f7-4b5d-8102-f21af95c5cda)
2024-02-05 22:46:14 +01:00
..
common Support custom steps entrypoint (#2985) 2024-01-19 05:34:02 +01:00
docker Clean up models (#3228) 2024-01-22 07:56:18 +01:00
kubernetes fix: agent panic when node is terminated during step execution (#3331) 2024-02-05 22:46:14 +01:00
local Add spellcheck config (#3018) 2024-01-27 21:15:10 +01:00
types Clean up models (#3228) 2024-01-22 07:56:18 +01:00
backend.go Enable golangci linter contextcheck (#3170) 2024-01-11 22:15:15 +01:00