mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-09-30 07:22:00 +00:00
52d3652f2e
Use IDs of the forge to fetch repositories instead of their names and owner names. This improves handling of renamed and transferred repos.
TODO
- [ ] try to support as many forges as possible
- [x] Gogs (no API)
- [ ] Bitbucket Server
- [x] Coding (no API?)
- [x] update repo every time it is fetched or received from the forge
- [x] if repo remote IDs are not available, use owner / name to get it
- [x] handle redirections (redirect a renamed repo to its new path)
- [x] ~~pull all repos once during migration to update ID (?)~~ issue fixed by on-demand loading of remote IDs
- [x] handle redirections in web UI
- [ ] improve handling of hooks after a repo was renamed (currently it checks for a redirection to the repo)
- [x] tests
- [x] `UNIQUE` constraint for remote IDs after migration shouldn't work (all repos have an empty string as remote ID)
close #854
close #648 partial
close https://codeberg.org/Codeberg-CI/feedback/issues/46
Possible follow-up PRs
- apply the same scheme on everything fetched from the remote (currently only users)
Co-authored-by: 6543 <6543@obermui.de>
44 lines
1.5 KiB
Go
44 lines
1.5 KiB
Go
// Copyright 2018 Drone.IO Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bitbucketserver
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/woodpecker-ci/woodpecker/server/model"
|
|
"github.com/woodpecker-ci/woodpecker/server/remote/bitbucketserver/internal"
|
|
)
|
|
|
|
// parseHook parses a Bitbucket hook from an http.Request request and returns
|
|
// Repo and Build detail. TODO: find a way to support PR hooks
|
|
func parseHook(r *http.Request, baseURL string) (*model.Repo, *model.Build, error) {
|
|
hook := new(internal.PostHook)
|
|
if err := json.NewDecoder(r.Body).Decode(hook); err != nil {
|
|
return nil, nil, err
|
|
}
|
|
build := convertPushHook(hook, baseURL)
|
|
repo := &model.Repo{
|
|
RemoteID: model.RemoteID(fmt.Sprint(hook.Repository.ID)),
|
|
Name: hook.Repository.Slug,
|
|
Owner: hook.Repository.Project.Key,
|
|
FullName: fmt.Sprintf("%s/%s", hook.Repository.Project.Key, hook.Repository.Slug),
|
|
Branch: "master",
|
|
SCMKind: model.RepoGit,
|
|
}
|
|
|
|
return repo, build, nil
|
|
}
|