mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2024-11-27 04:11:03 +00:00
4bc2fed550
Previously a graph like this. a <- b ^ ^ | | c <- d Was incorrectly recognized as having a cycle. Fixes #3048.
173 lines
4.4 KiB
Go
173 lines
4.4 KiB
Go
// Copyright 2023 Woodpecker Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compiler
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
|
|
backend_types "go.woodpecker-ci.org/woodpecker/v2/pipeline/backend/types"
|
|
)
|
|
|
|
type dagCompilerStep struct {
|
|
step *backend_types.Step
|
|
position int
|
|
name string
|
|
group string
|
|
dependsOn []string
|
|
}
|
|
|
|
type dagCompiler struct {
|
|
steps []*dagCompilerStep
|
|
prefix string
|
|
}
|
|
|
|
func newDAGCompiler(steps []*dagCompilerStep, prefix string) dagCompiler {
|
|
return dagCompiler{
|
|
steps: steps,
|
|
prefix: prefix,
|
|
}
|
|
}
|
|
|
|
func (c dagCompiler) isDAG() bool {
|
|
for _, v := range c.steps {
|
|
if len(v.dependsOn) != 0 {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (c dagCompiler) compile() ([]*backend_types.Stage, error) {
|
|
if c.isDAG() {
|
|
return c.compileByDependsOn()
|
|
}
|
|
return c.compileByGroup()
|
|
}
|
|
|
|
func (c dagCompiler) compileByGroup() ([]*backend_types.Stage, error) {
|
|
stages := make([]*backend_types.Stage, 0, len(c.steps))
|
|
var currentStage *backend_types.Stage
|
|
var currentGroup string
|
|
|
|
for _, s := range c.steps {
|
|
// create a new stage if current step is in a new group compared to last one
|
|
if currentStage == nil || currentGroup != s.group || s.group == "" {
|
|
currentGroup = s.group
|
|
|
|
currentStage = new(backend_types.Stage)
|
|
currentStage.Name = fmt.Sprintf("%s_stage_%v", c.prefix, s.position)
|
|
currentStage.Alias = s.name
|
|
stages = append(stages, currentStage)
|
|
}
|
|
|
|
// add step to current stage
|
|
currentStage.Steps = append(currentStage.Steps, s.step)
|
|
}
|
|
|
|
return stages, nil
|
|
}
|
|
|
|
func (c dagCompiler) compileByDependsOn() ([]*backend_types.Stage, error) {
|
|
stepMap := make(map[string]*dagCompilerStep, len(c.steps))
|
|
for _, s := range c.steps {
|
|
stepMap[s.name] = s
|
|
}
|
|
return convertDAGToStages(stepMap, c.prefix)
|
|
}
|
|
|
|
func dfsVisit(steps map[string]*dagCompilerStep, name string, visited map[string]struct{}, path []string) error {
|
|
if _, ok := visited[name]; ok {
|
|
return &ErrStepDependencyCycle{path: path}
|
|
}
|
|
|
|
visited[name] = struct{}{}
|
|
path = append(path, name)
|
|
|
|
for _, dep := range steps[name].dependsOn {
|
|
if err := dfsVisit(steps, dep, visited, path); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
delete(visited, name)
|
|
|
|
return nil
|
|
}
|
|
|
|
func convertDAGToStages(steps map[string]*dagCompilerStep, prefix string) ([]*backend_types.Stage, error) {
|
|
addedSteps := make(map[string]struct{})
|
|
stages := make([]*backend_types.Stage, 0)
|
|
|
|
for name, step := range steps {
|
|
// check if all depends_on are valid
|
|
for _, dep := range step.dependsOn {
|
|
if _, ok := steps[dep]; !ok {
|
|
return nil, &ErrStepMissingDependency{name: name, dep: dep}
|
|
}
|
|
}
|
|
|
|
// check if there are cycles
|
|
visited := make(map[string]struct{})
|
|
if err := dfsVisit(steps, name, visited, []string{}); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
for len(steps) > 0 {
|
|
addedNodesThisLevel := make(map[string]struct{})
|
|
stage := &backend_types.Stage{
|
|
Name: fmt.Sprintf("%s_stage_%d", prefix, len(stages)),
|
|
Alias: fmt.Sprintf("%s_stage_%d", prefix, len(stages)),
|
|
}
|
|
|
|
var stepsToAdd []*dagCompilerStep
|
|
for name, step := range steps {
|
|
if allDependenciesSatisfied(step, addedSteps) {
|
|
stepsToAdd = append(stepsToAdd, step)
|
|
addedNodesThisLevel[name] = struct{}{}
|
|
delete(steps, name)
|
|
}
|
|
}
|
|
|
|
// as steps are from a map that has no deterministic order,
|
|
// we sort the steps by original config position to make the order similar between pipelines
|
|
sort.Slice(stepsToAdd, func(i, j int) bool {
|
|
return stepsToAdd[i].position < stepsToAdd[j].position
|
|
})
|
|
|
|
for i := range stepsToAdd {
|
|
stage.Steps = append(stage.Steps, stepsToAdd[i].step)
|
|
}
|
|
|
|
for name := range addedNodesThisLevel {
|
|
addedSteps[name] = struct{}{}
|
|
}
|
|
|
|
stages = append(stages, stage)
|
|
}
|
|
|
|
return stages, nil
|
|
}
|
|
|
|
func allDependenciesSatisfied(step *dagCompilerStep, addedSteps map[string]struct{}) bool {
|
|
for _, childName := range step.dependsOn {
|
|
_, ok := addedSteps[childName]
|
|
if !ok {
|
|
return false
|
|
}
|
|
}
|
|
return true
|
|
}
|